MIME-Version: 1.0
References: 
 <CAO6_Xqoxp7C+y0L==xZXH5V=9PjpBx4T9vJYs87EbxFp_9nwOA@mail.gmail.com>
 <CA+hUKG++LE6P6g4n+-QPHBwAnvcVRyG1tUnzscUriWAFHc6s6Q@mail.gmail.com>
 <aZJuoggMUaXjwoDO@paquier.xyz>
 <aZLHYtCsEldmm8Eu@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAO6_XqpGYneOe357s4QhOTYpU6UEgk3JJrBiyeuk-9n=f7p=Vw@mail.gmail.com>
 <aoaj45foewpjtu6r5cs67yrx4en3pkurs23e4azv6tbikpw6c3@h3pnaqaksoeg>
 <b607e42e-34ff-414a-b727-dd5ec70babe3@timescale.com>
 <ed73b90b-e153-41ba-a626-2e13da42d6c8@iki.fi>
 <CALzhyqzKTRVsQGj+qDDRVs3Oo0EvffuQvVO0v4rbpWU=SoXKug@mail.gmail.com>
In-Reply-To: 
 <CALzhyqzKTRVsQGj+qDDRVs3Oo0EvffuQvVO0v4rbpWU=SoXKug@mail.gmail.com>
From: Alexander Kuzmenkov <akuzmenkov@tigerdata.com>
Date: Wed, 11 Mar 2026 12:07:58 +0100
Message-ID: 
 <CALzhyqzLh9iciLMvT9T-Z+o1ekOPpeP2p2r7tYXNZ8JMSea3Zg@mail.gmail.com>
Subject: Re: Fix uninitialized xl_running_xacts padding
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Andres Freund <andres@anarazel.de>,
 Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>,
	Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
	Thomas Munro <thomas.munro@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALzhyqzLh9iciLMvT9T-Z%2Bo1ekOPpeP2p2r7tYXNZ8JMSea3Zg%40mail.gmail.com>
Precedence: bulk

On Wed, Mar 11, 2026 at 11:45=E2=80=AFAM Alexander Kuzmenkov
<akuzmenkov@tigerdata.com> wrote:
>
> On Tue, Mar 10, 2026 at 11:09=E2=80=AFPM Heikki Linnakangas <hlinnaka@iki=
.fi> wrote:
> > +1 for initializing all padding in WAL records. In fact I thought that
> > we already did that. (Except in this case, apparently)
>
> I found 42 exceptions like this. See the attached patch, it
> initializes some WAL records and removes the WAL-related Valgrind
> suppressions. The regression tests pass under Valgrind with these
> changes.

I think I'm making some unneeded changes here though. For example in
ginxlogInsertListPage for a two-int struct with no padding. I'll need
to check them again one by one.