Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnLJZ-0001AF-29 for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Apr 2023 15:26:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pnLJX-0006TU-D2 for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Apr 2023 15:26:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnLJX-0006TK-31 for pgsql-hackers@lists.postgresql.org; Fri, 14 Apr 2023 15:26:15 +0000 Received: from mail-ua1-f47.google.com ([209.85.222.47]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pnLJU-0001zJ-HJ; Fri, 14 Apr 2023 15:26:13 +0000 Received: by mail-ua1-f47.google.com with SMTP id a38so11703200uax.12; Fri, 14 Apr 2023 08:26:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681485971; x=1684077971; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/3GNSIoIpKXIcSY+VFs9jpb/43WpR4qdt/wmL14wmaA=; b=Jx5lHJ/5dJDApLkFUQmdmGAjw3U6JMBV+031RPgVic/7bJicz5uHwnRecS9keBcSMq HP36iIisNHVdtLmf9LQsRN/u022fWhifOgM4+2pOhgAp5ExaNyqarWq27RiHldaEGrSB w4++ARusIrq/PYnDOYmg98g66+WM+cohVU1di/lVLZiCTMRl5bi2cH3s7yfLSF393oJR +hTr77PFW4hCPsOED18JCeoQaZh5C0pf1o1vgEXaNPN88wcRMQ/s9+qPhGGGQhoJ4TP9 C0gUmMldmHh4MEXe21guwrySAUAv/4KDf4MkahtF3G6CKNY+I1opB6WbYg63RUCDVCn+ Z05A== X-Gm-Message-State: AAQBX9deAfLcnogD9pYW64K10YmHSCUzwdoh7XofrBw23qh3CgDuz5xR fJSGEz9+8PPnSGOZu9VeeZnN0SgDVF2P8XVu4yzA6FIx X-Google-Smtp-Source: AKy350Z0XNpqIZVMajqgUC5nIrCzquILBEl0lzLS5DQYRxd2vOjthweevvt8jRoUb8VelqQ2QOnsVSUWiBJ+bHzmTR0= X-Received: by 2002:a1f:2b14:0:b0:43c:aa3:bf3d with SMTP id r20-20020a1f2b14000000b0043c0aa3bf3dmr3182779vkr.1.1681485970731; Fri, 14 Apr 2023 08:26:10 -0700 (PDT) MIME-Version: 1.0 References: <20230317230930.nhsgk3qfk7f4axls@awork3.anarazel.de> <20230318093357.g4e3eexqg6dxmuel@alvherre.pgsql> <20230322170048.ffbnfr5o2jrjgb2f@awork3.anarazel.de> <20230411182010.zsldtjrxe5m2bqzp@awork3.anarazel.de> <490f1ebd-03fc-d996-cc5e-7991569a9e45@postgresql.org> <2755ebe5-5ab6-7509-cf47-c606be5583cd@postgresql.org> In-Reply-To: <2755ebe5-5ab6-7509-cf47-c606be5583cd@postgresql.org> From: Greg Stark Date: Fri, 14 Apr 2023 11:25:34 -0400 Message-ID: Subject: Re: Should we remove vacuum_defer_cleanup_age? To: "Jonathan S. Katz" Cc: Robert Haas , Laurenz Albe , Amit Kapila , Andres Freund , Justin Pryzby , Alvaro Herrera , pgsql-hackers@postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, 14 Apr 2023 at 09:47, Jonathan S. Katz wrote: > > Let me restate [1] in a different way. > > Using a large enough dataset, I did qualitatively look at overall usage > of both "vacuum_defer_cleanup_age" and compared to > "hot_standby_feedback", given you can use both to accomplish similar > outcomes. I assume people would use hot_standby_feedback if they have streaming replication. The main use cases for vacuum_defer_cleanup_age would be if you're replaying WAL files. That may sound archaic but there are plenty of circumstances where your standby may not have network access to your primary at all or not want to be replaying continuously. I wonder whether your dataset is self-selecting sites that have streaming replication. That does seem like the more common usage pattern. Systems using wal files are more likely to be things like data warehouses, offline analytics systems, etc. They may not even be well known in the same organization that runs the online operations -- in my experience they're often run by marketing or sales organizations or in some cases infosec teams and consume data from lots of sources. The main reason to use wal archive replay is often to provide the isolation so that the operations team don't need to worry about the impact on production and that makes it easy to forget these even exist. -- greg