MIME-Version: 1.0
References: <003001d8f4ae$402282c0$c0678840$@pcorp.us> <000401d94bc8$48dff700$da9fe500$@pcorp.us>
 <167762779361.628976.14009177203307564086.pgcf@coridan.postgresql.org>
In-Reply-To: <167762779361.628976.14009177203307564086.pgcf@coridan.postgresql.org>
From: "Gregory Stark (as CFM)" <stark.cfm@gmail.com>
Date: Mon, 6 Mar 2023 13:49:51 -0500
Message-ID: <CAM-w4HP91M-r=h4nExwonHf03SRwKyNYnvFHX2FFoFMv0pRQBA@mail.gmail.com>
Subject: Re: Ability to reference other extensions by schema in extension scripts
To: Sandro Santilli <strk@kbt.io>
Cc: pgsql-hackers@lists.postgresql.org, Regina Obe <r@pcorp.us>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAM-w4HP91M-r%3Dh4nExwonHf03SRwKyNYnvFHX2FFoFMv0pRQBA%40mail.gmail.com>
Precedence: bulk

It looks like this patch needs a quick rebase, there's a conflict in
the meson.build.

I'll leave the state since presumably this would be easy to resolve
but it would be more likely to get attention if it's actually building
cleanly.

http://cfbot.cputube.org/patch_42_4023.log

On Tue, 28 Feb 2023 at 18:44, Sandro Santilli <strk@kbt.io> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, failed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            tested, passed
>
> I've applied the patch attached to message https://www.postgresql.org/mes=
sage-id/000401d94bc8%2448dff700%24da9fe500%24%40pcorp.us (md5sum a7d45a32c0=
54919d94cd4a26d7d07c20) onto current tip of the master branch being 128dd9f=
9eca0b633b51ffcd5b0f798fbc48ec4c0
>
> The review written in https://www.postgresql.org/message-id/2023022822460=
8.ak7br5shev4wic5a%40c19 all still applies.
>
> The `make installcheck-world`  test fails for me but the failures seem un=
related to the patch (many occurrences of "+ERROR:  function pg_input_error=
_info(unknown, unknown) does not exist" in the regression.diff).
>
> Documentation exists for the new feature
>
> The new status of this patch is: Ready for Committer


--=20
Gregory Stark
As Commitfest Manager