MIME-Version: 1.0
References: 
 <CAM2+6=XjTyqrrqHAOj80r0wVQxJSxc0iyib9bPC55uFO9VKatg@mail.gmail.com>
 <CAM2+6=UrDfcsz0xn+oUmomOnPYazuP8dAM_Wrx5YMsWxXjWyKA@mail.gmail.com>
 <d37da0bc-204a-125a-dfeb-c3d7cc639d69@dunslane.net>
 <CAM2+6=UMCtXVSk1NmGHzsYYY6xGdnaMMKxVaKUtG7o0jkiuyQg@mail.gmail.com>
 <e913dde5-0209-441c-8040-dd2ace6415e0@eisentraut.org>
 <fa454906-7539-4070-b51a-2e7dcfb6b741@eisentraut.org>
 <CAM2+6=XPHNJnGypXy2C_5TUWgCxCktz1GrwuzsSZSqb_R+pMXQ@mail.gmail.com>
 <CAM2+6=WYbL4gxpmEJcN5BvLYuMZUpruLQRZxFeKTBNNpksgN=g@mail.gmail.com>
 <cc883de1-ae89-438b-a97e-926ad332f5ba@eisentraut.org>
 <CAM2+6=WyoinYoiuf3msxqH-hsPBoUz33MmrCpD_4Ceo6Nq1qOg@mail.gmail.com>
 <1d092c02-8249-4e56-8b8e-ae4db95b8fde@eisentraut.org>
 <CAM2+6=Wys-tgwA15WkgW+8uR0SKncFLZuj0B+ukjvxbrebz9qQ@mail.gmail.com>
 <5d37428e-0753-e721-8e77-81cc4d0dc9f1@dunslane.net>
 <439811.1706211069@sss.pgh.pa.us>
 <448055.1706214831@sss.pgh.pa.us> <451195.1706216300@sss.pgh.pa.us>
 <65ac43de-8abe-f9ef-1fe8-838ea22e9c45@dunslane.net>
In-Reply-To: <65ac43de-8abe-f9ef-1fe8-838ea22e9c45@dunslane.net>
From: Jeevan Chalke <jeevan.chalke@enterprisedb.com>
Date: Fri, 26 Jan 2024 18:07:15 +0530
Message-ID: 
 <CAM2+6=V1euSMRnYPv7s7JCndFk_3rfmaSny6So2+VJs2Xxd6Hw@mail.gmail.com>
Subject: Re: More new SQL/JSON item methods
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000090e924060fd89040"
Archived-At: 
 <https://www.postgresql.org/message-id/CAM2%2B6%3DV1euSMRnYPv7s7JCndFk_3rfmaSny6So2%2BVJs2Xxd6Hw%40mail.gmail.com>
Precedence: bulk

--00000000000090e924060fd89040
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 26, 2024 at 2:57=E2=80=AFAM Andrew Dunstan <andrew@dunslane.net=
> wrote:

>
> On 2024-01-25 Th 15:58, Tom Lane wrote:
> > I wrote:
> >> There's something else going on, because I'm still getting the
> >> assertion failure on my Mac with this fix in place.  Annoyingly,
> >> it goes away if I compile with -O0, so it's kind of hard to
> >> identify what's going wrong.
> > No, belay that: I must've got confused about which version I was
> > testing.  It's very unclear to me why the undefined reference
> > causes the preceding Assert to misbehave, but that is clearly
> > what's happening.  Compiler bug maybe?  My Mac has clang 15.0.0,
> > and the unhappy buildfarm members are also late-model clang.
> >
> > Anyway, I did note that the preceding line
> >
> >       res =3D jperOk;
> >
> > is dead code and might as well get removed while you're at it.
> >
> >
>
>
> OK, pushed those. Thanks.
>

Thank you all.


>
>
> cheers
>
>
> andrew
>
> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com
>
>

--=20
Jeevan Chalke

*Principal, ManagerProduct Development*


edbpostgres.com

--00000000000090e924060fd89040
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jan 26, 2024 at 2:57=E2=80=AF=
AM Andrew Dunstan &lt;<a href=3D"mailto:andrew@dunslane.net">andrew@dunslan=
e.net</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex"><br>
On 2024-01-25 Th 15:58, Tom Lane wrote:<br>
&gt; I wrote:<br>
&gt;&gt; There&#39;s something else going on, because I&#39;m still getting=
 the<br>
&gt;&gt; assertion failure on my Mac with this fix in place.=C2=A0 Annoying=
ly,<br>
&gt;&gt; it goes away if I compile with -O0, so it&#39;s kind of hard to<br=
>
&gt;&gt; identify what&#39;s going wrong.<br>
&gt; No, belay that: I must&#39;ve got confused about which version I was<b=
r>
&gt; testing.=C2=A0 It&#39;s very unclear to me why the undefined reference=
<br>
&gt; causes the preceding Assert to misbehave, but that is clearly<br>
&gt; what&#39;s happening.=C2=A0 Compiler bug maybe?=C2=A0 My Mac has clang=
 15.0.0,<br>
&gt; and the unhappy buildfarm members are also late-model clang.<br>
&gt;<br>
&gt; Anyway, I did note that the preceding line<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0res =3D jperOk;<br>
&gt;<br>
&gt; is dead code and might as well get removed while you&#39;re at it.<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0<br>
<br>
<br>
OK, pushed those. Thanks.<br></blockquote><div><br></div><div>Thank you all=
.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0=
px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
cheers<br>
<br>
<br>
andrew<br>
<br>
--<br>
Andrew Dunstan<br>
EDB: <a href=3D"https://www.enterprisedb.com" rel=3D"noreferrer" target=3D"=
_blank">https://www.enterprisedb.com</a><br>
<br>
</blockquote></div><br clear=3D"all"><div><br></div><span class=3D"gmail_si=
gnature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><d=
iv dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D=
"ltr">Jeevan Chalke<br><i>Principal, Manager<br>Product Development</i><br>=
<span></span><br><span></span><span></span><img height=3D"60" width=3D"180"=
 src=3D"https://ci3.googleusercontent.com/mail-sig/AIorK4yTnojkzOao3BhtEiPw=
oUi3phZHCVxIe3hMvKqC0iJJ77R_VaQc6coM4Vg6UkaVsAGqZrQR8gU"><span style=3D"fon=
t-size:11pt;font-family:Arial;color:rgb(255,62,0);background-color:rgb(255,=
255,255);font-weight:700;font-style:normal;font-variant:normal;text-decorat=
ion:none;vertical-align:baseline;white-space:pre-wrap"><br><br><a href=3D"h=
ttp://edbpostgres.com" target=3D"_blank">edbpostgres.com</a></span></div></=
div></div></div></div></div></div></div></div>

--00000000000090e924060fd89040--