MIME-Version: 1.0
References: 
 <CAMPB6wfe4zLjJL8jiZV5kjjpwBM2=rTRme0UCL7Ra4L8MTVdOg@mail.gmail.com>
 <b9666b93-093b-4c9f-a385-772d6ab5688c@app.fastmail.com>
 <CAMPB6we7+97L72Ru0=WxMDi24xMbZgr2B8Nwoo5i=r=UNuG_gQ@mail.gmail.com>
 <a4ee2198-5309-4b6f-90ef-c08b45a2f572@app.fastmail.com>
 <CAA4eK1JfPPFTmz7mUk26zPH8+qH9UBpkquxw75x7Ngx_D_6XXQ@mail.gmail.com>
 <CAMPB6wfgvWjSvKNPoJkRqaL46geRDoL++Pt_3Czc2QNAdpVQHw@mail.gmail.com>
 <CAA4eK1JC6yB6q52qEZ5dLNWRUEZoO-aa_XKBZ3_mcb=V2z7zug@mail.gmail.com>
 <CAMPB6weUqU6P2w5VUGVSLKWcvU1AQHmW+7O9qc9yD4CB5kEYVA@mail.gmail.com>
 <CAA4eK1Lm_W5j3DPj6PDSTyodGu87QgxpNwwsi-wVR0+B1FSOoA@mail.gmail.com>
 <CAMPB6wckvkKrXVPH5j8Ske2cVedkb-TRLdnOb5e74zYM1CynGw@mail.gmail.com>
 <CAA4eK1+NDjprcKvr0p2GDMTCs9yxFCY41bOd+6avqAm2n+TXdQ@mail.gmail.com>
 <CAMPB6wdc10tc7gpVXG75r51M41zVSabip9Lz7hssWEtyhecWww@mail.gmail.com>
 <OSCPR01MB14966201F1DCB853145912FF1F53DA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAMPB6wcOWBURHB1igRgCjD3geAemdoATfkKByMwrMM1TgMN64w@mail.gmail.com>
 <OSCPR01MB14966BF4CA9B767C259DBD9CDF53EA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAMPB6wdtKZLEeZ7UW=DYmXWv8Y=uVGrDqXTMhT19Z4VTzo3cfg@mail.gmail.com>
 <CAA4eK1LHVd8wQzauWgeEV436L7btrCfujPH1sR196sY_Mp8zYA@mail.gmail.com>
In-Reply-To: 
 <CAA4eK1LHVd8wQzauWgeEV436L7btrCfujPH1sR196sY_Mp8zYA@mail.gmail.com>
From: Doruk Yilmaz <doruk@mixrank.com>
Date: Mon, 8 Sep 2025 20:22:22 +0300
Message-ID: 
 <CAMPB6wdPtjbR93oB1XJtYkRtTR64BJG4o5a+0DSSez=puuyuGA@mail.gmail.com>
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Content-Type: multipart/mixed; boundary="000000000000e897b7063e4d6ee1"
Archived-At: 
 <https://www.postgresql.org/message-id/CAMPB6wdPtjbR93oB1XJtYkRtTR64BJG4o5a%2B0DSSez%3DpuuyuGA%40mail.gmail.com>
Precedence: bulk

--000000000000e897b7063e4d6ee1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> Then why didn't you specified PARALLEL UNSAFE as well?

You are correct, I missed marking the function as PARALLEL UNSAFE.
I=E2=80=99ve attached a revised patch with the correct annotation.

> BTW, yesterday a new thread started with the same requirement [1]. It
> uses a slightly different way to define the new function. do you have
> any opinion on it?

I don=E2=80=99t think introducing a separate function is a good idea. It=E2=
=80=99s
effectively the same behavior, technical debt, and maintenance
overhead without a clear benefit.
Our patch keeps a single function with a default parameter, so it=E2=80=99s
not a breaking change. So I believe our approach is preferable.
But I would say that, the fact that another patch is proposing the
same capability indicates there=E2=80=99s broader demand for this change.

--000000000000e897b7063e4d6ee1
Content-Type: text/x-patch; charset="US-ASCII";
	name="v6-0001-pg_replication_origin_session_setup-pid-parameter.patch"
Content-Disposition: attachment;
	filename="v6-0001-pg_replication_origin_session_setup-pid-parameter.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mfbe2vtn0>
X-Attachment-Id: f_mfbe2vtn0

RnJvbSA3NGE3NGZkMDJiY2U3ODYwOTNjMTlhMjNiZWY5NDQ0ZDBiOGVmNDFkIE1vbiBTZXAgOCAw
MDowMDowMCAyMDI1CkZyb206IERvcnVrIDxkb3J1a0BtaXhyYW5rLmNvbT4KRGF0ZTogTW9uLCA4
IFNlcCAyMDI1IDE0OjIyOjE1ICswMzAwClN1YmplY3Q6IFtQQVRDSCB2Nl0gcGdfcmVwbGljYXRp
b25fb3JpZ2luX3Nlc3Npb25fc2V0dXA6IHBpZCBwYXJhbWV0ZXIKClNpbmNlIHRoZSBpbnRyb2R1
Y3Rpb24gb2YgcGFyYWxsZWwgYXBwbHkgd29ya2VycyAoY29tbWl0IDIxNmE3ODQ4MjljKSwKdGhl
IHJlcGxvcmlnaW5fc2Vzc2lvbl9zZXR1cCgpIHdhcyBleHRlbmRlZCB0byBhY2NlcHQgYW4gZXh0
cmEKcGFyYW1ldGVyOiBwaWQuIFRoaXMgcHJvY2VzcyBJRCBpcyB1c2VkIHRvIGluZm9ybSB0aGF0
IG11bHRpcGxlCnByb2Nlc3NlcyBhcmUgc2hhcmluZyB0aGUgc2FtZSByZXBsaWNhdGlvbiBvcmln
aW4gdG8gYXBwbHkgY2hhbmdlcyBpbgpwYXJhbGxlbC4gVGhlIHJlcGxvcmlnaW5fc2Vzc2lvbl9z
ZXR1cCBmdW5jdGlvbiBoYXMgYSBTUUwgdXNlcgppbnRlcmZhY2U6IHBnX3JlcGxpY2F0aW9uX29y
aWdpbl9zZXNzaW9uX3NldHVwLiBUaGlzIGNvbW1pdCBhZGRzIGFuCm9wdGlvbmFsIHBhcmFtZXRl
ciB0aGF0IHBhc3NlcyB0aGUgcHJvY2VzcyBJRCB0byB0aGUgaW50ZXJuYWwgZnVuY3Rpb24KcmVw
bG9yaWdpbl9zZXNzaW9uX3NldHVwLiBJdCBhbGxvd3MgbXVsdGlwbGUgcHJvY2Vzc2VzIHRvIHVz
ZSB0aGUgc2FtZQpyZXBsaWNhdGlvbiBvcmlnaW4gaWYgeW91IGFyZSB1c2luZyB0aGUgcmVwbGlj
YXRpb24gZnVuY3Rpb25zLgotLS0KIGRvYy9zcmMvc2dtbC9mdW5jL2Z1bmMtYWRtaW4uc2dtbCAg
ICAgICAgfCAyMiArKysrKysrKysrKysrKysrKysrKy0tCiBzcmMvYmFja2VuZC9jYXRhbG9nL3N5
c3RlbV9mdW5jdGlvbnMuc3FsIHwgIDkgKysrKysrKystCiBzcmMvYmFja2VuZC9yZXBsaWNhdGlv
bi9sb2dpY2FsL29yaWdpbi5jIHwgIDQgKysrLQogc3JjL2luY2x1ZGUvY2F0YWxvZy9wZ19wcm9j
LmRhdCAgICAgICAgICB8ICAyICstCiA0IGZpbGVzIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyks
IDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL2Z1bmMvZnVuYy1hZG1p
bi5zZ21sIGIvZG9jL3NyYy9zZ21sL2Z1bmMvZnVuYy1hZG1pbi5zZ21sCmluZGV4IDQ0NmZkZmUu
LjRiODY2NzYgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9mdW5jL2Z1bmMtYWRtaW4uc2dtbAor
KysgYi9kb2Mvc3JjL3NnbWwvZnVuYy9mdW5jLWFkbWluLnNnbWwKQEAgLTEzMTUsNyArMTMxNSw3
IEBAIHBvc3RncmVzPSMgU0VMRUNUICcwLzAnOjpwZ19sc24gKyBwZC5zZWdtZW50X251bWJlciAq
IHBzLnNldHRpbmc6OmludCArIDpvZmZzZXQKICAgICAgICAgPGluZGV4dGVybT4KICAgICAgICAg
IDxwcmltYXJ5PnBnX3JlcGxpY2F0aW9uX29yaWdpbl9zZXNzaW9uX3NldHVwPC9wcmltYXJ5Pgog
ICAgICAgICA8L2luZGV4dGVybT4KLSAgICAgICAgPGZ1bmN0aW9uPnBnX3JlcGxpY2F0aW9uX29y
aWdpbl9zZXNzaW9uX3NldHVwPC9mdW5jdGlvbj4gKCA8cGFyYW1ldGVyPm5vZGVfbmFtZTwvcGFy
YW1ldGVyPiA8dHlwZT50ZXh0PC90eXBlPiApCisgICAgICAgIDxmdW5jdGlvbj5wZ19yZXBsaWNh
dGlvbl9vcmlnaW5fc2Vzc2lvbl9zZXR1cDwvZnVuY3Rpb24+ICggPHBhcmFtZXRlcj5ub2RlX25h
bWU8L3BhcmFtZXRlcj4gPHR5cGU+dGV4dDwvdHlwZT4gPG9wdGlvbmFsPiwgPHBhcmFtZXRlcj5w
aWQ8L3BhcmFtZXRlcj4gPHR5cGU+aW50ZWdlcjwvdHlwZT4gPGxpdGVyYWw+REVGQVVMVDwvbGl0
ZXJhbD4gPGxpdGVyYWw+MDwvbGl0ZXJhbD48L29wdGlvbmFsPiApCiAgICAgICAgIDxyZXR1cm52
YWx1ZT52b2lkPC9yZXR1cm52YWx1ZT4KICAgICAgICA8L3BhcmE+CiAgICAgICAgPHBhcmE+CkBA
IC0xMzIzLDcgKzEzMjMsMjYgQEAgcG9zdGdyZXM9IyBTRUxFQ1QgJzAvMCc6OnBnX2xzbiArIHBk
LnNlZ21lbnRfbnVtYmVyICogcHMuc2V0dGluZzo6aW50ICsgOm9mZnNldAogICAgICAgICBvcmln
aW4sIGFsbG93aW5nIHJlcGxheSBwcm9ncmVzcyB0byBiZSB0cmFja2VkLgogICAgICAgICBDYW4g
b25seSBiZSB1c2VkIGlmIG5vIG9yaWdpbiBpcyBjdXJyZW50bHkgc2VsZWN0ZWQuCiAgICAgICAg
IFVzZSA8ZnVuY3Rpb24+cGdfcmVwbGljYXRpb25fb3JpZ2luX3Nlc3Npb25fcmVzZXQ8L2Z1bmN0
aW9uPiB0byB1bmRvLgotICAgICAgIDwvcGFyYT48L2VudHJ5PgorICAgICAgICBJZiBtdWx0aXBs
ZSBwcm9jZXNzZXMgY2FuIHNhZmVseSB1c2UgdGhlIHNhbWUgcmVwbGljYXRpb24gb3JpZ2luIChm
b3IKKyAgICAgICAgZXhhbXBsZSwgcGFyYWxsZWwgYXBwbHkgcHJvY2Vzc2VzKSwgdGhlIG9wdGlv
bmFsIDxwYXJhbWV0ZXI+cGlkPC9wYXJhbWV0ZXI+CisgICAgICAgIHBhcmFtZXRlciBjYW4gYmUg
dXNlZCB0byBzcGVjaWZ5IHRoZSBwcm9jZXNzIElEIG9mIHRoZSBmaXJzdCBwcm9jZXNzLgorICAg
ICAgICBUaGUgZmlyc3QgcHJvY2VzcyBtdXN0IHByb3ZpZGUgPHBhcmFtZXRlcj5waWQ8L3BhcmFt
ZXRlcj4gZXF1YWxzIHRvCisgICAgICAgIDxsaXRlcmFsPjA8L2xpdGVyYWw+IGFuZCB0aGUgb3Ro
ZXIgcHJvY2Vzc2VzIHRoYXQgc2hhcmUgdGhlIHNhbWUKKyAgICAgICAgcmVwbGljYXRpb24gb3Jp
Z2luIHNob3VsZCBwcm92aWRlIHRoZSBwcm9jZXNzIElEIG9mIHRoZSBmaXJzdCBwcm9jZXNzLgor
ICAgICAgIDwvcGFyYT4KKyAgICAgICA8Y2F1dGlvbj4KKyAgICAgICAgPHBhcmE+CisgICAgICAg
ICBXaGVuIG11bHRpcGxlIHByb2Nlc3NlcyBzaGFyZSB0aGUgc2FtZSByZXBsaWNhdGlvbiBvcmln
aW4sIGl0IGlzIGNyaXRpY2FsCisgICAgICAgICB0byBtYWludGFpbiBjb21taXQgb3JkZXIgdG8g
cHJldmVudCBkYXRhIGluY29uc2lzdGVuY3kuIFdoaWxlIHByb2Nlc3NlcworICAgICAgICAgbWF5
IHNlbmQgb3BlcmF0aW9ucyBvdXQgb2Ygb3JkZXIsIHRoZXkgbXVzdCBjb21taXQgdHJhbnNhY3Rp
b25zIGluIHRoZQorICAgICAgICAgY29ycmVjdCBzZXF1ZW5jZSB0byBlbnN1cmUgcHJvcGVyIHJl
cGxpY2F0aW9uIGNvbnNpc3RlbmN5LiBUaGUgcmVjb21tZW5kZWQgd29ya2Zsb3cKKyAgICAgICAg
IGZvciBlYWNoIHdvcmtlciBpczogc2V0IHVwIHRoZSByZXBsaWNhdGlvbiBvcmlnaW4gc2Vzc2lv
biB3aXRoIHRoZSBmaXJzdCBwcm9jZXNzJ3MgUElELAorICAgICAgICAgYXBwbHkgY2hhbmdlcyB3
aXRoaW4gdHJhbnNhY3Rpb25zLCBjYWxsIDxmdW5jdGlvbj5wZ19yZXBsaWNhdGlvbl9vcmlnaW5f
eGFjdF9zZXR1cDwvZnVuY3Rpb24+CisgICAgICAgICB3aXRoIHRoZSBMU04gYW5kIGNvbW1pdCB0
aW1lc3RhbXAgYmVmb3JlIGNvbW1pdHRpbmcsIHRoZW4gY29tbWl0IHRoZQorICAgICAgICAgdHJh
bnNhY3Rpb24gb25seSBpZiBldmVyeXRoaW5nIHN1Y2NlZWRlZC4KKyAgICAgICAgPC9wYXJhPgor
ICAgICAgIDwvY2F1dGlvbj4KKyAgICAgIDwvZW50cnk+CiAgICAgICA8L3Jvdz4KCiAgICAgICA8
cm93PgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvY2F0YWxvZy9zeXN0ZW1fZnVuY3Rpb25zLnNx
bCBiL3NyYy9iYWNrZW5kL2NhdGFsb2cvc3lzdGVtX2Z1bmN0aW9ucy5zcWwKaW5kZXggNTY2ZjMw
OC4uZjYwMjg3ZCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvY2F0YWxvZy9zeXN0ZW1fZnVuY3Rp
b25zLnNxbAorKysgYi9zcmMvYmFja2VuZC9jYXRhbG9nL3N5c3RlbV9mdW5jdGlvbnMuc3FsCkBA
IC02NTAsNiArNjUwLDEzIEBAIExBTkdVQUdFIElOVEVSTkFMCiBDQUxMRUQgT04gTlVMTCBJTlBV
VCBWT0xBVElMRSBQQVJBTExFTCBTQUZFCiBBUyAncGdfc3RhdF9yZXNldF9zbHJ1JzsKCitDUkVB
VEUgT1IgUkVQTEFDRSBGVU5DVElPTgorICBwZ19yZXBsaWNhdGlvbl9vcmlnaW5fc2Vzc2lvbl9z
ZXR1cChub2RlX25hbWUgdGV4dCwgcGlkIGludGVnZXIgREVGQVVMVCAwKQorUkVUVVJOUyB2b2lk
CitMQU5HVUFHRSBJTlRFUk5BTAorU1RSSUNUIFZPTEFUSUxFIFBBUkFMTEVMIFVOU0FGRQorQVMg
J3BnX3JlcGxpY2F0aW9uX29yaWdpbl9zZXNzaW9uX3NldHVwJzsKKwogLS0KIC0tIFRoZSBkZWZh
dWx0IHBlcm1pc3Npb25zIGZvciBmdW5jdGlvbnMgbWVhbiB0aGF0IGFueW9uZSBjYW4gZXhlY3V0
ZSB0aGVtLgogLS0gQSBudW1iZXIgb2YgZnVuY3Rpb25zIHNob3VsZG4ndCBiZSBleGVjdXRhYmxl
IGJ5IGp1c3QgYW55b25lLCBidXQgcmF0aGVyCkBAIC03NTEsNyArNzU4LDcgQEAgUkVWT0tFIEVY
RUNVVEUgT04gRlVOQ1RJT04gcGdfcmVwbGljYXRpb25fb3JpZ2luX3Nlc3Npb25fcHJvZ3Jlc3Mo
Ym9vbGVhbikgRlJPTQoKIFJFVk9LRSBFWEVDVVRFIE9OIEZVTkNUSU9OIHBnX3JlcGxpY2F0aW9u
X29yaWdpbl9zZXNzaW9uX3Jlc2V0KCkgRlJPTSBwdWJsaWM7CgotUkVWT0tFIEVYRUNVVEUgT04g
RlVOQ1RJT04gcGdfcmVwbGljYXRpb25fb3JpZ2luX3Nlc3Npb25fc2V0dXAodGV4dCkgRlJPTSBw
dWJsaWM7CitSRVZPS0UgRVhFQ1VURSBPTiBGVU5DVElPTiBwZ19yZXBsaWNhdGlvbl9vcmlnaW5f
c2Vzc2lvbl9zZXR1cCh0ZXh0LCBpbnRlZ2VyKSBGUk9NIHB1YmxpYzsKCiBSRVZPS0UgRVhFQ1VU
RSBPTiBGVU5DVElPTiBwZ19yZXBsaWNhdGlvbl9vcmlnaW5feGFjdF9yZXNldCgpIEZST00gcHVi
bGljOwoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvb3JpZ2lu
LmMgYi9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL29yaWdpbi5jCmluZGV4IDg3ZjEw
ZTUuLjk4ZDQ3ZTEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwv
b3JpZ2luLmMKKysrIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC9vcmlnaW4uYwpA
QCAtMTM3NCwxMiArMTM3NCwxNCBAQCBwZ19yZXBsaWNhdGlvbl9vcmlnaW5fc2Vzc2lvbl9zZXR1
cChQR19GVU5DVElPTl9BUkdTKQogewogCWNoYXIJICAgKm5hbWU7CiAJUmVwT3JpZ2luSWQgb3Jp
Z2luOworCWludAkJCXBpZDsKCiAJcmVwbG9yaWdpbl9jaGVja19wcmVyZXF1aXNpdGVzKHRydWUs
IGZhbHNlKTsKCiAJbmFtZSA9IHRleHRfdG9fY3N0cmluZygodGV4dCAqKSBEYXR1bUdldFBvaW50
ZXIoUEdfR0VUQVJHX0RBVFVNKDApKSk7CiAJb3JpZ2luID0gcmVwbG9yaWdpbl9ieV9uYW1lKG5h
bWUsIGZhbHNlKTsKLQlyZXBsb3JpZ2luX3Nlc3Npb25fc2V0dXAob3JpZ2luLCAwKTsKKwlwaWQg
PSBQR19HRVRBUkdfSU5UMzIoMSk7CisJcmVwbG9yaWdpbl9zZXNzaW9uX3NldHVwKG9yaWdpbiwg
cGlkKTsKCiAJcmVwbG9yaWdpbl9zZXNzaW9uX29yaWdpbiA9IG9yaWdpbjsKCmRpZmYgLS1naXQg
YS9zcmMvaW5jbHVkZS9jYXRhbG9nL3BnX3Byb2MuZGF0IGIvc3JjL2luY2x1ZGUvY2F0YWxvZy9w
Z19wcm9jLmRhdAppbmRleCAxMThkNmRhLi5kZDJkOTM4IDEwMDY0NAotLS0gYS9zcmMvaW5jbHVk
ZS9jYXRhbG9nL3BnX3Byb2MuZGF0CisrKyBiL3NyYy9pbmNsdWRlL2NhdGFsb2cvcGdfcHJvYy5k
YXQKQEAgLTEyMjIzLDcgKzEyMjIzLDcgQEAKIHsgb2lkID0+ICc2MDA2JywKICAgZGVzY3IgPT4g
J2NvbmZpZ3VyZSBzZXNzaW9uIHRvIG1haW50YWluIHJlcGxpY2F0aW9uIHByb2dyZXNzIHRyYWNr
aW5nIGZvciB0aGUgcGFzc2VkIGluIG9yaWdpbicsCiAgIHByb25hbWUgPT4gJ3BnX3JlcGxpY2F0
aW9uX29yaWdpbl9zZXNzaW9uX3NldHVwJywgcHJvdm9sYXRpbGUgPT4gJ3YnLAotICBwcm9wYXJh
bGxlbCA9PiAndScsIHByb3JldHR5cGUgPT4gJ3ZvaWQnLCBwcm9hcmd0eXBlcyA9PiAndGV4dCcs
CisgIHByb3BhcmFsbGVsID0+ICd1JywgcHJvcmV0dHlwZSA9PiAndm9pZCcsIHByb2FyZ3R5cGVz
ID0+ICd0ZXh0IGludDQnLAogICBwcm9zcmMgPT4gJ3BnX3JlcGxpY2F0aW9uX29yaWdpbl9zZXNz
aW9uX3NldHVwJyB9LAoKIHsgb2lkID0+ICc2MDA3JywgZGVzY3IgPT4gJ3RlYXJkb3duIGNvbmZp
Z3VyZWQgcmVwbGljYXRpb24gcHJvZ3Jlc3MgdHJhY2tpbmcnLAo=
--000000000000e897b7063e4d6ee1--