MIME-Version: 1.0
References: 
 <CAMPB6wfe4zLjJL8jiZV5kjjpwBM2=rTRme0UCL7Ra4L8MTVdOg@mail.gmail.com>
 <b9666b93-093b-4c9f-a385-772d6ab5688c@app.fastmail.com>
 <CAMPB6we7+97L72Ru0=WxMDi24xMbZgr2B8Nwoo5i=r=UNuG_gQ@mail.gmail.com>
 <a4ee2198-5309-4b6f-90ef-c08b45a2f572@app.fastmail.com>
 <CAA4eK1JfPPFTmz7mUk26zPH8+qH9UBpkquxw75x7Ngx_D_6XXQ@mail.gmail.com>
 <CAMPB6wfgvWjSvKNPoJkRqaL46geRDoL++Pt_3Czc2QNAdpVQHw@mail.gmail.com>
 <CAA4eK1JC6yB6q52qEZ5dLNWRUEZoO-aa_XKBZ3_mcb=V2z7zug@mail.gmail.com>
 <CAMPB6weUqU6P2w5VUGVSLKWcvU1AQHmW+7O9qc9yD4CB5kEYVA@mail.gmail.com>
 <CAA4eK1Lm_W5j3DPj6PDSTyodGu87QgxpNwwsi-wVR0+B1FSOoA@mail.gmail.com>
 <CAMPB6wckvkKrXVPH5j8Ske2cVedkb-TRLdnOb5e74zYM1CynGw@mail.gmail.com>
 <CAA4eK1+NDjprcKvr0p2GDMTCs9yxFCY41bOd+6avqAm2n+TXdQ@mail.gmail.com>
In-Reply-To: 
 <CAA4eK1+NDjprcKvr0p2GDMTCs9yxFCY41bOd+6avqAm2n+TXdQ@mail.gmail.com>
From: Doruk Yilmaz <doruk@mixrank.com>
Date: Mon, 18 Aug 2025 21:55:19 +0300
Message-ID: 
 <CAMPB6wdc10tc7gpVXG75r51M41zVSabip9Lz7hssWEtyhecWww@mail.gmail.com>
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup
To: pgsql-hackers@lists.postgresql.org
Cc: Amit Kapila <amit.kapila16@gmail.com>
Content-Type: multipart/mixed; boundary="0000000000009e7655063ca848d8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAMPB6wdc10tc7gpVXG75r51M41zVSabip9Lz7hssWEtyhecWww%40mail.gmail.com>
Precedence: bulk

--0000000000009e7655063ca848d8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> Your use looks good to me. So, maybe we can update the docs with the
> dangers if the users of API doesn't follow commit order then it may
> lead to data inconsistency should be sufficient. Additionally, we may
> want to give an example as to how to use this API for parallel apply.

That sounds reasonable. I=E2=80=99ve updated the patch and added more
information to the documentation covering the topics you mentioned.
I also added a Caution block so potential users won=E2=80=99t miss it. I ho=
pe
this patch meets your expectations.

--0000000000009e7655063ca848d8
Content-Type: text/x-patch; charset="US-ASCII";
	name="v5-0001-pg_replication_origin_session_setup-pid-parameter.patch"
Content-Disposition: attachment;
	filename="v5-0001-pg_replication_origin_session_setup-pid-parameter.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mehh56ix0>
X-Attachment-Id: f_mehh56ix0

RnJvbSA3NGE3NGZkMDJiY2U3ODYwOTNjMTlhMjNiZWY5NDQ0ZDBiOGVmNDFkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEb3J1ayA8ZG9ydWtAbWl4cmFuay5jb20+CkRhdGU6IEZyaSwg
MTUgQXVnIDIwMjUgMjE6Mzc6MTggKzAzMDAKU3ViamVjdDogW1BBVENIIHY1XSBwZ19yZXBsaWNh
dGlvbl9vcmlnaW5fc2Vzc2lvbl9zZXR1cDogcGlkIHBhcmFtZXRlcgoKU2luY2UgdGhlIGludHJv
ZHVjdGlvbiBvZiBwYXJhbGxlbCBhcHBseSB3b3JrZXJzIChjb21taXQgMjE2YTc4NDgyOWMpLAp0
aGUgcmVwbG9yaWdpbl9zZXNzaW9uX3NldHVwKCkgd2FzIGV4dGVuZGVkIHRvIGFjY2VwdCBhbiBl
eHRyYQpwYXJhbWV0ZXI6IHBpZC4gVGhpcyBwcm9jZXNzIElEIGlzIHVzZWQgdG8gaW5mb3JtIHRo
YXQgbXVsdGlwbGUKcHJvY2Vzc2VzIGFyZSBzaGFyaW5nIHRoZSBzYW1lIHJlcGxpY2F0aW9uIG9y
aWdpbiB0byBhcHBseSBjaGFuZ2VzIGluCnBhcmFsbGVsLiBUaGUgcmVwbG9yaWdpbl9zZXNzaW9u
X3NldHVwIGZ1bmN0aW9uIGhhcyBhIFNRTCB1c2VyCmludGVyZmFjZTogcGdfcmVwbGljYXRpb25f
b3JpZ2luX3Nlc3Npb25fc2V0dXAuIFRoaXMgY29tbWl0IGFkZHMgYW4Kb3B0aW9uYWwgcGFyYW1l
dGVyIHRoYXQgcGFzc2VzIHRoZSBwcm9jZXNzIElEIHRvIHRoZSBpbnRlcm5hbCBmdW5jdGlvbgpy
ZXBsb3JpZ2luX3Nlc3Npb25fc2V0dXAuIEl0IGFsbG93cyBtdWx0aXBsZSBwcm9jZXNzZXMgdG8g
dXNlIHRoZSBzYW1lCnJlcGxpY2F0aW9uIG9yaWdpbiBpZiB5b3UgYXJlIHVzaW5nIHRoZSByZXBs
aWNhdGlvbiBmdW5jdGlvbnMuCi0tLQogZG9jL3NyYy9zZ21sL2Z1bmMvZnVuYy1hZG1pbi5zZ21s
ICAgICAgICB8IDIyICsrKysrKysrKysrKysrKysrKysrLS0KIHNyYy9iYWNrZW5kL2NhdGFsb2cv
c3lzdGVtX2Z1bmN0aW9ucy5zcWwgfCAgOSArKysrKysrKy0KIHNyYy9iYWNrZW5kL3JlcGxpY2F0
aW9uL2xvZ2ljYWwvb3JpZ2luLmMgfCAgNCArKystCiBzcmMvaW5jbHVkZS9jYXRhbG9nL3BnX3By
b2MuZGF0ICAgICAgICAgIHwgIDIgKy0KIDQgZmlsZXMgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygr
KSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvZnVuYy9mdW5jLWFk
bWluLnNnbWwgYi9kb2Mvc3JjL3NnbWwvZnVuYy9mdW5jLWFkbWluLnNnbWwKaW5kZXggNDQ2ZmRm
ZS4uNGI4NjY3NiAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL2Z1bmMvZnVuYy1hZG1pbi5zZ21s
CisrKyBiL2RvYy9zcmMvc2dtbC9mdW5jL2Z1bmMtYWRtaW4uc2dtbApAQCAtMTMxNSw3ICsxMzE1
LDcgQEAgcG9zdGdyZXM9IyBTRUxFQ1QgJzAvMCc6OnBnX2xzbiArIHBkLnNlZ21lbnRfbnVtYmVy
ICogcHMuc2V0dGluZzo6aW50ICsgOm9mZnNldAogICAgICAgICA8aW5kZXh0ZXJtPgogICAgICAg
ICAgPHByaW1hcnk+cGdfcmVwbGljYXRpb25fb3JpZ2luX3Nlc3Npb25fc2V0dXA8L3ByaW1hcnk+
CiAgICAgICAgIDwvaW5kZXh0ZXJtPgotICAgICAgICA8ZnVuY3Rpb24+cGdfcmVwbGljYXRpb25f
b3JpZ2luX3Nlc3Npb25fc2V0dXA8L2Z1bmN0aW9uPiAoIDxwYXJhbWV0ZXI+bm9kZV9uYW1lPC9w
YXJhbWV0ZXI+IDx0eXBlPnRleHQ8L3R5cGU+ICkKKyAgICAgICAgPGZ1bmN0aW9uPnBnX3JlcGxp
Y2F0aW9uX29yaWdpbl9zZXNzaW9uX3NldHVwPC9mdW5jdGlvbj4gKCA8cGFyYW1ldGVyPm5vZGVf
bmFtZTwvcGFyYW1ldGVyPiA8dHlwZT50ZXh0PC90eXBlPiA8b3B0aW9uYWw+LCA8cGFyYW1ldGVy
PnBpZDwvcGFyYW1ldGVyPiA8dHlwZT5pbnRlZ2VyPC90eXBlPiA8bGl0ZXJhbD5ERUZBVUxUPC9s
aXRlcmFsPiA8bGl0ZXJhbD4wPC9saXRlcmFsPjwvb3B0aW9uYWw+ICkKICAgICAgICAgPHJldHVy
bnZhbHVlPnZvaWQ8L3JldHVybnZhbHVlPgogICAgICAgIDwvcGFyYT4KICAgICAgICA8cGFyYT4K
QEAgLTEzMjMsNyArMTMyMywyNiBAQCBwb3N0Z3Jlcz0jIFNFTEVDVCAnMC8wJzo6cGdfbHNuICsg
cGQuc2VnbWVudF9udW1iZXIgKiBwcy5zZXR0aW5nOjppbnQgKyA6b2Zmc2V0CiAgICAgICAgIG9y
aWdpbiwgYWxsb3dpbmcgcmVwbGF5IHByb2dyZXNzIHRvIGJlIHRyYWNrZWQuCiAgICAgICAgIENh
biBvbmx5IGJlIHVzZWQgaWYgbm8gb3JpZ2luIGlzIGN1cnJlbnRseSBzZWxlY3RlZC4KICAgICAg
ICAgVXNlIDxmdW5jdGlvbj5wZ19yZXBsaWNhdGlvbl9vcmlnaW5fc2Vzc2lvbl9yZXNldDwvZnVu
Y3Rpb24+IHRvIHVuZG8uCi0gICAgICAgPC9wYXJhPjwvZW50cnk+CisgICAgICAgIElmIG11bHRp
cGxlIHByb2Nlc3NlcyBjYW4gc2FmZWx5IHVzZSB0aGUgc2FtZSByZXBsaWNhdGlvbiBvcmlnaW4g
KGZvcgorICAgICAgICBleGFtcGxlLCBwYXJhbGxlbCBhcHBseSBwcm9jZXNzZXMpLCB0aGUgb3B0
aW9uYWwgPHBhcmFtZXRlcj5waWQ8L3BhcmFtZXRlcj4KKyAgICAgICAgcGFyYW1ldGVyIGNhbiBi
ZSB1c2VkIHRvIHNwZWNpZnkgdGhlIHByb2Nlc3MgSUQgb2YgdGhlIGZpcnN0IHByb2Nlc3MuCisg
ICAgICAgIFRoZSBmaXJzdCBwcm9jZXNzIG11c3QgcHJvdmlkZSA8cGFyYW1ldGVyPnBpZDwvcGFy
YW1ldGVyPiBlcXVhbHMgdG8KKyAgICAgICAgPGxpdGVyYWw+MDwvbGl0ZXJhbD4gYW5kIHRoZSBv
dGhlciBwcm9jZXNzZXMgdGhhdCBzaGFyZSB0aGUgc2FtZQorICAgICAgICByZXBsaWNhdGlvbiBv
cmlnaW4gc2hvdWxkIHByb3ZpZGUgdGhlIHByb2Nlc3MgSUQgb2YgdGhlIGZpcnN0IHByb2Nlc3Mu
CisgICAgICAgPC9wYXJhPgorICAgICAgIDxjYXV0aW9uPgorICAgICAgICA8cGFyYT4KKyAgICAg
ICAgIFdoZW4gbXVsdGlwbGUgcHJvY2Vzc2VzIHNoYXJlIHRoZSBzYW1lIHJlcGxpY2F0aW9uIG9y
aWdpbiwgaXQgaXMgY3JpdGljYWwKKyAgICAgICAgIHRvIG1haW50YWluIGNvbW1pdCBvcmRlciB0
byBwcmV2ZW50IGRhdGEgaW5jb25zaXN0ZW5jeS4gV2hpbGUgcHJvY2Vzc2VzCisgICAgICAgICBt
YXkgc2VuZCBvcGVyYXRpb25zIG91dCBvZiBvcmRlciwgdGhleSBtdXN0IGNvbW1pdCB0cmFuc2Fj
dGlvbnMgaW4gdGhlCisgICAgICAgICBjb3JyZWN0IHNlcXVlbmNlIHRvIGVuc3VyZSBwcm9wZXIg
cmVwbGljYXRpb24gY29uc2lzdGVuY3kuIFRoZSByZWNvbW1lbmRlZCB3b3JrZmxvdworICAgICAg
ICAgZm9yIGVhY2ggd29ya2VyIGlzOiBzZXQgdXAgdGhlIHJlcGxpY2F0aW9uIG9yaWdpbiBzZXNz
aW9uIHdpdGggdGhlIGZpcnN0IHByb2Nlc3MncyBQSUQsCisgICAgICAgICBhcHBseSBjaGFuZ2Vz
IHdpdGhpbiB0cmFuc2FjdGlvbnMsIGNhbGwgPGZ1bmN0aW9uPnBnX3JlcGxpY2F0aW9uX29yaWdp
bl94YWN0X3NldHVwPC9mdW5jdGlvbj4KKyAgICAgICAgIHdpdGggdGhlIExTTiBhbmQgY29tbWl0
IHRpbWVzdGFtcCBiZWZvcmUgY29tbWl0dGluZywgdGhlbiBjb21taXQgdGhlCisgICAgICAgICB0
cmFuc2FjdGlvbiBvbmx5IGlmIGV2ZXJ5dGhpbmcgc3VjY2VlZGVkLgorICAgICAgICA8L3BhcmE+
CisgICAgICAgPC9jYXV0aW9uPgorICAgICAgPC9lbnRyeT4KICAgICAgIDwvcm93PgoKICAgICAg
IDxyb3c+CmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jYXRhbG9nL3N5c3RlbV9mdW5jdGlvbnMu
c3FsIGIvc3JjL2JhY2tlbmQvY2F0YWxvZy9zeXN0ZW1fZnVuY3Rpb25zLnNxbAppbmRleCA1NjZm
MzA4Li5mNjAyODdkIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jYXRhbG9nL3N5c3RlbV9mdW5j
dGlvbnMuc3FsCisrKyBiL3NyYy9iYWNrZW5kL2NhdGFsb2cvc3lzdGVtX2Z1bmN0aW9ucy5zcWwK
QEAgLTY1MCw2ICs2NTAsMTMgQEAgTEFOR1VBR0UgSU5URVJOQUwKIENBTExFRCBPTiBOVUxMIElO
UFVUIFZPTEFUSUxFIFBBUkFMTEVMIFNBRkUKIEFTICdwZ19zdGF0X3Jlc2V0X3NscnUnOwoKK0NS
RUFURSBPUiBSRVBMQUNFIEZVTkNUSU9OCisgIHBnX3JlcGxpY2F0aW9uX29yaWdpbl9zZXNzaW9u
X3NldHVwKG5vZGVfbmFtZSB0ZXh0LCBwaWQgaW50ZWdlciBERUZBVUxUIDApCitSRVRVUk5TIHZv
aWQKK0xBTkdVQUdFIElOVEVSTkFMCitTVFJJQ1QgVk9MQVRJTEUKK0FTICdwZ19yZXBsaWNhdGlv
bl9vcmlnaW5fc2Vzc2lvbl9zZXR1cCc7CisKIC0tCiAtLSBUaGUgZGVmYXVsdCBwZXJtaXNzaW9u
cyBmb3IgZnVuY3Rpb25zIG1lYW4gdGhhdCBhbnlvbmUgY2FuIGV4ZWN1dGUgdGhlbS4KIC0tIEEg
bnVtYmVyIG9mIGZ1bmN0aW9ucyBzaG91bGRuJ3QgYmUgZXhlY3V0YWJsZSBieSBqdXN0IGFueW9u
ZSwgYnV0IHJhdGhlcgpAQCAtNzUxLDcgKzc1OCw3IEBAIFJFVk9LRSBFWEVDVVRFIE9OIEZVTkNU
SU9OIHBnX3JlcGxpY2F0aW9uX29yaWdpbl9zZXNzaW9uX3Byb2dyZXNzKGJvb2xlYW4pIEZST00K
CiBSRVZPS0UgRVhFQ1VURSBPTiBGVU5DVElPTiBwZ19yZXBsaWNhdGlvbl9vcmlnaW5fc2Vzc2lv
bl9yZXNldCgpIEZST00gcHVibGljOwoKLVJFVk9LRSBFWEVDVVRFIE9OIEZVTkNUSU9OIHBnX3Jl
cGxpY2F0aW9uX29yaWdpbl9zZXNzaW9uX3NldHVwKHRleHQpIEZST00gcHVibGljOworUkVWT0tF
IEVYRUNVVEUgT04gRlVOQ1RJT04gcGdfcmVwbGljYXRpb25fb3JpZ2luX3Nlc3Npb25fc2V0dXAo
dGV4dCwgaW50ZWdlcikgRlJPTSBwdWJsaWM7CgogUkVWT0tFIEVYRUNVVEUgT04gRlVOQ1RJT04g
cGdfcmVwbGljYXRpb25fb3JpZ2luX3hhY3RfcmVzZXQoKSBGUk9NIHB1YmxpYzsKCmRpZmYgLS1n
aXQgYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL29yaWdpbi5jIGIvc3JjL2JhY2tl
bmQvcmVwbGljYXRpb24vbG9naWNhbC9vcmlnaW4uYwppbmRleCA4N2YxMGU1Li45OGQ0N2UxIDEw
MDY0NAotLS0gYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL29yaWdpbi5jCisrKyBi
L3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvb3JpZ2luLmMKQEAgLTEzNzQsMTIgKzEz
NzQsMTQgQEAgcGdfcmVwbGljYXRpb25fb3JpZ2luX3Nlc3Npb25fc2V0dXAoUEdfRlVOQ1RJT05f
QVJHUykKIHsKIAljaGFyCSAgICpuYW1lOwogCVJlcE9yaWdpbklkIG9yaWdpbjsKKwlpbnQJCQlw
aWQ7CgogCXJlcGxvcmlnaW5fY2hlY2tfcHJlcmVxdWlzaXRlcyh0cnVlLCBmYWxzZSk7CgogCW5h
bWUgPSB0ZXh0X3RvX2NzdHJpbmcoKHRleHQgKikgRGF0dW1HZXRQb2ludGVyKFBHX0dFVEFSR19E
QVRVTSgwKSkpOwogCW9yaWdpbiA9IHJlcGxvcmlnaW5fYnlfbmFtZShuYW1lLCBmYWxzZSk7Ci0J
cmVwbG9yaWdpbl9zZXNzaW9uX3NldHVwKG9yaWdpbiwgMCk7CisJcGlkID0gUEdfR0VUQVJHX0lO
VDMyKDEpOworCXJlcGxvcmlnaW5fc2Vzc2lvbl9zZXR1cChvcmlnaW4sIHBpZCk7CgogCXJlcGxv
cmlnaW5fc2Vzc2lvbl9vcmlnaW4gPSBvcmlnaW47CgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUv
Y2F0YWxvZy9wZ19wcm9jLmRhdCBiL3NyYy9pbmNsdWRlL2NhdGFsb2cvcGdfcHJvYy5kYXQKaW5k
ZXggMTE4ZDZkYS4uZGQyZDkzOCAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvY2F0YWxvZy9wZ19w
cm9jLmRhdAorKysgYi9zcmMvaW5jbHVkZS9jYXRhbG9nL3BnX3Byb2MuZGF0CkBAIC0xMjIyMyw3
ICsxMjIyMyw3IEBACiB7IG9pZCA9PiAnNjAwNicsCiAgIGRlc2NyID0+ICdjb25maWd1cmUgc2Vz
c2lvbiB0byBtYWludGFpbiByZXBsaWNhdGlvbiBwcm9ncmVzcyB0cmFja2luZyBmb3IgdGhlIHBh
c3NlZCBpbiBvcmlnaW4nLAogICBwcm9uYW1lID0+ICdwZ19yZXBsaWNhdGlvbl9vcmlnaW5fc2Vz
c2lvbl9zZXR1cCcsIHByb3ZvbGF0aWxlID0+ICd2JywKLSAgcHJvcGFyYWxsZWwgPT4gJ3UnLCBw
cm9yZXR0eXBlID0+ICd2b2lkJywgcHJvYXJndHlwZXMgPT4gJ3RleHQnLAorICBwcm9wYXJhbGxl
bCA9PiAndScsIHByb3JldHR5cGUgPT4gJ3ZvaWQnLCBwcm9hcmd0eXBlcyA9PiAndGV4dCBpbnQ0
JywKICAgcHJvc3JjID0+ICdwZ19yZXBsaWNhdGlvbl9vcmlnaW5fc2Vzc2lvbl9zZXR1cCcgfSwK
CiB7IG9pZCA9PiAnNjAwNycsIGRlc2NyID0+ICd0ZWFyZG93biBjb25maWd1cmVkIHJlcGxpY2F0
aW9uIHByb2dyZXNzIHRyYWNraW5nJywK
--0000000000009e7655063ca848d8--