Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1toR0v-00Ahi9-OF for pgsql-hackers@arkaria.postgresql.org; Sat, 01 Mar 2025 17:52:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1toR0w-000nrk-F7 for pgsql-hackers@arkaria.postgresql.org; Sat, 01 Mar 2025 17:52:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1toR0w-000np4-0b for pgsql-hackers@lists.postgresql.org; Sat, 01 Mar 2025 17:52:36 +0000 Received: from mail-oo1-xc32.google.com ([2607:f8b0:4864:20::c32]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1toR0s-000Nsw-2l for pgsql-hackers@lists.postgresql.org; Sat, 01 Mar 2025 17:52:35 +0000 Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-5f89aa7a101so1284593eaf.2 for ; Sat, 01 Mar 2025 09:52:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mixrank.com; s=googledamrudlacagu; t=1740851554; x=1741456354; darn=lists.postgresql.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=dOI3bU9KGPZfMIwJSUbrTP7HkWRPWrWesUraJ0oMVeg=; b=TulXOOrp9Gc5jv2W3M+pc+ZW/Riic1DKNQNdj13bwgE/UXh6iK/bt06m8e4umy/drx bT0XAo1Ckep5BWwUT+y76rYWbcXIJZzRgiU8zmqSJH4JYLQTb7TBKnaBmpyYpRWxg4m+ Ek6PlvrallX8EMFgY1aH4aUfKUE20wCx4lW2lGHidEQyNEaAPFpnJZbNJQgpvDsKshGy MVtd+sOa3ARw0PZP9HTVOwOklLMIKiJ3ZFN29XTSjpK51Rk1cvuPFjwyeRBFD4Po0vcQ oRlIcl+FlDc9TcmPrJjfjvkr7MA6wfFrEBIx+Lzqd7/nDc/ugA+OUVYiIF9O9o28uwV7 eYLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740851554; x=1741456354; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dOI3bU9KGPZfMIwJSUbrTP7HkWRPWrWesUraJ0oMVeg=; b=cVnmbUiOvqfS2I9+Z6ZJWzM02aAZU9huz5jdqqvu5Ht5S4qRwfxjN/N0EtMC4L3Vwl nEd4GBOL3Z2oFyYE8A89kxXSqKxBKLjny6uIsaBg1FeYXpS67JCFxyeLBgV7f5QNoEy+ MIGRyTThPiqoSS/wCYszoHHV5SkEvvkwntplpwiy4ShJtYG9bC9CuzGEY3BoCOmgHU+9 EtymVTArfcRJs2oysbLpRLodtC2VdePuGssd1k564uTPq52BHgxVU3gj1fX3RGTzKi/m Z9dYYM4JqWSMlQ+pqXUIKZfGMz13yL6gqVSX5EuJ3L6i68OkJwdzAeSjy24+6bJoRy2Q Dijw== X-Gm-Message-State: AOJu0Yx5mdbUUnlcNvilYt9fkPxZwyJsRn3+280ZsksmwXFVuGkptTsv QG4+E9Bo09GxGd98R7sBmvaB0yFsh8/gGNHuQ9/JB0T4W6o1axobxmbwbNlGxf4f23Z4bQVtrAb 4i9Q9AbK6pLTyXMkkzZn3QEkSdemrUveiIa2NVOwXilTiG9X5IrY= X-Gm-Gg: ASbGnctXsaMoYVhiZCeuLq29rm4jANWRi1pCmywq825wQ7ZdCGqWcwrSAcU/Y2ZNEu0 zygdUWpoaH02Z04noOfn5cYfj8tnGt6BqT6DTPaw9UaTHPlpK4KPY2DZZC6/yYBfh6glinhbJPZ 4jG+hH2BllLkE2BKiHeRWCTbdHCSA= X-Google-Smtp-Source: AGHT+IHRAuwYzlzZp4tuCcVWU5pjopPlcMmA0Vyj3/VmmIsWnRCl9WPUm6WRbz4n5IkSLb1xIITyWjnYVKhlNMLGu7o= X-Received: by 2002:a05:6820:2908:b0:5fc:f3b8:78c2 with SMTP id 006d021491bc7-5feb355dff6mr4699162eaf.3.1740851554333; Sat, 01 Mar 2025 09:52:34 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Doruk Yilmaz Date: Sat, 1 Mar 2025 20:52:23 +0300 X-Gm-Features: AQ5f1JqtYPHXbba2p5a6Gx_w8GlkIAHdSDNuiyvym6F00Z7BZKB5MBcs4jAP7q4 Message-ID: Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup To: pgsql-hackers@lists.postgresql.org Content-Type: multipart/mixed; boundary="00000000000080ebc4062f4b969d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000080ebc4062f4b969d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I noticed that the patch needs rebasing, so here is the rebased version. Hopefully it makes to the commitfest. Doruk Y=C4=B1lmaz --00000000000080ebc4062f4b969d Content-Type: application/x-patch; name="v4-0001-pg_replication_origin_session_setup-pid-parameter.patch" Content-Disposition: attachment; filename="v4-0001-pg_replication_origin_session_setup-pid-parameter.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m7qhrq580 RnJvbSA3NGE3NGZkMDJiY2U3ODYwOTNjMTlhMjNiZWY5NDQ0ZDBiOGVmNDFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEb3J1ayA8ZG9ydWtAbWl4cmFuay5jb20+CkRhdGU6IFRodSwg MTUgQXVnIDIwMjQgMjM6MzQ6MjYgKzAzMDAKU3ViamVjdDogW1BBVENIIHY0XSBwZ19yZXBsaWNh dGlvbl9vcmlnaW5fc2Vzc2lvbl9zZXR1cDogcGlkIHBhcmFtZXRlcgoKU2luY2UgdGhlIGludHJv ZHVjdGlvbiBvZiBwYXJhbGxlbCBhcHBseSB3b3JrZXJzIChjb21taXQgMjE2YTc4NDgyOWMpLAp0 aGUgcmVwbG9yaWdpbl9zZXNzaW9uX3NldHVwKCkgd2FzIGV4dGVuZGVkIHRvIGFjY2VwdCBhbiBl eHRyYQpwYXJhbWV0ZXI6IHBpZC4gVGhpcyBwcm9jZXNzIElEIGlzIHVzZWQgdG8gaW5mb3JtIHRo YXQgbXVsdGlwbGUKcHJvY2Vzc2VzIGFyZSBzaGFyaW5nIHRoZSBzYW1lIHJlcGxpY2F0aW9uIG9y aWdpbiB0byBhcHBseSBjaGFuZ2VzIGluCnBhcmFsbGVsLiBUaGUgcmVwbG9yaWdpbl9zZXNzaW9u X3NldHVwIGZ1bmN0aW9uIGhhcyBhIFNRTCB1c2VyCmludGVyZmFjZTogcGdfcmVwbGljYXRpb25f b3JpZ2luX3Nlc3Npb25fc2V0dXAuIFRoaXMgY29tbWl0IGFkZHMgYW4Kb3B0aW9uYWwgcGFyYW1l dGVyIHRoYXQgcGFzc2VzIHRoZSBwcm9jZXNzIElEIHRvIHRoZSBpbnRlcm5hbCBmdW5jdGlvbgpy ZXBsb3JpZ2luX3Nlc3Npb25fc2V0dXAuIEl0IGFsbG93cyBtdWx0aXBsZSBwcm9jZXNzZXMgdG8g dXNlIHRoZSBzYW1lCnJlcGxpY2F0aW9uIG9yaWdpbiBpZiB5b3UgYXJlIHVzaW5nIHRoZSByZXBs aWNhdGlvbiBmdW5jdGlvbnMuCi0tLQogZG9jL3NyYy9zZ21sL2Z1bmMuc2dtbCAgICAgICAgICAg ICAgICAgICB8IDggKysrKysrKy0KIHNyYy9iYWNrZW5kL2NhdGFsb2cvc3lzdGVtX2Z1bmN0aW9u cy5zcWwgfCA5ICsrKysrKysrLQogc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC9vcmln aW4uYyB8IDQgKysrLQogc3JjL2luY2x1ZGUvY2F0YWxvZy9wZ19wcm9jLmRhdCAgICAgICAgICB8 IDIgKy0KIDQgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvZnVuYy5zZ21sIGIvZG9jL3NyYy9zZ21sL2Z1bmMu c2dtbAppbmRleCA0NzM3MGU1ODFhLi5lNTBlNjg5ZmI2IDEwMDY0NAotLS0gYS9kb2Mvc3JjL3Nn bWwvZnVuYy5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9mdW5jLnNnbWwKQEAgLTI5NDc1LDcgKzI5 NDc1LDcgQEAgcG9zdGdyZXM9IyBTRUxFQ1QgJzAvMCc6OnBnX2xzbiArIHBkLnNlZ21lbnRfbnVt YmVyICogcHMuc2V0dGluZzo6aW50ICsgOm9mZnNldAogICAgICAgICA8aW5kZXh0ZXJtPgogICAg ICAgICAgPHByaW1hcnk+cGdfcmVwbGljYXRpb25fb3JpZ2luX3Nlc3Npb25fc2V0dXA8L3ByaW1h cnk+CiAgICAgICAgIDwvaW5kZXh0ZXJtPgotICAgICAgICA8ZnVuY3Rpb24+cGdfcmVwbGljYXRp b25fb3JpZ2luX3Nlc3Npb25fc2V0dXA8L2Z1bmN0aW9uPiAoIDxwYXJhbWV0ZXI+bm9kZV9uYW1l PC9wYXJhbWV0ZXI+IDx0eXBlPnRleHQ8L3R5cGU+ICkKKyAgICAgICAgPGZ1bmN0aW9uPnBnX3Jl cGxpY2F0aW9uX29yaWdpbl9zZXNzaW9uX3NldHVwPC9mdW5jdGlvbj4gKCA8cGFyYW1ldGVyPm5v ZGVfbmFtZTwvcGFyYW1ldGVyPiA8dHlwZT50ZXh0PC90eXBlPiA8b3B0aW9uYWw+LCA8cGFyYW1l dGVyPnBpZDwvcGFyYW1ldGVyPiA8dHlwZT5pbnRlZ2VyPC90eXBlPiA8bGl0ZXJhbD5ERUZBVUxU PC9saXRlcmFsPiA8bGl0ZXJhbD4wPC9saXRlcmFsPjwvb3B0aW9uYWw+ICkKICAgICAgICAgPHJl dHVybnZhbHVlPnZvaWQ8L3JldHVybnZhbHVlPgogICAgICAgIDwvcGFyYT4KICAgICAgICA8cGFy YT4KQEAgLTI5NDgzLDYgKzI5NDgzLDEyIEBAIHBvc3RncmVzPSMgU0VMRUNUICcwLzAnOjpwZ19s c24gKyBwZC5zZWdtZW50X251bWJlciAqIHBzLnNldHRpbmc6OmludCArIDpvZmZzZXQKICAgICAg ICAgb3JpZ2luLCBhbGxvd2luZyByZXBsYXkgcHJvZ3Jlc3MgdG8gYmUgdHJhY2tlZC4KICAgICAg ICAgQ2FuIG9ubHkgYmUgdXNlZCBpZiBubyBvcmlnaW4gaXMgY3VycmVudGx5IHNlbGVjdGVkLgog ICAgICAgICBVc2UgPGZ1bmN0aW9uPnBnX3JlcGxpY2F0aW9uX29yaWdpbl9zZXNzaW9uX3Jlc2V0 PC9mdW5jdGlvbj4gdG8gdW5kby4KKyAgICAgICAgSWYgbXVsdGlwbGUgcHJvY2Vzc2VzIGNhbiBz YWZlbHkgdXNlIHRoZSBzYW1lIHJlcGxpY2F0aW9uIG9yaWdpbiAoZm9yCisgICAgICAgIGV4YW1w bGUsIHBhcmFsbGVsIGFwcGx5IHByb2Nlc3NlcyksIHRoZSBvcHRpb25hbCA8cGFyYW1ldGVyPnBp ZDwvcGFyYW1ldGVyPgorICAgICAgICBwYXJhbWV0ZXIgY2FuIGJlIHVzZWQgdG8gc3BlY2lmeSB0 aGUgcHJvY2VzcyBJRCBvZiB0aGUgZmlyc3QgcHJvY2Vzcy4KKyAgICAgICAgVGhlIGZpcnN0IHBy b2Nlc3MgbXVzdCBwcm92aWRlIDxwYXJhbWV0ZXI+cGlkPC9wYXJhbWV0ZXI+IGVxdWFscyB0bwor ICAgICAgICA8bGl0ZXJhbD4wPC9saXRlcmFsPiBhbmQgdGhlIG90aGVyIHByb2Nlc3NlcyB0aGF0 IHNoYXJlIHRoZSBzYW1lCisgICAgICAgIHJlcGxpY2F0aW9uIG9yaWdpbiBzaG91bGQgcHJvdmlk ZSB0aGUgcHJvY2VzcyBJRCBvZiB0aGUgZmlyc3QgcHJvY2Vzcy4KICAgICAgICA8L3BhcmE+PC9l bnRyeT4KICAgICAgIDwvcm93PgogCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jYXRhbG9nL3N5 c3RlbV9mdW5jdGlvbnMuc3FsIGIvc3JjL2JhY2tlbmQvY2F0YWxvZy9zeXN0ZW1fZnVuY3Rpb25z LnNxbAppbmRleCA4Njg4OGNkLi5lYmM0MDA1IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jYXRh bG9nL3N5c3RlbV9mdW5jdGlvbnMuc3FsCisrKyBiL3NyYy9iYWNrZW5kL2NhdGFsb2cvc3lzdGVt X2Z1bmN0aW9ucy5zcWwKQEAgLTYzNiw2ICs2MzYsMTMgQEAgTEFOR1VBR0UgSU5URVJOQUwKIENB TExFRCBPTiBOVUxMIElOUFVUIFZPTEFUSUxFIFBBUkFMTEVMIFNBRkUKIEFTICdwZ19zdGF0X3Jl c2V0X3NscnUnOwogCitDUkVBVEUgT1IgUkVQTEFDRSBGVU5DVElPTgorICBwZ19yZXBsaWNhdGlv bl9vcmlnaW5fc2Vzc2lvbl9zZXR1cChub2RlX25hbWUgdGV4dCwgcGlkIGludGVnZXIgREVGQVVM VCAwKQorUkVUVVJOUyB2b2lkCitMQU5HVUFHRSBJTlRFUk5BTAorU1RSSUNUIFZPTEFUSUxFCitB UyAncGdfcmVwbGljYXRpb25fb3JpZ2luX3Nlc3Npb25fc2V0dXAnOworCiAtLQogLS0gVGhlIGRl ZmF1bHQgcGVybWlzc2lvbnMgZm9yIGZ1bmN0aW9ucyBtZWFuIHRoYXQgYW55b25lIGNhbiBleGVj dXRlIHRoZW0uCiAtLSBBIG51bWJlciBvZiBmdW5jdGlvbnMgc2hvdWxkbid0IGJlIGV4ZWN1dGFi bGUgYnkganVzdCBhbnlvbmUsIGJ1dCByYXRoZXIKQEAgLTczNyw3ICs3NDQsNyBAQCBSRVZPS0Ug RVhFQ1VURSBPTiBGVU5DVElPTiBwZ19yZXBsaWNhdGlvbl9vcmlnaW5fc2Vzc2lvbl9wcm9ncmVz cyhib29sZWFuKSBGUk9NCiAKIFJFVk9LRSBFWEVDVVRFIE9OIEZVTkNUSU9OIHBnX3JlcGxpY2F0 aW9uX29yaWdpbl9zZXNzaW9uX3Jlc2V0KCkgRlJPTSBwdWJsaWM7CiAKLVJFVk9LRSBFWEVDVVRF IE9OIEZVTkNUSU9OIHBnX3JlcGxpY2F0aW9uX29yaWdpbl9zZXNzaW9uX3NldHVwKHRleHQpIEZS T00gcHVibGljOworUkVWT0tFIEVYRUNVVEUgT04gRlVOQ1RJT04gcGdfcmVwbGljYXRpb25fb3Jp Z2luX3Nlc3Npb25fc2V0dXAodGV4dCwgaW50ZWdlcikgRlJPTSBwdWJsaWM7CiAKIFJFVk9LRSBF WEVDVVRFIE9OIEZVTkNUSU9OIHBnX3JlcGxpY2F0aW9uX29yaWdpbl94YWN0X3Jlc2V0KCkgRlJP TSBwdWJsaWM7CiAKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwv b3JpZ2luLmMgYi9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL29yaWdpbi5jCmluZGV4 IDFiNTg2Y2IxY2YuLjljYmUxZWVjNDUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0 aW9uL2xvZ2ljYWwvb3JpZ2luLmMKKysrIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNh bC9vcmlnaW4uYwpAQCAtMTM1NSwxMiArMTM1NSwxNCBAQCBwZ19yZXBsaWNhdGlvbl9vcmlnaW5f c2Vzc2lvbl9zZXR1cChQR19GVU5DVElPTl9BUkdTKQogewogCWNoYXIJICAgKm5hbWU7CiAJUmVw T3JpZ2luSWQgb3JpZ2luOworCWludAkJCXBpZDsKIAogCXJlcGxvcmlnaW5fY2hlY2tfcHJlcmVx dWlzaXRlcyh0cnVlLCBmYWxzZSk7CiAKIAluYW1lID0gdGV4dF90b19jc3RyaW5nKCh0ZXh0ICop IERhdHVtR2V0UG9pbnRlcihQR19HRVRBUkdfREFUVU0oMCkpKTsKIAlvcmlnaW4gPSByZXBsb3Jp Z2luX2J5X25hbWUobmFtZSwgZmFsc2UpOwotCXJlcGxvcmlnaW5fc2Vzc2lvbl9zZXR1cChvcmln aW4sIDApOworCXBpZCA9IFBHX0dFVEFSR19JTlQzMigxKTsKKwlyZXBsb3JpZ2luX3Nlc3Npb25f c2V0dXAob3JpZ2luLCBwaWQpOwogCiAJcmVwbG9yaWdpbl9zZXNzaW9uX29yaWdpbiA9IG9yaWdp bjsKIApkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvY2F0YWxvZy9wZ19wcm9jLmRhdCBiL3NyYy9p bmNsdWRlL2NhdGFsb2cvcGdfcHJvYy5kYXQKaW5kZXggYjM3ZThhNmY4OC4uZWExMThhMDU2MyAx MDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvY2F0YWxvZy9wZ19wcm9jLmRhdAorKysgYi9zcmMvaW5j bHVkZS9jYXRhbG9nL3BnX3Byb2MuZGF0CkBAIC0xMjA2Myw3ICsxMjA2Myw3IEBACiB7IG9pZCA9 PiAnNjAwNicsCiAgIGRlc2NyID0+ICdjb25maWd1cmUgc2Vzc2lvbiB0byBtYWludGFpbiByZXBs aWNhdGlvbiBwcm9ncmVzcyB0cmFja2luZyBmb3IgdGhlIHBhc3NlZCBpbiBvcmlnaW4nLAogICBw cm9uYW1lID0+ICdwZ19yZXBsaWNhdGlvbl9vcmlnaW5fc2Vzc2lvbl9zZXR1cCcsIHByb3ZvbGF0 aWxlID0+ICd2JywKLSAgcHJvcGFyYWxsZWwgPT4gJ3UnLCBwcm9yZXR0eXBlID0+ICd2b2lkJywg cHJvYXJndHlwZXMgPT4gJ3RleHQnLAorICBwcm9wYXJhbGxlbCA9PiAndScsIHByb3JldHR5cGUg PT4gJ3ZvaWQnLCBwcm9hcmd0eXBlcyA9PiAndGV4dCBpbnQ0JywKICAgcHJvc3JjID0+ICdwZ19y ZXBsaWNhdGlvbl9vcmlnaW5fc2Vzc2lvbl9zZXR1cCcgfSwKIAogeyBvaWQgPT4gJzYwMDcnLCBk ZXNjciA9PiAndGVhcmRvd24gY29uZmlndXJlZCByZXBsaWNhdGlvbiBwcm9ncmVzcyB0cmFja2lu ZycsCi0tIAoyLjM5LjUKCg== --00000000000080ebc4062f4b969d--