MIME-Version: 1.0
References: 
 <CAMPB6wfe4zLjJL8jiZV5kjjpwBM2=rTRme0UCL7Ra4L8MTVdOg@mail.gmail.com>
 <b9666b93-093b-4c9f-a385-772d6ab5688c@app.fastmail.com>
 <CAMPB6we7+97L72Ru0=WxMDi24xMbZgr2B8Nwoo5i=r=UNuG_gQ@mail.gmail.com>
 <a4ee2198-5309-4b6f-90ef-c08b45a2f572@app.fastmail.com>
 <CAA4eK1JfPPFTmz7mUk26zPH8+qH9UBpkquxw75x7Ngx_D_6XXQ@mail.gmail.com>
In-Reply-To: 
 <CAA4eK1JfPPFTmz7mUk26zPH8+qH9UBpkquxw75x7Ngx_D_6XXQ@mail.gmail.com>
From: Doruk Yilmaz <doruk@mixrank.com>
Date: Tue, 29 Jul 2025 00:13:27 +0300
Message-ID: 
 <CAMPB6wfgvWjSvKNPoJkRqaL46geRDoL++Pt_3Czc2QNAdpVQHw@mail.gmail.com>
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup
To: Amit Kapila <amit.kapila16@gmail.com>, Euler Taveira <euler@eulerto.com>
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAMPB6wfgvWjSvKNPoJkRqaL46geRDoL%2B%2BPt_3Czc2QNAdpVQHw%40mail.gmail.com>
Precedence: bulk

On Mon, Mar 3, 2025 at 6:39=E2=80=AFAM Amit Kapila <amit.kapila16@gmail.com=
> wrote:
>
> To use replication_origin by multiple processes, one must maintain the
> commit order as we do internally by allowing the leader process to
> wait for the parallel worker to finish the commit. See comments atop
> replorigin_session_setup(). Now, we could expose the pid parameter as
> proposed by the patch after documenting the additional requirements,
> but I am afraid that users may directly start using the API without
> following the commit order principle, which can lead to incorrect
> replication. So, isn't it better to do something to avoid the misuse
> of this feature before exposing it?

Wouldn't mentioning/describing needing to follow the commit order
principle on the documentation be enough for this?
It is quite an advanced feature that I don't believe person intending
to use it won't start with reading documentation first.


Is there any updates on the commit? I see that intended commitfest window e=
nded.

Thanks,
Doruk Y=C4=B1lmaz