MIME-Version: 1.0
References: 
 <CAMSWrt-PoQt4sHryWrB1ViuGBJF_PpbjoSGrWR2Ry47bHNLDqg@mail.gmail.com>
 <fd9864f9-30bf-450b-a025-5e1bba58591a@eisentraut.org>
 <CAMSWrt-A0ha0qANftNYGpa8vEbtiD_7iV+0mdP0g9V8va=K0YA@mail.gmail.com>
 <CAN55FZ1OkRkQMT==EtTWesKBFdBG28WrzhYsex3UG67F7bAQ8A@mail.gmail.com>
 <CAN55FZ2fc++9-G=Mc4D2rNV2wQdbFn6EWszMno18vQTdqnKpJw@mail.gmail.com>
In-Reply-To: 
 <CAN55FZ2fc++9-G=Mc4D2rNV2wQdbFn6EWszMno18vQTdqnKpJw@mail.gmail.com>
From: =?UTF-8?Q?Mi=C5=82osz_Bieniek?= <bieniek.milosz0@gmail.com>
Date: Sat, 29 Nov 2025 12:07:05 +0100
Message-ID: 
 <CAMSWrt-2riJci+iGvt=Dggb4eh=2HgP3hy6+K=rZSeW=XFczAw@mail.gmail.com>
Subject: Re: [PATCH] Add `headerscheck` run_target to meson
To: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAMSWrt-2riJci%2BiGvt%3DDggb4eh%3D2HgP3hy6%2BK%3DrZSeW%3DXFczAw%40mail.gmail.com>
Precedence: bulk

pt., 28 lis 2025 o 16:17 Nazir Bilal Yavuz <byavuz81@gmail.com> napisa=C5=
=82(a):
>
> Hi,
>
> On Fri, 28 Nov 2025 at 18:05, Nazir Bilal Yavuz <byavuz81@gmail.com> wrot=
e:
> >
> > On Fri, 28 Nov 2025 at 17:03, Mi=C5=82osz Bieniek <bieniek.milosz0@gmai=
l.com> wrote:
> > >
> > > pt., 28 lis 2025 o 12:53 Peter Eisentraut <peter@eisentraut.org> napi=
sa=C5=82(a):
> > > >
> > > > On 27.11.25 10:28, Mi=C5=82osz Bieniek wrote:
> > > > > While reviewing a patch I noticed that we have a `make -s headers=
check`
> > > > > but there is no equivalent in meson.
> > > > > I prepared a small patch that adds `headerscheck` and `cplusplusc=
heck`
> > > > > targets.
> > > >
> > > > This would be good to have, but I don't think your patch works.  It
> > > > seems you need to add the srcdir and builddir command-line argument=
s to
> > > > the invocations.
> > > >
> > >
> > > I think you are right. I added srcdir and builddir arguments.
> >
> > The headerscheck script pulls some information from Makefile.global
> > after the configure [1] but meson does not generate a full version of
> > Makefile.global [2], so it does not have the required information to
> > check perl and python headers. If you run 'meson compile
> > headerscheck', you get errors like:
>
> Sorry, I clicked send early.
>
> Two solutions came to my mind but I am not sure which one is better:
>
> 1) We can add missing information to the generated Makefile.global in
> the meson.build.
>
> 2) We can send required information as arguments to the headerscheck scri=
pt.
>
> Any thoughts or suggestions?

Thank you for the detailed response.
I initially thought the errors with `#include <Python.h>` and
`#include <EXTREN.h>` were only an issue with my local setup.
If I understand correctly, your first proposal would address this
problem without requiring integration with the headerscheck script,
which in my opinion would be a cleaner solution.
However, I would definitely like to hear what others think as well.