MIME-Version: 1.0
References: 
 <CAMSWrt-PoQt4sHryWrB1ViuGBJF_PpbjoSGrWR2Ry47bHNLDqg@mail.gmail.com>
 <fd9864f9-30bf-450b-a025-5e1bba58591a@eisentraut.org>
In-Reply-To: <fd9864f9-30bf-450b-a025-5e1bba58591a@eisentraut.org>
From: =?UTF-8?Q?Mi=C5=82osz_Bieniek?= <bieniek.milosz0@gmail.com>
Date: Fri, 28 Nov 2025 13:58:01 +0100
Message-ID: 
 <CAMSWrt-A0ha0qANftNYGpa8vEbtiD_7iV+0mdP0g9V8va=K0YA@mail.gmail.com>
Subject: Re: [PATCH] Add `headerscheck` run_target to meson
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000009d87a40644a72e0d"
Archived-At: 
 <https://www.postgresql.org/message-id/CAMSWrt-A0ha0qANftNYGpa8vEbtiD_7iV%2B0mdP0g9V8va%3DK0YA%40mail.gmail.com>
Precedence: bulk

--0000000000009d87a40644a72e0d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

pt., 28 lis 2025 o 12:53 Peter Eisentraut <peter@eisentraut.org> napisa=C5=
=82(a):
>
> On 27.11.25 10:28, Mi=C5=82osz Bieniek wrote:
> > While reviewing a patch I noticed that we have a `make -s headerscheck`
> > but there is no equivalent in meson.
> > I prepared a small patch that adds `headerscheck` and `cpluspluscheck`
> > targets.
>
> This would be good to have, but I don't think your patch works.  It
> seems you need to add the srcdir and builddir command-line arguments to
> the invocations.
>

I think you are right. I added srcdir and builddir arguments.

--0000000000009d87a40644a72e0d
Content-Type: application/octet-stream;
	name="v2-0001-Add-headerscheck-run_target-to-meson.patch"
Content-Disposition: attachment;
	filename="v2-0001-Add-headerscheck-run_target-to-meson.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_miivaywh0>
X-Attachment-Id: f_miivaywh0

RnJvbSBlODFkYjVhMGVjZDY5OWNkNWM2NzZiNGMzZTZmNGNkZDE0ZjI2Yjk3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBtb296emkgPGJpZW5pZWsubWlsb3N6MEBnbWFpbC5jb20+CkRh
dGU6IEZyaSwgMjggTm92IDIwMjUgMTM6NTQ6MTMgKzAxMDAKU3ViamVjdDogW1BBVENIIHYyXSBB
ZGQgYGhlYWRlcnNjaGVja2AgcnVuX3RhcmdldCB0byBtZXNvbgoKLS0tCiBtZXNvbi5idWlsZCB8
IDE0ICsrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKQoKZGlm
ZiAtLWdpdCBhL21lc29uLmJ1aWxkIGIvbWVzb24uYnVpbGQKaW5kZXggNmU3ZGRkNzQ2ODMuLjFm
NzQ3NTBjOTE0IDEwMDY0NAotLS0gYS9tZXNvbi5idWlsZAorKysgYi9tZXNvbi5idWlsZApAQCAt
MzkwMCw2ICszOTAwLDIwIEBAIGVuZGlmCiAKIAogCisjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj
IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMKKyMgaGVhZGVyc2NoZWNrCisj
IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj
IyMjIyMKKworcnVuX3RhcmdldCgnaGVhZGVyc2NoZWNrJywKKyAgY29tbWFuZDogW21lc29uLnBy
b2plY3Rfc291cmNlX3Jvb3QoKSAvICdzcmMvdG9vbHMvcGdpbmNsdWRlL2hlYWRlcnNjaGVjaycs
IG1lc29uLnByb2plY3Rfc291cmNlX3Jvb3QoKSwgbWVzb24ucHJvamVjdF9idWlsZF9yb290KCld
CispCisKK3J1bl90YXJnZXQoJ2NwbHVzcGx1c2NoZWNrJywKKyAgY29tbWFuZDogW21lc29uLnBy
b2plY3Rfc291cmNlX3Jvb3QoKSAvICdzcmMvdG9vbHMvcGdpbmNsdWRlL2hlYWRlcnNjaGVjaycs
ICctLWNwbHVzcGx1cycsIG1lc29uLnByb2plY3Rfc291cmNlX3Jvb3QoKSwgbWVzb24ucHJvamVj
dF9idWlsZF9yb290KCldCispCisKKworCiAjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj
IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMKICMgVGhlIEVuZCwgVGhlIEVuZCwgTXkg
RnJpZW5kCiAjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj
IyMjIyMjIyMjIyMjIyMKLS0gCjIuNDkuMAoK
--0000000000009d87a40644a72e0d--