MIME-Version: 1.0
References: <CP4P284MB1968F2CDF45E4EB593BD5940EC0D2@CP4P284MB1968.BRAP284.PROD.OUTLOOK.COM>
 <202501091910.jcxcnmexdbyb@alvherre.pgsql> <CAA5RZ0sa0=JP3RCs4_hZ+YVFCeU8b_aHSqiSFdUrf_ushcBTtw@mail.gmail.com>
 <CAKFQuwaCQsTkCmbpZ_e7umZzqsPut1Q53hBNgWPP=Zw1EKmuEw@mail.gmail.com>
 <CAA5RZ0uF6yhEM=r5yz_5bHRssHxnQkfe38=+MrwTP+of1bV+YA@mail.gmail.com> <CAA5RZ0vS4TgdHKm-CaYEPp_cn9EmFonWbfY78dtsTVwmU4mTbQ@mail.gmail.com>
In-Reply-To: <CAA5RZ0vS4TgdHKm-CaYEPp_cn9EmFonWbfY78dtsTVwmU4mTbQ@mail.gmail.com>
From: Hunaid Sohail <hunaidpgml@gmail.com>
Date: Fri, 10 Jan 2025 12:47:35 +0500
Message-ID: <CAMWA6yYA96TsxZM3Z4Q4Z-COG215S7yCmdwwihu7CqvymUPXjA@mail.gmail.com>
Subject: Re: Psql meta-command conninfo+
To: Sami Imseih <samimseih@gmail.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	Maiquel Grassi <grassi@hotmail.com.br>, 
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Jim Jones <jim.jones@uni-muenster.de>, 
	Tom Lane <tgl@sss.pgh.pa.us>, Nathan Bossart <nathandbossart@gmail.com>, 
	"Imseih (AWS), Sami" <simseih@amazon.com>, Peter Eisentraut <peter@eisentraut.org>, 
	Pavel Luzanov <p.luzanov@postgrespro.ru>, Erik Wienhold <ewie@ewie.name>
Content-Type: multipart/alternative; boundary="000000000000944503062b554f79"
Archived-At: <https://www.postgresql.org/message-id/CAMWA6yYA96TsxZM3Z4Q4Z-COG215S7yCmdwwihu7CqvymUPXjA%40mail.gmail.com>
Precedence: bulk

--000000000000944503062b554f79
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Jan 10, 2025 at 1:50=E2=80=AFAM Sami Imseih <samimseih@gmail.com> w=
rote:

> > If we go with the 3 column format, then we will just
> > have a bunch of repeated values for Category, which
> > looks cluttered, IMO.
>
> "cluttered" is maybe the wrong description. I meant the output
> will look overwhelming due to the repeated values :)
>

+1.

To summarize:

- Alvaro is not happy with \conninfo+ printing multiple tables and suggests
we continue with v35.

- Sami is ok with both approaches but thinks that \conninfo+ should also
print all parameters from PQparameterStatus in a dynamic way. Also, he
suggests to include "role" if we are showing is_superuser.
For that, we need two more patches:
1. Mark role as GUC_REPORT with necessary doc changes.
2. Add a new libpq function (perhaps PQparameterNames) to return the names
of parameters, so we can also display parameters added in the future,
along with doc updates.

- David wants category information included.

IMO, we should continue with v35 and add all parameters from
PQparameterStatus,
as Sami suggested. The names themselves are informative enough.

Looking forward to your feedback.

Regards,
Hunaid Sohail

--000000000000944503062b554f79
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div>Hi,</div><br><div class=3D"gmail_quo=
te"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jan 10, 2025 at 1:50=E2=
=80=AFAM Sami Imseih &lt;<a href=3D"mailto:samimseih@gmail.com" target=3D"_=
blank">samimseih@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex">&gt; If we go with the 3 column format, then we w=
ill just<br>
&gt; have a bunch of repeated values for Category, which<br>
&gt; looks cluttered, IMO.<br>
<br>
&quot;cluttered&quot; is maybe the wrong description. I meant the output<br=
>
will look overwhelming due to the repeated values :)<br></blockquote><div><=
br></div><div>+1.</div><div><br></div><div>To summarize:</div><div><br></di=
v><div>- Alvaro is not happy with \conninfo+ printing multiple tables and s=
uggests</div><div>we continue=C2=A0with v35.</div><div><br></div><div>- Sam=
i is ok with both approaches but thinks that \conninfo+ should also</div><d=
iv>print all parameters from=C2=A0PQparameterStatus=C2=A0in a dynamic way. =
Also, he</div><div>suggests to include &quot;role&quot; if we are showing i=
s_superuser.</div><div>For that, we need two more patches:</div><div>1.=C2=
=A0Mark role as GUC_REPORT with necessary doc changes.</div><div>2. Add a n=
ew libpq function (perhaps PQparameterNames) to return the names</div><div>=
of parameters, so we can also display parameters added in the future,</div>=
<div>along with doc updates.</div><div></div><div><br></div><div>- David wa=
nts category information included.</div><div><br></div><div>IMO, we should =
continue with v35 and add all parameters from PQparameterStatus,</div><div>=
as Sami suggested. The names themselves are informative enough.</div><div><=
br></div><div>Looking forward to your feedback.</div><div><br></div><div>Re=
gards,</div><div>Hunaid Sohail</div></div></div>
</div>

--000000000000944503062b554f79--