MIME-Version: 1.0
References: <MEYP282MB1669EC0FED922F7A151673ACB65AA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <CAD21AoAa4vTH0Up1QUdbpnROnrC3+iGe_LS4sG6XKwZT-o-Kpw@mail.gmail.com>
 <CAMbWs48KxbY9EzZSQBy-30Ey06H-+Bi4HcQvxrOvEHANSGQmVg@mail.gmail.com> <ZIlwod7WjAs3SM/n@paquier.xyz>
In-Reply-To: <ZIlwod7WjAs3SM/n@paquier.xyz>
From: Richard Guo <guofenglinux@gmail.com>
Date: Wed, 14 Jun 2023 17:52:53 +0800
Message-ID: <CAMbWs4-tSAcv9XMMnOTb4ELB6azc0jzZpLBn7xDiSvficEKEbQ@mail.gmail.com>
Subject: Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
To: Michael Paquier <michael@paquier.xyz>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Japin Li <japinli@hotmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000003de205fe13eb5c"
Archived-At: <https://www.postgresql.org/message-id/CAMbWs4-tSAcv9XMMnOTb4ELB6azc0jzZpLBn7xDiSvficEKEbQ%40mail.gmail.com>
Precedence: bulk

--000000000000003de205fe13eb5c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 14, 2023 at 3:47=E2=80=AFPM Michael Paquier <michael@paquier.xy=
z> wrote:

> On Wed, Jun 14, 2023 at 03:38:10PM +0800, Richard Guo wrote:
> > +1.  BTW, it seems that GUC_UNIT_TIME is not used anywhere except in
> > GUC_UNIT.  I was wondering if we can retire it, but maybe we'd better
> > not.  It still indicates that we need to use time units table.
>
> Some out-of-core code declaring custom GUCs could rely on that, so
> it is better not to remove it.


I see.  Thanks for pointing that out.

Thanks
Richard

--000000000000003de205fe13eb5c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Wed, Jun 14, 2023 at 3:47=E2=80=AFPM M=
ichael Paquier &lt;<a href=3D"mailto:michael@paquier.xyz">michael@paquier.x=
yz</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex=
">On Wed, Jun 14, 2023 at 03:38:10PM +0800, Richard Guo wrote:<br>
&gt; +1.=C2=A0 BTW, it seems that GUC_UNIT_TIME is not used anywhere except=
 in<br>
&gt; GUC_UNIT.=C2=A0 I was wondering if we can retire it, but maybe we&#39;=
d better<br>
&gt; not.=C2=A0 It still indicates that we need to use time units table.<br=
>
<br>
Some out-of-core code declaring custom GUCs could rely on that, so<br>
it is better not to remove it.</blockquote><div><br></div><div>I see.=C2=A0=
 Thanks for pointing that out.<br><br>Thanks<br>Richard<br></div></div></di=
v>

--000000000000003de205fe13eb5c--