MIME-Version: 1.0
References: <MEYP282MB1669EC0FED922F7A151673ACB65AA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <CAD21AoAa4vTH0Up1QUdbpnROnrC3+iGe_LS4sG6XKwZT-o-Kpw@mail.gmail.com>
In-Reply-To: <CAD21AoAa4vTH0Up1QUdbpnROnrC3+iGe_LS4sG6XKwZT-o-Kpw@mail.gmail.com>
From: Richard Guo <guofenglinux@gmail.com>
Date: Wed, 14 Jun 2023 15:38:10 +0800
Message-ID: <CAMbWs48KxbY9EzZSQBy-30Ey06H-+Bi4HcQvxrOvEHANSGQmVg@mail.gmail.com>
Subject: Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Japin Li <japinli@hotmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000454cb405fe120979"
Archived-At: <https://www.postgresql.org/message-id/CAMbWs48KxbY9EzZSQBy-30Ey06H-%2BBi4HcQvxrOvEHANSGQmVg%40mail.gmail.com>
Precedence: bulk

--000000000000454cb405fe120979
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 14, 2023 at 1:07=E2=80=AFPM Masahiko Sawada <sawada.mshk@gmail.=
com>
wrote:

> On Wed, Jun 14, 2023 at 12:33=E2=80=AFPM Japin Li <japinli@hotmail.com> w=
rote:
> > Hi, hackers
> >
> > We use (GUC_UNIT_MEMORY | GUC_UNIT_TIME) instead of GUC_UNIT even thoug=
h
> we
> > already define it in guc.h.
> >
> > Maybe using GUC_UNIT is better?  Here is a patch to fix it.
>
> Yeah, it seems more consistent with other places in guc.c. I'll push
> it, barring any objections.


+1.  BTW, it seems that GUC_UNIT_TIME is not used anywhere except in
GUC_UNIT.  I was wondering if we can retire it, but maybe we'd better
not.  It still indicates that we need to use time units table.

Thanks
Richard

--000000000000454cb405fe120979
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Wed, Jun 14, 2023 at 1:07=E2=80=AFPM M=
asahiko Sawada &lt;<a href=3D"mailto:sawada.mshk@gmail.com">sawada.mshk@gma=
il.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex">On Wed, Jun 14, 2023 at 12:33=E2=80=AFPM Japin Li &lt;<a href=3D"mail=
to:japinli@hotmail.com" target=3D"_blank">japinli@hotmail.com</a>&gt; wrote=
:<br>
&gt; Hi, hackers<br>
&gt;<br>
&gt; We use (GUC_UNIT_MEMORY | GUC_UNIT_TIME) instead of GUC_UNIT even thou=
gh we<br>
&gt; already define it in guc.h.<br>
&gt;<br>
&gt; Maybe using GUC_UNIT is better?=C2=A0 Here is a patch to fix it.<br>
<br>
Yeah, it seems more consistent with other places in guc.c. I&#39;ll push<br=
>
it, barring any objections.</blockquote><div><br></div><div>+1.=C2=A0 BTW, =
it seems that GUC_UNIT_TIME is not used anywhere except in<br>GUC_UNIT.=C2=
=A0 I was wondering if we can retire it, but maybe we&#39;d better<br>not.=
=C2=A0 It still indicates that we need to use time units table.<br><br>Than=
ks<br>Richard<br></div></div></div>

--000000000000454cb405fe120979--