MIME-Version: 1.0
References: 
 <CAMbWs48JC4OVqE=3gMB6se2WmRNNfMyFyYxm-09vgpm+Vwe8Hg@mail.gmail.com>
 <7f6439c7-e5a7-4d0c-82c9-4087794cd9d0@gmail.com>
 <CAGjGUAKZ-gaT6z=4_BR8J5Xq7c85ckWuZ3_sHUo6oseto6npHA@mail.gmail.com>
In-Reply-To: 
 <CAGjGUAKZ-gaT6z=4_BR8J5Xq7c85ckWuZ3_sHUo6oseto6npHA@mail.gmail.com>
From: Richard Guo <guofenglinux@gmail.com>
Date: Sat, 18 Apr 2026 19:17:20 +0900
Message-ID: 
 <CAMbWs48RYf3dDS4P+HC43x-KLrN0uF-aU-Mk0Ld5JoWGErOqUg@mail.gmail.com>
Subject: Re: Clean up remove_rel_from_query() after self-join elimination
 commit
To: wenhui qiu <qiuwenhuifx@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAMbWs48RYf3dDS4P%2BHC43x-KLrN0uF-aU-Mk0Ld5JoWGErOqUg%40mail.gmail.com>
Precedence: bulk

On Tue, Apr 7, 2026 at 6:57=E2=80=AFPM wenhui qiu <qiuwenhuifx@gmail.com> w=
rote:
> Assert(!is_outer_join || joinrelids !=3D NULL);

Worth asserting.  If a caller sets sjinfo but passes NULL for
joinrelids, this would silently over-delete PHVs.

> Assert(!is_self_join || joinrelids =3D=3D NULL);

I prefer to not add this one.  It's not defending any invariant.

- Richard