Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v33KN-00AXgv-Nx for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Sep 2025 02:09:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v33KK-00GJbx-Qs for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Sep 2025 02:09:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v33KK-00GJbQ-GN for pgsql-hackers@lists.postgresql.org; Mon, 29 Sep 2025 02:09:21 +0000 Received: from mail-yx1-xb135.google.com ([2607:f8b0:4864:20::b135]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1v33KI-000QiR-1w for pgsql-hackers@lists.postgresql.org; Mon, 29 Sep 2025 02:09:20 +0000 Received: by mail-yx1-xb135.google.com with SMTP id 956f58d0204a3-635349b6fe6so2290750d50.2 for ; Sun, 28 Sep 2025 19:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759111758; x=1759716558; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5XrKMtltp/A7EIdslbBpzU0I9Ig4P2BP0Utp1eXymzU=; b=SdzYtkNGFuo/uQtPIm0TkmI7oYFDsE390/uArsEsbLP078mtO5FORv2+sH0fCvMlgA xjDw3km/KmNT83Rcy1UGLahIXO4uJD+Rc3jQyzVm8Fs57x6emrlkz8dm1YwckAb9IN1S RIvGEv2+zYJIGJWSJlK1NgL96AbMOrA6e8B7W2gPH5ZIpN0Z8rb36V3y3kEPDpwewze1 uyEUm077Ho1DRTx3G1UKP3L2ZQPEypmW1nBA6ufrSDAipULj6n2wXNMQSvxZMcI+PCaG texShIsGa9VbnSeeHzikLpg8zZnbU9bEM1rmplIAyB140STplNwkWsLEpMUcsRwSLWEV yLIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759111758; x=1759716558; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5XrKMtltp/A7EIdslbBpzU0I9Ig4P2BP0Utp1eXymzU=; b=I9xeLNR4mYHW3CZfKua7EZ2Hf2dHM96qdauL7haoIKdipkXTU6ta8a2QNdlZSX0aI6 eIbXBFrGVp59kfvb+1Rgw0qYwskc8I1yzAoXCNPaiLBlW5sr+3HmkgaLvskXV72gdtUS SoYvQ7LstIR2UJWYyz9m+f4LdOr0NnHq8+tVvEd2ESrDeEL8S4EdZsrSdHutVtTr6DY7 Lz40yXFW5n9CO0ZLxUpiWttoEfY5vX1By6laF5zzLhH/uzcXzmG1Yd/cFJkZrNKcu1ml wFUNda0eKHm//66CySxvQLVQaLl6FJdx9fHE8vUGUVKjxsIdAJuhzxgLY+mzPwACmchY IURQ== X-Forwarded-Encrypted: i=1; AJvYcCWBH31Q+WKc6MFhrdxrjJt3bH9qeFSbd9++TKVSzXB/HvVq4hD74Pw+f0uMlg2bYhBD/3es88yWJXqHmihZ@lists.postgresql.org X-Gm-Message-State: AOJu0Yy6g6dT4IMYL215iAWWWvP7Cxp5Oj0Wra/5BgdglYIOQEzarE8P pnrry6LIbE/ulcseKwgreexUKHyhRsE4LH1oIA3x/0lGDr341PohJLSnDs7JSbtVTTARSoWTucH xzAY1ngIApW9r1Nhtv/Q7c0njZHXY4UY= X-Gm-Gg: ASbGncvvznfiQ/euHGl9D78YhEA1MpA3tzUurFvtoQJfGVTMgXI7E3AyuqazBs5yK/l CYGZdwfXo/6EvoU+HPfImUvmADK4q7ShOpWKB+MXZiNcv/qAEp05EAedj4am0d7USJoMyGjws/M wVgKjjACICcSmmy57WGF9GwdDjDWvO07ZUUj1mpg8HlCryP80kTKGg4KdMgliq85Vrb4vAw+tt6 Ka2HtZNoVI2WavqH45m X-Google-Smtp-Source: AGHT+IFe5EB6gAo98iZFf7MeKximB5cVewnuhtEpI993Sb40CekVIw6PBRTxxZeZF7VBgaHh743GGRgvEssrIB0cMvI= X-Received: by 2002:a05:690e:244d:b0:635:4ecf:bdc6 with SMTP id 956f58d0204a3-6361a89069emr10601091d50.40.1759111758513; Sun, 28 Sep 2025 19:09:18 -0700 (PDT) MIME-Version: 1.0 References: <87il22cj51.fsf@163.com> In-Reply-To: From: Richard Guo Date: Mon, 29 Sep 2025 11:09:07 +0900 X-Gm-Features: AS18NWBwseIW0GdsknZf78hO7f5MPhs1TrPmg1TThlklQqvYLnNp8UukTZPUHRo Message-ID: Subject: Re: Eager aggregation, take 3 To: Robert Haas Cc: Tom Lane , Tender Wang , Paul George , Andy Fan , PostgreSQL-development , pgsql-hackers@lists.postgresql.org, Matheus Alcantara Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Sep 25, 2025 at 1:23=E2=80=AFPM Richard Guo wrote: > Attached is an updated version of the patch with these optimizations > applied. FWIW, I plan to do another self-review of this patch soon, with the goal of assessing whether it's ready to be pushed. If anyone has any concerns about any part of the patch or would like to review it, I would greatly appreciate hearing from you. - Richard