MIME-Version: 1.0
References: 
 <CAMbWs48ALW=mR0ydQ62dGS-Q+3D7WdDSh=EWDezcKp19xi=TUA@mail.gmail.com>
 <CAHg+QDcXStdF1m4ZbgT5qnRL_BruLSyBDGgRsibEFutKM2Jqxw@mail.gmail.com>
In-Reply-To: 
 <CAHg+QDcXStdF1m4ZbgT5qnRL_BruLSyBDGgRsibEFutKM2Jqxw@mail.gmail.com>
From: Richard Guo <guofenglinux@gmail.com>
Date: Wed, 15 Apr 2026 09:51:03 +0900
Message-ID: 
 <CAMbWs48XfOUYPtVmW4ZFD6BfUch9zbWQNVkzNPX+cUe4zGvF=w@mail.gmail.com>
Subject: Re: var_is_nonnullable() fails to handle invalid NOT NULL constraints
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAMbWs48XfOUYPtVmW4ZFD6BfUch9zbWQNVkzNPX%2BcUe4zGvF%3Dw%40mail.gmail.com>
Precedence: bulk

On Sun, Apr 12, 2026 at 6:33=E2=80=AFPM SATYANARAYANA NARLAPURAM
<satyanarlapuram@gmail.com> wrote:
> I tested this patch against the current HEAD (155c03ee) and it looks good=
.
> Build & tests: Applies cleanly, compiles without warnings, all 247 regres=
sion tests
> pass including the new subselect test case. Reproduced the bug before the=
 patch
> and verified it is fixed after the patch.

Thanks for testing.

> Looks like it needs to perform table_open/table_close multiple times depe=
nding upon
> the number of output columns? I don't see it as a major concern but let o=
thers comment.

I don't see it as a major concern either performance-wise.  table_open
here is just a hash lookup and refcount increment, and table_close is
just a refcount decrement.  And the call only happens in NOT IN cases,
and only after sublink_testexpr_is_not_nullable has already returned
true.

So I've committed this patch.

- Richard