Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rm12U-005UHQ-Mc for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Mar 2024 00:39:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rm12S-00E2D7-Dh for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Mar 2024 00:39:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rm12R-00E2Cz-Tl for pgsql-hackers@lists.postgresql.org; Mon, 18 Mar 2024 00:39:40 +0000 Received: from mail-yw1-x1135.google.com ([2607:f8b0:4864:20::1135]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rm12O-0053Mx-JR for pgsql-hackers@postgresql.org; Mon, 18 Mar 2024 00:39:39 +0000 Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-60a3c48e70fso41317837b3.1 for ; Sun, 17 Mar 2024 17:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710722377; x=1711327177; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PfBc+ZhptpOZNm60x5QXMEX4QnNT/lYVWeTmqU35k8A=; b=YjcZgusZbjdCZ4TRQHgLEJdKicsgqA+OQ+jzWSiK+xZPS+oBs2JV1nonf7oF6khRqD gH0LdKV4+eDfrg6xZsXpBfUWDS5J8cQrnQUI7kVTePMfm0IO2vSFloiLqwl6U179OQ9o nObWgH9YWLJUL7ryPmL2bLX1BqP+OhDSq5OeU466fZZtXJbZo2auDxynZA7bZS8B/kmV Nmbkq4gueB/WZsFT2ZSxJqcdU/J3vtMYQHIzW79HqdGXsIFNcG+EUntoejM5JNHQFG28 4LiljLo53lyxv9gxGnkWSwqyQBr0X/MXvSZrv0A8JGuV5tKow5ntB+31k0iNsmeKuoeL Dgyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710722377; x=1711327177; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PfBc+ZhptpOZNm60x5QXMEX4QnNT/lYVWeTmqU35k8A=; b=PojuMERRP5rawGsEnmQ3miXwknJ7arQeAo2XcahnqoplkkFTvrSUS30HBaroEo6Gk5 sVfMzfOLmxfFYmdNcB0ENrJBMbBPANjUheDHelRuAUmpK/BThFQmUcT2hb/29i6ojLf/ X1ClvZ7PZtKwRSMgv2uI2MjGPxyitUrAMchcG9uImwQQmPGnGU897itBdRNSgeZrUlyt 89eD1kbsLwSPfM6U7tIKoseBM7J1HSUhIglJxgyPr60M20B5NCx0FMidNs54+g25B91J BAwS77pVzDoh3HYnIKTeBl/ReJenekIPHbcJZkY9M4/6UZJUc9mrnOaRvkFXtEPanjgo obKA== X-Gm-Message-State: AOJu0YytfHemu7mlcmcfhFSKNKrm/8g0MXYwqUgDT0lmN/10G9br8RZu +Y0M2LacNy0Y6/Rlk2KAN/zrbp4wy4VfYxW2vXohy70xbZ0hzfIQaVwh22oty+uTlMmq0HCu+Jo tH1VJxx9pyRhRpyosH5VkLsxDs+OVGezABrs= X-Google-Smtp-Source: AGHT+IEvC1pU0bnMfq39p/2iPv2jAoXBHEsbi+Ywm5xl8Xy9xttcTrNjtM5+YYGP3ffEm2JYMAZFdtWNqlBKC+RfPcA= X-Received: by 2002:a0d:dd83:0:b0:60a:412:5d33 with SMTP id g125-20020a0ddd83000000b0060a04125d33mr10298533ywe.21.1710722376826; Sun, 17 Mar 2024 17:39:36 -0700 (PDT) MIME-Version: 1.0 References: <403eb886-204a-460b-a993-1c18ef53e5a9@eisentraut.org> In-Reply-To: <403eb886-204a-460b-a993-1c18ef53e5a9@eisentraut.org> From: Richard Guo Date: Mon, 18 Mar 2024 08:39:25 +0800 Message-ID: Subject: Re: Regarding the order of the header file includes To: Peter Eisentraut Cc: PostgreSQL-development Content-Type: multipart/alternative; boundary="0000000000009488ad0613e4970e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000009488ad0613e4970e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 13, 2024 at 10:07=E2=80=AFPM Peter Eisentraut wrote: > On 12.03.24 12:47, Richard Guo wrote: > > > > On Wed, Mar 6, 2024 at 5:32=E2=80=AFPM Richard Guo > > wrote: > > > > Please note that this patch only addresses the order of header file > > includes in backend modules (and might not be thorough). It is > possible > > that other modules may have a similar issue, but I have not evaluat= ed > > them yet. > > > > > > Attached is v2, which also includes the 0002 patch that addresses the > > order of header file includes in non-backend modules. > > committed (as one patch) Thanks for pushing! Thanks Richard --0000000000009488ad0613e4970e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Wed, Mar 13, 2024 at 10:07=E2=80=AFPM = Peter Eisentraut <peter@eisentra= ut.org> wrote:
On 12.03.24 12:47, Richard Guo wrote:
>
> On Wed, Mar 6, 2024 at 5:32=E2=80=AFPM Richard Guo <guofenglinux@gmail.com > <mailto:guofenglinux@gmail.com>> wrote:
>
>=C2=A0 =C2=A0 =C2=A0Please note that this patch only addresses the orde= r of header file
>=C2=A0 =C2=A0 =C2=A0includes in backend modules (and might not be thoro= ugh).=C2=A0 It is possible
>=C2=A0 =C2=A0 =C2=A0that other modules may have a similar issue, but I = have not evaluated
>=C2=A0 =C2=A0 =C2=A0them yet.
>
>
> Attached is v2, which also includes the 0002 patch that addresses the<= br> > order of header file includes in non-backend modules.

committed (as one patch)

Thanks for pushing= !

Thanks
Richard
--0000000000009488ad0613e4970e--