public inbox for [email protected]
help / color / mirror / Atom feedFrom: Richard Guo <[email protected]>
To: Tatsuro Yamada <[email protected]>
Cc: Tatsuro Yamada <[email protected]>
Cc: David Rowley <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Add enable_groupagg GUC parameter to control GroupAggregate usage
Date: Fri, 26 Jun 2026 15:26:20 +0900
Message-ID: <CAMbWs48cWQ=QkwH21zhfGH2MsAFYJpskjak99N4VX2yB69k-Eg@mail.gmail.com> (raw)
In-Reply-To: <TY4P301MB129931A356F6934C432BB0259EEC2@TY4P301MB1299.JPNP301.PROD.OUTLOOK.COM>
References: <CAOKkKFvYHSEsFazkrf9bRH14p-H27XMaqbZfRYjS6EHBruvZMQ@mail.gmail.com>
<CAExHW5tPhCw5HpHG6F7uAXx3re_gRXqm_ryJFjFQ2+WrVY+hPQ@mail.gmail.com>
<CAOKkKFsLbbpVMCG2_bV8u7M2sXLTs0y_yfMpywKekGi+qKtWKw@mail.gmail.com>
<CAOKkKFvgjAwtUFKh3baZ7BcQ5u+wS_DO+2n7dh0un+19v_VOzQ@mail.gmail.com>
<CAApHDvqq21KL9-eCfUyAUqxEyz40dut8+ehQHJD3Rh75iEMycw@mail.gmail.com>
<CAOKkKFvBi5tNaPkP-VEUcAr=nek0nm9=sUnP+dmqCm-vmnL9DA@mail.gmail.com>
<CAMbWs4-rqGC78jHduXO_feXCFzK=gzrcSHRTkATTKChG3YGq0A@mail.gmail.com>
<TY4P301MB129931A356F6934C432BB0259EEC2@TY4P301MB1299.JPNP301.PROD.OUTLOOK.COM>
On Thu, Jun 25, 2026 at 6:12 PM Tatsuro Yamada <[email protected]> wrote:
> It sounds like there are several plan nodes that could be covered by this GUC
> (such as SetOp, sort-based Unique for DISTINCT, semijoin uniqueification,
> and Group nodes). Do you think we should cover all of them before the patch
> would be considered complete enough for commit?
Yeah, I think so. The v4 patch actually already did that. You can
find these changes in create_setop_path(), create_unique_path(), and
cost_group().
> I'd be interested to hear your thoughts on how best to proceed, and whether
> dividing the work into smaller pieces would make sense.
It seems that the scope of the regression test changes isn't too
large, so I think keeping them in one patch is fine.
- Richard
view thread (18+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add enable_groupagg GUC parameter to control GroupAggregate usage
In-Reply-To: <CAMbWs48cWQ=QkwH21zhfGH2MsAFYJpskjak99N4VX2yB69k-Eg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox