MIME-Version: 1.0
References: <20230606201132.i3xjwpsg36p6tii7@alvherre.pgsql> <228188.1686082950@sss.pgh.pa.us>
In-Reply-To: <228188.1686082950@sss.pgh.pa.us>
From: Richard Guo <guofenglinux@gmail.com>
Date: Wed, 7 Jun 2023 10:25:40 +0800
Message-ID: <CAMbWs48mnX6bqHPQMsjahfjgNB+DzOiuMA_xMwXiODte2TNzdw@mail.gmail.com>
Subject: Re: Assert failure of the cross-check for nullingrels
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000cd402705fd80da9b"
Archived-At: <https://www.postgresql.org/message-id/CAMbWs48mnX6bqHPQMsjahfjgNB%2BDzOiuMA_xMwXiODte2TNzdw%40mail.gmail.com>
Precedence: bulk

--000000000000cd402705fd80da9b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 7, 2023 at 4:22=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > So, is this done?  I see that you made other commits fixing related cod=
e
> > several days after this email, but none seems to match the changes you
> > posted in this patch; and also it's not clear to me that there's any
> > test case where this patch is expected to change behavior.  (So there's
> > also a question of whether this is a bug fix or rather some icying on
> > cake.)


This issue is fixed at 991a3df22.


> Well, the bugs I was aware of ahead of PGCon are all fixed, but there
> are some new reports I still have to deal with.  I left the existing
> open issue open, but maybe it'd be better to close it and start a new
> one?


I went ahead and closed it, and then started two new open items for the
two new issues --- one is about assert failure and wrong query results
due to incorrectly removing PHVs, the other is about inconsistent
nulling bitmap in nestloop parameters.

Thanks
Richard

--000000000000cd402705fd80da9b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Wed, Jun 7, 2023 at 4:22=E2=80=AFAM To=
m Lane &lt;<a href=3D"mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us</a>&gt; w=
rote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0p=
x 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Alvaro Her=
rera &lt;<a href=3D"mailto:alvherre@alvh.no-ip.org" target=3D"_blank">alvhe=
rre@alvh.no-ip.org</a>&gt; writes:<br>
&gt; So, is this done?=C2=A0 I see that you made other commits fixing relat=
ed code<br>
&gt; several days after this email, but none seems to match the changes you=
<br>
&gt; posted in this patch; and also it&#39;s not clear to me that there&#39=
;s any<br>
&gt; test case where this patch is expected to change behavior.=C2=A0 (So t=
here&#39;s<br>
&gt; also a question of whether this is a bug fix or rather some icying on<=
br>
&gt; cake.)</blockquote><div><br></div><div>This issue is fixed at 991a3df2=
2.<br></div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1=
ex">
Well, the bugs I was aware of ahead of PGCon are all fixed, but there<br>
are some new reports I still have to deal with.=C2=A0 I left the existing<b=
r>
open issue open, but maybe it&#39;d be better to close it and start a new<b=
r>
one?</blockquote><div><br></div><div>I went ahead and closed it, and then s=
tarted two new open items for the<br>two new issues --- one is about assert=
 failure and wrong query results<br>due to incorrectly removing PHVs, the o=
ther is about inconsistent<br>nulling bitmap in nestloop parameters.<br><br=
>Thanks<br>Richard<br></div></div></div>

--000000000000cd402705fd80da9b--