MIME-Version: 1.0
References: 
 <CAMbWs48jzLrPt1J_00ZcPZXWUQKawQOFE8ROc-ADiYqsqrpBNw@mail.gmail.com>
 <CAJgoLk+d_P5sKrx-SZt01Acm_j0QnWn6aKJzFJ=waRu_3C8AoQ@mail.gmail.com>
 <CAHewXNkdhBrQR3mRmLw6FThgXd-tD2LmgfLreb+OeiyXmO2PPQ@mail.gmail.com>
 <CAMbWs49zScoONs0151cmgoo5cttkkK2cGLx228+Wok-h8XoyOg@mail.gmail.com>
 <CAHewXNna2r7cbwuotFJBdsHAedu1hZ1OD1Aj_hoRDOmFw-7z2A@mail.gmail.com>
In-Reply-To: 
 <CAHewXNna2r7cbwuotFJBdsHAedu1hZ1OD1Aj_hoRDOmFw-7z2A@mail.gmail.com>
From: Richard Guo <guofenglinux@gmail.com>
Date: Wed, 3 Jun 2026 10:25:01 +0900
Message-ID: 
 <CAMbWs49KSppYihVGz+c5uKJeRHtaG-a1wTG96d-ZMuEUmTO1Qw@mail.gmail.com>
Subject: Re: Eager aggregation, take 3
To: Tender Wang <tndrwang@gmail.com>
Cc: Radim Marek <radim@boringsql.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAMbWs49KSppYihVGz%2Bc5uKJeRHtaG-a1wTG96d-ZMuEUmTO1Qw%40mail.gmail.com>
Precedence: bulk

On Mon, Jun 1, 2026 at 4:57=E2=80=AFPM Tender Wang <tndrwang@gmail.com> wro=
te:
> Richard Guo <guofenglinux@gmail.com> =E4=BA=8E2026=E5=B9=B46=E6=9C=881=E6=
=97=A5=E5=91=A8=E4=B8=80 15:19=E5=86=99=E9=81=93=EF=BC=9A
> > So I'd rather fix it in eager_aggregation_possible_for_relation, right
> > next to the existing outer-join check, by rejecting a relation that
> > lies on the inner side of a semijoin/antijoin.  See attached.

> The attached LGTM.

Thanks for the review.  Pushed.

And thanks to Radim for the report and the well-contained repro.

- Richard