MIME-Version: 1.0
From: Richard Guo <guofenglinux@gmail.com>
Date: Thu, 23 Apr 2026 11:45:59 +0900
Message-ID: 
 <CAMbWs49fYQcqJfJ_Gtn8r1GFNoYtb1=2AUab4ieuqY4Zid9ocQ@mail.gmail.com>
Subject: The bogus calls in remove_self_join_rel()
To: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000a46a86065017a691"
Archived-At: 
 <https://www.postgresql.org/message-id/CAMbWs49fYQcqJfJ_Gtn8r1GFNoYtb1%3D2AUab4ieuqY4Zid9ocQ%40mail.gmail.com>
Precedence: bulk

--000000000000a46a86065017a691
Content-Type: text/plain; charset="UTF-8"

I noticed these two calls in remove_self_join_rel():

    adjust_relid_set(root->all_result_relids, toRemove->relid, toKeep->relid);
    adjust_relid_set(root->leaf_result_relids, toRemove->relid, toKeep->relid);

There's no comment explaining them, and as far as I can tell they do
nothing: adjust_relid_set returns a Relids and does not modify the
input in place.

Rather than make the calls do the cleanup they pretend to do, I think
a better way is to replace them with assertions: toRemove->relid is
not a member of either set.  This is true as these two sets contain
only parse->resultRelation (rejected as an SJE candidate to preserve
EvalPlanQual) and inheritance children of the target, which never
appear in the joinlist that SJE scans for candidates.

Thoughts?

- Richard

--000000000000a46a86065017a691
Content-Type: application/octet-stream;
	name="v1-0001-Fix-bogus-calls-in-remove_self_join_rel.patch"
Content-Disposition: attachment;
	filename="v1-0001-Fix-bogus-calls-in-remove_self_join_rel.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_moavqcld0>
X-Attachment-Id: f_moavqcld0

RnJvbSBkMDZmYzEwZmMzYTUzMTdhODhhMDU3NmQ5YTJjZmVkMWMxMGE0NzYyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEd1byA8Z3VvZmVuZ2xpbnV4QGdtYWlsLmNvbT4K
RGF0ZTogVGh1LCAyMyBBcHIgMjAyNiAxMToxOToyNSArMDkwMApTdWJqZWN0OiBbUEFUQ0ggdjFd
IEZpeCBib2d1cyBjYWxscyBpbiByZW1vdmVfc2VsZl9qb2luX3JlbCgpCgpyZW1vdmVfc2VsZl9q
b2luX3JlbCgpIGNhbGxlZCBhZGp1c3RfcmVsaWRfc2V0KCkgb24gYWxsX3Jlc3VsdF9yZWxpZHMK
YW5kIGxlYWZfcmVzdWx0X3JlbGlkcyBidXQgdGhyZXcgYXdheSB0aGUgcmV0dXJuIHZhbHVlLiAg
U2luY2UKYWRqdXN0X3JlbGlkX3NldCgpIHJldHVybnMgYSBmcmVzaGx5LWJ1aWx0IFJlbGlkcyBh
bmQgZG9lcyBub3QgbW9kaWZ5CnRoZSBpbnB1dCBpbiBwbGFjZSwgdGhlIGNhbGxzIGRpZCBub3Ro
aW5nLiAgVGhpcyBoYXMgYmVlbiB0aGUgY2FzZQpzaW5jZSB0aGUgU0pFIGZlYXR1cmUgd2VudCBp
biAoY29tbWl0IGZjMDY5YTNhNikuCgpUaGVyZSBoYXMgYmVlbiBubyBvYnNlcnZhYmxlIG1pc2Jl
aGF2aW9yLCBiZWNhdXNlIHRoZSByZWxpZCBiZWluZwpwYXNzZWQgaXMgZ3VhcmFudGVlZCBub3Qg
dG8gYmUgYSBtZW1iZXIgb2YgZWl0aGVyIHNldDogdGhvc2Ugc2V0cwpjb250YWluIG9ubHkgdGhl
IHF1ZXJ5J3MgdG9wLWxldmVsIHRhcmdldCByZWxhdGlvbiwgd2hpY2gKcmVtb3ZlX3NlbGZfam9p
bnNfcmVjdXJzZSgpIHJlamVjdHMgYXMgYW4gU0pFIGNhbmRpZGF0ZSB0byBwcmVzZXJ2ZQp0aGUg
RXZhbFBsYW5RdWFsIG1lY2hhbmlzbSwgcGx1cyBpbmhlcml0YW5jZSBjaGlsZHJlbiBvZiB0aGUg
dGFyZ2V0CnJlbGF0aW9uLCB3aGljaCBhcmUgUkVMT1BUX09USEVSX01FTUJFUl9SRUxzIGFuZCBz
byBuZXZlciBhcHBlYXIgaW4KdGhlIGpvaW5saXN0IHRoYXQgU0pFIHNjYW5zIGZvciBjYW5kaWRh
dGVzLiAgRXZlbiB3aXRoIHRoZSByZXN1bHQKYXNzaWduZWQsIHRoZSBjYWxscyB3b3VsZCBiZSBu
by1vcHMgaW4gcHJhY3RpY2UuCgpSYXRoZXIgdGhhbiBtYWtlIHRoZSBjYWxscyBkbyB0aGUgY2xl
YW51cCB0aGV5IHByZXRlbmQgdG8gZG8sIHJlcGxhY2UKdGhlbSB3aXRoIGFzc2VydGlvbnMgb2Yg
dGhlIGludmFyaWFudC4gIEFueSBmdXR1cmUgbG9vc2VuaW5nIG9mIHRoZQpTSkUgY2FuZGlkYXRl
IGZpbHRlciAtLSBmb3IgaW5zdGFuY2UgdG8gYWxsb3cgZWxpbWluYXRpbmcgYSByZXN1bHQKcmVs
YXRpb24gdW5kZXIgcHJvdmFibGUgY29uZGl0aW9ucyAtLSB3aWxsIHRyaXAgdGhlIGFzc2VydGlv
biBhbmQKZm9yY2Ugd2hvZXZlciBkb2VzIGl0IHRvIHJldmlzaXQgdGhpcyBjb2RlLgotLS0KIHNy
Yy9iYWNrZW5kL29wdGltaXplci9wbGFuL2FuYWx5emVqb2lucy5jIHwgMTIgKysrKysrKysrKy0t
CiAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYg
LS1naXQgYS9zcmMvYmFja2VuZC9vcHRpbWl6ZXIvcGxhbi9hbmFseXplam9pbnMuYyBiL3NyYy9i
YWNrZW5kL29wdGltaXplci9wbGFuL2FuYWx5emVqb2lucy5jCmluZGV4IDAzMDU2YmRmM2UwLi40
OTRiOWVlMDcxNiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvb3B0aW1pemVyL3BsYW4vYW5hbHl6
ZWpvaW5zLmMKKysrIGIvc3JjL2JhY2tlbmQvb3B0aW1pemVyL3BsYW4vYW5hbHl6ZWpvaW5zLmMK
QEAgLTE5OTQsOCArMTk5NCwxNiBAQCByZW1vdmVfc2VsZl9qb2luX3JlbChQbGFubmVySW5mbyAq
cm9vdCwgUGxhblJvd01hcmsgKmttYXJrLCBQbGFuUm93TWFyayAqcm1hcmssCiAJQ2hhbmdlVmFy
Tm9kZXNFeHRlbmRlZCgoTm9kZSAqKSByb290LT5wcm9jZXNzZWRfdGxpc3QsIHRvUmVtb3ZlLT5y
ZWxpZCwKIAkJCQkJCSAgIHRvS2VlcC0+cmVsaWQsIDAsIHJlcGxhY2VfcmVsaWRfY2FsbGJhY2sp
OwogCi0JYWRqdXN0X3JlbGlkX3NldChyb290LT5hbGxfcmVzdWx0X3JlbGlkcywgdG9SZW1vdmUt
PnJlbGlkLCB0b0tlZXAtPnJlbGlkKTsKLQlhZGp1c3RfcmVsaWRfc2V0KHJvb3QtPmxlYWZfcmVz
dWx0X3JlbGlkcywgdG9SZW1vdmUtPnJlbGlkLCB0b0tlZXAtPnJlbGlkKTsKKwkvKgorCSAqIE5v
IG5lZWQgdG8gdG91Y2ggYWxsX3Jlc3VsdF9yZWxpZHMgb3IgbGVhZl9yZXN1bHRfcmVsaWRzOiBl
dmVyeSByZWxpZAorCSAqIGluIHRob3NlIHNldHMgaXMgZWl0aGVyIHRoZSBxdWVyeSdzIHRvcC1s
ZXZlbCB0YXJnZXQgcmVsYXRpb24sIHdoaWNoCisJICogcmVtb3ZlX3NlbGZfam9pbnNfcmVjdXJz
ZSgpIHJlamVjdHMgYXMgYW4gU0pFIGNhbmRpZGF0ZSAodGhlIEVQUQorCSAqIG1lY2hhbmlzbSBy
ZXF1aXJlcyB0aGUgdGFyZ2V0IHJlbCB0byBzdXJ2aXZlKSwgb3IgYW4gaW5oZXJpdGFuY2UgY2hp
bGQKKwkgKiBvZiBpdCwgd2hpY2ggaXMgYSBSRUxPUFRfT1RIRVJfTUVNQkVSX1JFTCBhbmQgc28g
bmV2ZXIgYXBwZWFycyBpbiB0aGUKKwkgKiBqb2lubGlzdCB0aGF0IFNKRSBzY2Fucy4gIHRvUmVt
b3ZlLT5yZWxpZCB0aGVyZWZvcmUgY2Fubm90IGJlIGEgbWVtYmVyLgorCSAqLworCUFzc2VydCgh
Ym1zX2lzX21lbWJlcih0b1JlbW92ZS0+cmVsaWQsIHJvb3QtPmFsbF9yZXN1bHRfcmVsaWRzKSk7
CisJQXNzZXJ0KCFibXNfaXNfbWVtYmVyKHRvUmVtb3ZlLT5yZWxpZCwgcm9vdC0+bGVhZl9yZXN1
bHRfcmVsaWRzKSk7CiAKIAkvKgogCSAqIFRoZXJlIG1heSBiZSByZWZlcmVuY2VzIHRvIHRoZSBy
ZWwgaW4gcm9vdC0+ZmtleV9saXN0LCBidXQgaWYgc28sCi0tIAoyLjM5LjUgKEFwcGxlIEdpdC0x
NTQpCgo=
--000000000000a46a86065017a691--