MIME-Version: 1.0
References: <CAMbWs48f5rDOwxaT76Zd40m7n9iGZQcjEk7vG_5p3YWNh6oPfA@mail.gmail.com>
 <CAH2-WznLUb4nSVnrbE4Ur86U-NjCEJx8JkuPLbssT68YueVbjQ@mail.gmail.com>
In-Reply-To: <CAH2-WznLUb4nSVnrbE4Ur86U-NjCEJx8JkuPLbssT68YueVbjQ@mail.gmail.com>
From: Richard Guo <guofenglinux@gmail.com>
Date: Mon, 22 Apr 2024 14:22:25 +0800
Message-ID: <CAMbWs4_9c++hqJYd42X8tpWeOeUrZmWPc6O5E_AJhdHLf8UyoQ@mail.gmail.com>
Subject: Re: Assert failure in _bt_preprocess_array_keys
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000afbee90616a9768f"
Archived-At: <https://www.postgresql.org/message-id/CAMbWs4_9c%2B%2BhqJYd42X8tpWeOeUrZmWPc6O5E_AJhdHLf8UyoQ%40mail.gmail.com>
Precedence: bulk

--000000000000afbee90616a9768f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 22, 2024 at 10:52=E2=80=AFAM Peter Geoghegan <pg@bowt.ie> wrote=
:

> On Sun, Apr 21, 2024 at 10:36=E2=80=AFPM Richard Guo <guofenglinux@gmail.=
com>
> wrote:
> > I didn't spend much time digging into it, but I wonder if this Assert i=
s
> > sensible.  I noticed that before commit 5bf748b86b, the two datatypes
> > were not equal to each other either (anyrange vs. int4range).
>
> The assertion is wrong. It is testing behavior that's much older than
> commit 5bf748b86b, though. We can just get rid of it, since all of the
> information that we'll actually apply when preprocessing scan keys
> comes from the operator class.
>
> Pushed a fix removing the assertion just now. Thanks for the report.


That's so quick.  Thank you for the prompt fix.

Thanks
Richard

--000000000000afbee90616a9768f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Mon, Apr 22, 2024 at 10:52=E2=80=AFAM =
Peter Geoghegan &lt;<a href=3D"mailto:pg@bowt.ie">pg@bowt.ie</a>&gt; wrote:=
<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8=
ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sun, Apr 21,=
 2024 at 10:36=E2=80=AFPM Richard Guo &lt;<a href=3D"mailto:guofenglinux@gm=
ail.com" target=3D"_blank">guofenglinux@gmail.com</a>&gt; wrote:<br>
&gt; I didn&#39;t spend much time digging into it, but I wonder if this Ass=
ert is<br>
&gt; sensible.=C2=A0 I noticed that before commit 5bf748b86b, the two datat=
ypes<br>
&gt; were not equal to each other either (anyrange vs. int4range).<br>
<br>
The assertion is wrong. It is testing behavior that&#39;s much older than<b=
r>
commit 5bf748b86b, though. We can just get rid of it, since all of the<br>
information that we&#39;ll actually apply when preprocessing scan keys<br>
comes from the operator class.<br>
<br>
Pushed a fix removing the assertion just now. Thanks for the report.</block=
quote><div><br></div><div>That&#39;s so quick.=C2=A0 Thank you for the prom=
pt fix.<br><br>Thanks<br>Richard<br></div></div></div>

--000000000000afbee90616a9768f--