public inbox for [email protected]  

help / color / mirror / Atom feed
From: Richard Guo <[email protected]>
To: David Rowley <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: [email protected]
Subject: Re: pg16: XX000: could not find pathkey item to sort
Date: Mon, 9 Oct 2023 13:41:36 +0800
Message-ID: <CAMbWs4_B93iGoU_CfNHjbCAL_2T0LnEog2ftXyjBvMePLn3TAQ@mail.gmail.com> (raw)
In-Reply-To: <CAApHDvqira92LLPbW37azL+fDEm7yvWni89YekB9G751W7nEBw@mail.gmail.com>
References: <[email protected]>
	<CAMbWs48X+cK2pEaZDVVjd+nOJzb1dN1CO1OKz+6D0FX2OTCGbg@mail.gmail.com>
	<CAApHDvpJJigQRW29TppTOPYp+Aui0mtd3MpfRxyKv=N-tB62jQ@mail.gmail.com>
	<CAApHDvo7RzcQYw-gnkZr6QCijCqf8vJLkJ4XFk-KawvyAw109Q@mail.gmail.com>
	<CAApHDvqoMf_kxQKON+FLQh8DbMKe62R=OdrZoenb6xDYWmQVUQ@mail.gmail.com>
	<CAMbWs48VKgJyqfDNtKsYnNsPYWqA=stPKenehVz1NN0HTFV9mg@mail.gmail.com>
	<CAApHDvrAHkghCDNFG5+K2adWCDCC9cdZT2KZamVRkqYy31kL9w@mail.gmail.com>
	<CAApHDvqira92LLPbW37azL+fDEm7yvWni89YekB9G751W7nEBw@mail.gmail.com>

On Mon, Oct 9, 2023 at 12:13 PM David Rowley <[email protected]> wrote:

> I've now pushed the patch that trims off the Pathkeys for the ORDER BY
> / DISTINCT aggregates.


Thanks for pushing!


> Those results are a bit noisy.  Perhaps a few more runs might yield
> more consistency, but it seems that there's not too much overhead to
> it. If I take the minimum value out of the 3 runs from each, it comes
> to about 1.5% extra time spent in planning.  Perhaps that's OK.


I agree that the overhead is acceptable, especially it only happens in
USE_ASSERT_CHECKING builds.

Thanks
Richard


view thread (15+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pg16: XX000: could not find pathkey item to sort
  In-Reply-To: <CAMbWs4_B93iGoU_CfNHjbCAL_2T0LnEog2ftXyjBvMePLn3TAQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox