MIME-Version: 1.0
References: 
 <CAHg+QDfaAipL6YzOq2H=gAhKBbcUTYmfbAv+W1zueOfRKH43FQ@mail.gmail.com>
 <CAHewXN=9mf6NCeHE=7jUVhM_Ur=oW8R7hgfQwcvyWCSLC8VERw@mail.gmail.com>
 <CAMbWs48swa+F+HmsxnVqYrSvDFgp9v7ShSjac5FsG4oFFKvs2w@mail.gmail.com>
In-Reply-To: 
 <CAMbWs48swa+F+HmsxnVqYrSvDFgp9v7ShSjac5FsG4oFFKvs2w@mail.gmail.com>
From: Richard Guo <guofenglinux@gmail.com>
Date: Fri, 10 Apr 2026 15:58:31 +0900
Message-ID: 
 <CAMbWs4_Kd4Ep6ufUWLG78ZTAbFcZ-rriY8YQ1zd3iqFqtRnGPQ@mail.gmail.com>
Subject: Re: Bug: var_is_nonnullable() gives wrong results for old/new in
 RETURNING
To: Tender Wang <tndrwang@gmail.com>
Cc: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAMbWs4_Kd4Ep6ufUWLG78ZTAbFcZ-rriY8YQ1zd3iqFqtRnGPQ%40mail.gmail.com>
Precedence: bulk

On Fri, Apr 10, 2026 at 2:48=E2=80=AFPM Richard Guo <guofenglinux@gmail.com=
> wrote:
> The patch also LGTM.  I also checked if has_notnull_forced_var() has
> the same issue, but it doesn't: Vars with non-default returning type
> only appear in the RETURNING clause, so they never show up in WHERE/ON
> clauses.

I pushed the patch after a bit cosmetic tweaks.  I also decided to put
the test cases in returning.sql, which I think is a better place.

Thanks for the report and the patch.

- Richard