Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v6fn9-0080xm-Ay for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Oct 2025 01:50:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v6fn7-00ERpn-4E for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Oct 2025 01:50:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v6fn6-00ERpd-QI for pgsql-hackers@lists.postgresql.org; Thu, 09 Oct 2025 01:50:01 +0000 Received: from mail-yx1-xb132.google.com ([2607:f8b0:4864:20::b132]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1v6fn5-000lcT-0P for pgsql-hackers@postgresql.org; Thu, 09 Oct 2025 01:50:00 +0000 Received: by mail-yx1-xb132.google.com with SMTP id 956f58d0204a3-63cd60ca2b2so485516d50.2 for ; Wed, 08 Oct 2025 18:50:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759974599; x=1760579399; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+U4+pUg5iectgbh0VLoxKQ8ebnX9n8G6dCmR9iylKcY=; b=GbtV49lbq1xNXFKvt6QuLpEIh/mleRqx9SCi8BvqLKihemTJnxPdkmiJQeaxuxhS4s WYD+/w5E4sGUiwInNoUz25fLNbEODDndMrR3VyhV+NuVbTalvwliEsEpfU5N/Z3h2PNq yOuPtGYgGE/8au8XNlb6vOZsbi5G2S72lvMvBXUXJL15bjdLdDIewIzlkAqFIj326dwX UkKefs//g3fDmMimltqBp7/cSlS7XFVn+mKWVXSG63PNKegUAF4+B0eMxO0yttpB7NtE pVckE9wcBtKPJhS+IO9MlIIgs6hCH+RnNqwJ/HRDgEnxDMAIv7EsU0xlSfz1Bz2kaX6e lWrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759974599; x=1760579399; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+U4+pUg5iectgbh0VLoxKQ8ebnX9n8G6dCmR9iylKcY=; b=bhTtN3h8wU8wm8cOiRtjI8BkkOoq508IzjRBsNP6gIqmy2s+03Jq7+wik9s3azdd8G /GO5v3I5tpdWPIOzJM4YnKF+Vw1Mp+1/Qm/1+doztJDEeZcOd5j5c+nYyJBTWsNKLKfT FXn60fEGBe1watuaDuyIqQkgdoHpRzztKe5OOhPia4+cJCgGW/y/BeKZlQcmVunwv5K9 TafN8imbtFZJ/nqThp5XkGkKDoN026S0eGyD0J7URpKF653JKiLfPHSrR8NOK40Mpdp0 LL4ey/xb2aKByWVdomoAACBZEGBUUiQ0BZEuCg6p0r8mRbARoCAeLXBhi/FajIxbT476 qJbA== X-Forwarded-Encrypted: i=1; AJvYcCXkpRdND1LhkckAtWTtfbK4AsnXFF9FGnrOxlgXXwzKyz23Vk5oF4e33v8jDfC2OMmJlxO4j/r4WocPpB0N@postgresql.org X-Gm-Message-State: AOJu0YzD4JSpBEBx780KZBGcxpFxTgjg4STiA5VppD5tf8n/Kv+bQ8o6 NVV5na686Tc10EATVFDD/95YT0ePnaGCtcEPcgudJhzn/yGvi+YtYkBVBMpEutJlwoFWD2mkXWk kYx6QEPNTOdOqCFYHm9DGf0biDwMko/1V2wTE X-Gm-Gg: ASbGncu0q0zmrHvhqMb6p8Q/Rg2XhjDr+3zfB416qHZy7l+ucR7KFja053pNsEJMuxF pRvu8hZjkhsZCS+7rUHeCvH5Q2wFmUZUAYDBuCu8ym3vW/1oacZoidxgONsY9eJFpY1/cf68n8R 99WXBC0XWM55cVt4c5TB22QCYREwyx6CLPvdGDBWLbz8LFW7tGsGi5/n13VrtZx6JzqHz5a7V/x iatCwLowT00ds+jFjT93/gJJ5XTsSd6 X-Google-Smtp-Source: AGHT+IFD+cdwxNEHttN8OuE/CZXgBJibp4R9DATjH2MNlWWf1PAC2hIGW6/JoOQGGswX8R4tQwkS51ubWJdoytrhF1M= X-Received: by 2002:a53:c987:0:b0:5fe:ec6a:4d3 with SMTP id 956f58d0204a3-63ccb8e1079mr3862386d50.27.1759974599366; Wed, 08 Oct 2025 18:49:59 -0700 (PDT) MIME-Version: 1.0 References: <87il22cj51.fsf@163.com> In-Reply-To: From: Richard Guo Date: Thu, 9 Oct 2025 10:49:48 +0900 X-Gm-Features: AS18NWDT_XvF3-wtLh9digeUQwJsSey_VXgScNpmrQlvk-97oeTMftr0MON1xx0 Message-ID: Subject: Re: Eager aggregation, take 3 To: David Rowley Cc: Robert Haas , Tom Lane , Tender Wang , Paul George , Andy Fan , PostgreSQL-development , pgsql-hackers@lists.postgresql.org, Matheus Alcantara Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Oct 8, 2025 at 8:14=E2=80=AFPM David Rowley = wrote: > +-- Enable eager aggregation, which by default is disabled. > +SET enable_eager_aggregate TO on; > The above comment and command mismatch to my understanding from > looking at postgresql.conf.sample and guc_parameters.dat. Right. This GUC was disabled by default prior to v17, and this is a leftover from that. Will push a fix. Thanks for pointing it out! - Richard