MIME-Version: 1.0
References: <aczc9cxkr7SEHXV5@MAC-CVW1VHW5R6>
 <038d97bc-fbe4-4d99-b7a5-e468ef361123@iki.fi>
 <acz_NsifcL_IzMjn@MAC-CVW1VHW5R6> <ac9LsF7bL6UW75VM@MAC-CVW1VHW5R6>
 <adXAXO2qASwOHaQ0@paquier.xyz> <adX97VrD4pJKF8zt@MAC-CVW1VHW5R6>
In-Reply-To: <adX97VrD4pJKF8zt@MAC-CVW1VHW5R6>
From: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Date: Tue, 9 Jun 2026 18:08:36 +0530
Message-ID: 
 <CAMm1aWbCX_Tso1s1oBh6g3=sdvDdZX68gMAN8KRv9Z-1ykiu8w@mail.gmail.com>
Subject: Re: [PATCH] Fix minRecoveryPoint not advanced past checkpoint in
 CreateRestartPoint
To: Adam Lee <adam8157@gmail.com>, Michael Paquier <michael@paquier.xyz>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAMm1aWbCX_Tso1s1oBh6g3%3DsdvDdZX68gMAN8KRv9Z-1ykiu8w%40mail.gmail.com>
Precedence: bulk

Hi Adam, Michael,

I went through the discussion and wanted to share my thoughts.

I agree with Michael's point that semantically, minRecoveryPoint
represents the minimum LSN needed for on-disk page consistency, and
from that strict perspective, the current behavior is technically
correct. However, I also acknowledge Adam's concern about the
practical impact on tooling and automation that relies on
pg_controldata to accurately reflect recovery progress.

Given that the current behavior creates inconsistency across
recovery_target_action settings (pause and promote behave differently
than shutdown), external tools such as pg_rewind, backup solutions,
and monitoring systems depend on this value for operational decisions,
I support moving forward with this patch.

Regarding Michael's point about simplifying the minRecoveryPoint
update logic=E2=80=94I completely agree that reducing code paths and
complexity in this area would be valuable. If there are specific areas
that could benefit from simplification or refactoring, I would be
interested in helping with that work.

I haven't reviewed the patch in detail yet, but I will do so and share
any feedback or comments.

Best Regards,
Nitin Jadhav
Azure Database for PostgreSQL
Microsoft