public inbox for [email protected]
help / color / mirror / Atom feedFrom: Will Mortensen <[email protected]>
To: Robert Haas <[email protected]>
Cc: Jingxian Li <[email protected]>
Cc: andres <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] LockAcquireExtended improvement
Date: Tue, 26 Mar 2024 19:14:32 -0700
Message-ID: <CAMpnoC5f+eiS7tdy8PUpd_LacSTVT-pYpVooKfjHRQQmkHPZ2g@mail.gmail.com> (raw)
In-Reply-To: <CA+TgmoYc56fSB-CcO3dJiwEAT8DP6ybmQS0+xb3ucWVMXjTXHw@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<[email protected]>
<CA+TgmoYhmf14R9DPfdqx-ym+YV8dzMfwDR+e2qrj07BJ8=bz0Q@mail.gmail.com>
<[email protected]>
<CA+TgmoaYwx7iCfB88xRykMTTORA+1MYkczzmykt4=W=DYTyKMw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CA+TgmoaZNzNywg+jBXOYcsYbF5gdcY8+y5P5FofEEs6uyaN7_A@mail.gmail.com>
<CA+TgmoYc56fSB-CcO3dJiwEAT8DP6ybmQS0+xb3ucWVMXjTXHw@mail.gmail.com>
On Thu, Mar 14, 2024 at 1:15 PM Robert Haas <[email protected]> wrote:
> Seeing no further discussion, I have committed my version of this
> patch, with your test case.
This comment on ProcSleep() seems to have the values of dontWait
backward (double negatives are tricky):
* Result: PROC_WAIT_STATUS_OK if we acquired the lock,
PROC_WAIT_STATUS_ERROR
* if not (if dontWait = true, this is a deadlock; if dontWait = false, we
* would have had to wait).
Also there's a minor typo in a comment in LockAcquireExtended():
* Check the proclock entry status. If dontWait = true, this is an
* expected case; otherwise, it will open happen if something in the
* ipc communication doesn't work correctly.
"open" should be "only".
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] LockAcquireExtended improvement
In-Reply-To: <CAMpnoC5f+eiS7tdy8PUpd_LacSTVT-pYpVooKfjHRQQmkHPZ2g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox