MIME-Version: 1.0
References: <CAMsGm5dgogOZ5yNc9BsnFM0n4FuykZREmro9f9gvOBWD_D1-2w@mail.gmail.com>
 <20230122191549.5b35ulimlvz42y7l@alvherre.pgsql> <CAMsGm5f6Cyq3sbjyb2hi1MNjadR=Q-XYr-k_06OmE0vYCF-C8g@mail.gmail.com>
 <1413123.1674417854@sss.pgh.pa.us> <20230122215628.GR13860@telsasoft.com>
In-Reply-To: <20230122215628.GR13860@telsasoft.com>
From: Isaac Morland <isaac.morland@gmail.com>
Date: Sun, 22 Jan 2023 17:04:50 -0500
Message-ID: <CAMsGm5crtf+JOWh+n3v=9YAwonT2P_bgcdfn2SVxCK7pjxqG-g@mail.gmail.com>
Subject: Re: Remove source code display from \df+?
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	Pavel Stehule <pavel.stehule@gmail.com>, Magnus Hagander <magnus@hagander.net>, 
	pgsql-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="00000000000064529c05f2e17938"
Archived-At: <https://www.postgresql.org/message-id/CAMsGm5crtf%2BJOWh%2Bn3v%3D9YAwonT2P_bgcdfn2SVxCK7pjxqG-g%40mail.gmail.com>
Precedence: bulk

--00000000000064529c05f2e17938
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 22 Jan 2023 at 16:56, Justin Pryzby <pryzby@telsasoft.com> wrote:

> On Sun, Jan 22, 2023 at 03:04:14PM -0500, Tom Lane wrote:
>

> That's excessive.  The policy Alvaro mentions applies to globally-visible
> > object names (i.e., database, role, and tablespace names), and it's the=
re
> > to try to ensure that doing "make installcheck" against a live
> > installation won't clobber any non-test-created objects.  There's no
> point
> > in having such a policy within a test database --- its most likely effe=
ct
> > there would be to increase the risk that different test scripts step on
> > each others' toes.  If you feel a need for a name prefix for non-global
> > objects, use something based on the name of your test script.
>
> But we *are* talking about the role to be created to allow stable output
> of \df+ , so it's necessary to name it "regress_*".  To appease
> ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS, and to avoid clobbering
> global objects during "installcheck".
>

Tom is talking about my informal policy of prefixing all objects. Only
global objects need to be prefixed with regress_, but I prefixed everything
I created (functions as well as the role). I actually called the
role regress_psql_df and used that entire role name as the prefix of my
function names, so I think it unlikely that I=E2=80=99ll collide with anyth=
ing else.

--00000000000064529c05f2e17938
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Sun, 22 Jan 2023 at 16:56, Justin Pryz=
by &lt;<a href=3D"mailto:pryzby@telsasoft.com">pryzby@telsasoft.com</a>&gt;=
 wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-styl=
e:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On Sun, Jan 22=
, 2023 at 03:04:14PM -0500, Tom Lane wrote:<br>
</blockquote><div><br></div><blockquote class=3D"gmail_quote" style=3D"marg=
in:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-l=
eft-color:rgb(204,204,204);padding-left:1ex">
&gt; That&#39;s excessive.=C2=A0 The policy Alvaro mentions applies to glob=
ally-visible<br>
&gt; object names (i.e., database, role, and tablespace names), and it&#39;=
s there<br>
&gt; to try to ensure that doing &quot;make installcheck&quot; against a li=
ve<br>
&gt; installation won&#39;t clobber any non-test-created objects.=C2=A0 The=
re&#39;s no point<br>
&gt; in having such a policy within a test database --- its most likely eff=
ect<br>
&gt; there would be to increase the risk that different test scripts step o=
n<br>
&gt; each others&#39; toes.=C2=A0 If you feel a need for a name prefix for =
non-global<br>
&gt; objects, use something based on the name of your test script.<br>
<br>
But we *are* talking about the role to be created to allow stable output<br=
>
of \df+ , so it&#39;s necessary to name it &quot;regress_*&quot;.=C2=A0 To =
appease<br>
ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS, and to avoid clobbering<br>
global objects during &quot;installcheck&quot;.<br></blockquote><div><br></=
div><div>Tom is talking about my informal policy of prefixing all objects. =
Only global objects need to be prefixed with regress_, but I prefixed every=
thing I created (functions as well as the role). I actually called the role=
=C2=A0regress_psql_df and used that entire role name as the prefix of my fu=
nction names, so I think it unlikely that I=E2=80=99ll collide with anythin=
g else.</div><div>=C2=A0</div></div></div>

--00000000000064529c05f2e17938--