MIME-Version: 1.0
References: 
 <CAMtXxw9tPwV=NBv5S9GZXMSKPeKv5f9hRhSjZ8__oLsoS5jcuA@mail.gmail.com>
 <rbgsftgjpffyscyfa6plqmm7fdl3fccuikuvao3tssihux3t73@dnb6u5njlrak>
In-Reply-To: <rbgsftgjpffyscyfa6plqmm7fdl3fccuikuvao3tssihux3t73@dnb6u5njlrak>
From: Soumya S Murali <soumyamurali.work@gmail.com>
Date: Thu, 18 Dec 2025 10:16:06 +0530
Message-ID: 
 <CAMtXxw8xNrQnFqUA79vSDf2fFiUvfi_hf9TWB6K6TRXKMc96kw@mail.gmail.com>
Subject: Re: [PATCH] Expose checkpoint reason to completion log messages.
To: Andres Freund <andres@anarazel.de>
Cc: Michael Banck <mbanck@gmx.net>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	=?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	melanieplageman@gmail.com, juanjo.santamaria@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAMtXxw8xNrQnFqUA79vSDf2fFiUvfi_hf9TWB6K6TRXKMc96kw%40mail.gmail.com>
Precedence: bulk

Hi Andres,


On Thu, Dec 18, 2025 at 5:49=E2=80=AFAM Andres Freund <andres@anarazel.de> =
wrote:
>
> Hi,
>
> On 2025-12-01 16:48:56 +0530, Soumya S Murali wrote:
> > This patch is an update after reworking the =E2=80=9Ccheckpoint reason=
=E2=80=9D changes as
> > a standalone patch, separate from the pg_stat_checkpointer additions as
> > suggested [1].
>
> This seems to not pass the tests on any platform:
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F6306
>
> Looks like you need to update 019_replslot_limit.pl for the changed log
> format.
>
> I suggest running the tests before submitting.
>
> Greetings,
>
> Andres


Thank you for checking and for pointing this out. I will fix the
expected log pattern, rerun the test, and will resend an updated patch
once all tests get passed.

Regards,
Soumya