public inbox for [email protected]
help / color / mirror / Atom feedFrom: Soumya S Murali <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Michael Banck <[email protected]>
Cc: VASUKI M <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: [PATCH] Expose checkpoint reason to completion log messages.
Date: Tue, 17 Feb 2026 16:17:48 +0530
Message-ID: <CAMtXxw9GesU4M5UEfskd-d4MVvECQr3dmYi3e4CnLyvAemFK1w@mail.gmail.com> (raw)
In-Reply-To: <CAHGQGwGLkdZ4FT73eczJXoVK_+DBxW7PAKiE8m4s48UcZJGKZQ@mail.gmail.com>
References: <CAMtXxw-Pvpznd_QczTYTsVhn=19qiX5N7X6DG6p9iyZdNDs7yw@mail.gmail.com>
<CAHGQGwFzR=1EwefWGVNF5GaOMsNkWZZ9oJMXiwO3x8AhjUTqsQ@mail.gmail.com>
<[email protected]>
<CAE2r8H7yMJ2XncBM59-n0jMOGDSw3R2gLn6Cd_-eq_y-3NPw=w@mail.gmail.com>
<CAHGQGwGXoai8-83p5x2FhHnu6LD=epsapa_RTTzM3RHShju3Jw@mail.gmail.com>
<CAMtXxw-AuUyyGj8V7k0x9GgftoDd-DovMDedH0vTFv32BEpeXA@mail.gmail.com>
<[email protected]>
<CAMtXxw9qg+-G24Xe-P=a2gWmCGnE4-CcOBOZ9tdO9eAqjMgEvQ@mail.gmail.com>
<[email protected]>
<CAMtXxw_o3TTaUiTqqwMCEMtLNESX9-Dvd60=CkgQO37KW1AkXQ@mail.gmail.com>
<[email protected]>
<CAMtXxw9Cefp78beLt6mEVeD7OnxTryc0H124HX_Ru7xKs+9MJQ@mail.gmail.com>
<CAHGQGwHmKOV1qW9sPY49nL6DK7tmgCvbtP2bJQvyrd=k=g_kXQ@mail.gmail.com>
<CAMtXxw9T7W3pRQ9zm-WrEvLgyYFRi8DtBqP4K_j9jk4YK1FFSg@mail.gmail.com>
<CAHGQGwGLkdZ4FT73eczJXoVK_+DBxW7PAKiE8m4s48UcZJGKZQ@mail.gmail.com>
Hi all,
On Tue, Feb 17, 2026 at 11:25 AM Fujii Masao <[email protected]> wrote:
>
> On Wed, Jan 14, 2026 at 7:11 PM Soumya S Murali
> <[email protected]> wrote:
> > Thank you for the detailed review and suggestions.
> > Based on the feedback, I have updated the patch to make the checkpoint
> > and restart point log formatting fully consistent between start and
> > completion log messages. The completion messages now use the same
> > format as the start messages without parentheses. I have also replaced
> > the term "reason" with the term "flags". The patch has been rebuilt
> > and validated with make check and the full recovery TAP test suite,
> > and I have manually verified the resulting log output to confirm the
> > expected formatting. I am attaching the updated patch for further
> > review. Please let me know if any additional adjustments are needed.
>
> Thanks for updating the patch!
>
> + if (flags & CHECKPOINT_IS_SHUTDOWN)
> + APPEND_REASON("shutdown");
> + if (flags & CHECKPOINT_END_OF_RECOVERY)
> + APPEND_REASON("end-of-recovery");
>
> I still think it would be simpler to construct the checkpoint flags string
> with snprintf() rather than introducing a new macro. Please see
> the attached patch.
>
> - if ($node_primary->log_contains("checkpoint complete: ", $logstart))
> + if ($node_primary->log_contains("checkpoint complete:", $logstart))
>
> I don't think this change is necessary.
>
> I've also updated the commit message in the attached patch.
Thank you very much for refining the implementation and simplifying
the flag construction logic using snprintf(). I have reviewed the
committed changes and verified that the formatting and behavior are
consistent and correct. The updated approach is clear and aligns well
with PostgreSQL coding style. I also appreciate the improvements made
to the commit message as it clearly explains the motivation and makes
the change easy to understand in context.
I sincerely appreciate your guidance throughout this review process.
Regards,
Soumya
view thread (13+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Expose checkpoint reason to completion log messages.
In-Reply-To: <CAMtXxw9GesU4M5UEfskd-d4MVvECQr3dmYi3e4CnLyvAemFK1w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox