public inbox for [email protected]  

help / color / mirror / Atom feed
From: Kuwamura Masaki <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Jelte Fennema <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: Issue in postgres_fdw causing unnecessary wait for cancel request reply
Date: Thu, 27 Jul 2023 20:01:56 +0900
Message-ID: <CAMyC8qrjv2=oSV6bNC6TWbb01SyW1Se7Lyy7gZFfpVH5bCB6-w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAPmGK15YigmZKzVBGYPdmo-QMHBdhNupK8L6kUBdUtMERkbXsQ@mail.gmail.com>
	<[email protected]>
	<CAPmGK143nF7BQW0cFv3tpae7FrdYQfKH7eUE+CgwG5c6QGkZ=g@mail.gmail.com>
	<[email protected]>
	<CAGECzQThFfOSf_J87pXO1oLY5=45A0deC=x0LsrpWMhO7GSs4w@mail.gmail.com>
	<[email protected]>

Hi, Fujii-san

> Regarding the WARNING message, another idea is to pass the return value
> of PQgetCancel() directly to PQcancel() as follows. If NULL is passed,
> PQcancel() will detect it and set the proper error message to errbuf.
> Then the warning message "WARNING:  could not send cancel request:
> PQcancel() -- no cancel object supplied" is output.

I agree to go with this.

With this approach, the information behind the error (e.g., "out of
memory") will disappear, I guess.
I think we have to deal with it eventually. (I'm sorry, I don't have a good
idea right now)
However, the original issue is unnecessary waiting, and this should be
fixed soon.
So it is better to fix the problem this way and discuss retaining
information in another patch IMO.

I'm afraid I'm new to reviewing.
If I'm misunderstanding something, please let me know.

Masaki Kuwamura


view thread (7+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Issue in postgres_fdw causing unnecessary wait for cancel request reply
  In-Reply-To: <CAMyC8qrjv2=oSV6bNC6TWbb01SyW1Se7Lyy7gZFfpVH5bCB6-w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox