MIME-Version: 1.0
References: <d2d872c3-84f9-48f6-9963-f4537f02bc91@eisentraut.org>
 <adb15d59-2e6b-4d2e-ac5b-7aaea41f738f@gmail.com>
 <CAK98qZ2QGcyJrJAFv9wjY6S8yP9dUVnmG9Gb4OXuzuMMuM1Z5Q@mail.gmail.com>
 <b24dc997-d78f-47bd-b323-14e68232d127@dunslane.net>
 <21fa36b4-6d56-4556-b524-9e3955b922c8@eisentraut.org>
 <CAK98qZ3Ly6PhRwCVmMKJBba5oHVF9k370MMT2b_gep-SuQfRtg@mail.gmail.com>
 <CAK98qZ1za8XgOLY+2hQMPGoxVYFyh=dDkM2dZPVeJK4J6poyvA@mail.gmail.com>
 <CAK98qZ0EfrPcv3ZwGdeDiLPEpXYfHOEc8S2D=OCPJGcyWy5d-g@mail.gmail.com>
 <CAK98qZ1rZaVNy6ViangQom4iinZVH7=ebqhTsPxMQbN5ZtE9XQ@mail.gmail.com>
 <CAFY6G8cY5SUG5L-0ryVpom6HynE49p8-XQ59qkaEgnZZJ-c4Rg@mail.gmail.com>
 <CAFY6G8eUGcU3A4AHprgYbSOAOj7+WGhGxS_YP0wd2+aCpZTiNg@mail.gmail.com>
 <CAK98qZ14uKKRVFg4ibzMfReYaZD6Byxq8nYnvNNtXNjCfcd8kQ@mail.gmail.com>
 <CAHgHdKtL9nNaKXGCLt9gWugVzYWKhoBDQ7NESUwdCBty8kFK-A@mail.gmail.com>
 <CAK98qZ1nz6ZZhQqTOCNwRguZE5GsBLW5BQT_k=s7AA6gc2CN_g@mail.gmail.com>
 <c7dc6735-57cb-4287-871f-4c92a7205357@postgresfriends.org>
In-Reply-To: <c7dc6735-57cb-4287-871f-4c92a7205357@postgresfriends.org>
From: Nikita Malakhov <hukutoc@gmail.com>
Date: Wed, 23 Apr 2025 19:54:36 +0300
Message-ID: 
 <CAN-LCVM6A9z6AzxsEX-vx9=3XgEUU6+zjUqejQw8LfjaRY5P1A@mail.gmail.com>
Subject: Re: SQL:2023 JSON simplified accessor support
To: Vik Fearing <vik@postgresfriends.org>
Cc: Alexandra Wang <alexandra.wang.oss@gmail.com>,
	Mark Dilger <mark.dilger@enterprisedb.com>,
 Matheus Alcantara <matheusssilv97@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
 Andrew Dunstan <andrew@dunslane.net>,
	Nikita Glukhov <glukhov.n.a@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	"David E. Wheeler" <david@justatheory.com>,
 jian he <jian.universality@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000bc45b2063374f5b5"
Archived-At: 
 <https://www.postgresql.org/message-id/CAN-LCVM6A9z6AzxsEX-vx9%3D3XgEUU6%2BzjUqejQw8LfjaRY5P1A%40mail.gmail.com>
Precedence: bulk

--000000000000bc45b2063374f5b5
Content-Type: text/plain; charset="UTF-8"

Hi Alex!

Glad you made so much effort to develop this patch set!
I think this is an important part of Json functionality.

I've looked into you patch and noticed change in behavior
in new test results:

postgres@postgres=# create table t(x int, y jsonb);
insert into t select 1, '{"a": 1, "b": 42}'::jsonb;
insert into t select 1, '{"a": 2, "b": {"c": 42}}'::jsonb;
insert into t select 1, '{"a": 3, "b": {"c": "42"}, "d":[11, 12]}'::jsonb;
CREATE TABLE
Time: 6.373 ms
INSERT 0 1
Time: 3.299 ms
INSERT 0 1
Time: 2.532 ms
INSERT 0 1
Time: 2.453 ms

Original master:
postgres@postgres=# select (t.y).b.c.d.e from t;
ERROR:  column notation .b applied to type jsonb, which is not a composite
type
LINE 1: select (t.y).b.c.d.e from t;
                ^
Time: 0.553 ms

Patched (with v11):
postgres@postgres=# select (t.y).b.c.d.e from t;
 e
---


(3 rows)

Is this correct?

--
Regards,
Nikita Malakhov
Postgres Professional
The Russian Postgres Company
https://postgrespro.ru/

--000000000000bc45b2063374f5b5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Alex!<div><br></div><div>Glad you made=
 so much effort to develop this patch set!</div><div>I think this is an imp=
ortant part of Json functionality.</div><div><br></div><div>I&#39;ve looked=
 into you patch and noticed change in behavior</div><div>in new test result=
s:</div><div><br></div><div>postgres@postgres=3D# create table t(x int, y j=
sonb);<br>insert into t select 1, &#39;{&quot;a&quot;: 1, &quot;b&quot;: 42=
}&#39;::jsonb;<br>insert into t select 1, &#39;{&quot;a&quot;: 2, &quot;b&q=
uot;: {&quot;c&quot;: 42}}&#39;::jsonb;<br>insert into t select 1, &#39;{&q=
uot;a&quot;: 3, &quot;b&quot;: {&quot;c&quot;: &quot;42&quot;}, &quot;d&quo=
t;:[11, 12]}&#39;::jsonb;<br>CREATE TABLE<br>Time: 6.373 ms<br>INSERT 0 1<b=
r>Time: 3.299 ms<br>INSERT 0 1<br>Time: 2.532 ms<br>INSERT 0 1<br>Time: 2.4=
53 ms</div><div><br></div><div>Original master:</div><div>postgres@postgres=
=3D# select (t.y).b.c.d.e from t;<br>ERROR: =C2=A0column notation .b applie=
d to type jsonb, which is not a composite type<br>LINE 1: select (t.y).b.c.=
d.e from t;<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^<br=
>Time: 0.553 ms</div><div><br></div><div>Patched (with v11):</div><div>post=
gres@postgres=3D# select (t.y).b.c.d.e from t;<br>=C2=A0e<br>---<br><br><br=
><br>(3 rows)</div><div><br></div><div>Is this correct?</div></div><br><div=
 class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmai=
l_attr">--</div></div><div dir=3D"ltr" class=3D"gmail_signature"><div dir=
=3D"ltr"><div style=3D"color:rgb(34,34,34)">Regards,</div><div style=3D"col=
or:rgb(34,34,34)">Nikita Malakhov</div><div style=3D"color:rgb(34,34,34)">P=
ostgres Professional</div><div style=3D"color:rgb(34,34,34)">The Russian Po=
stgres Company</div><div style=3D"color:rgb(34,34,34)"><a href=3D"https://p=
ostgrespro.ru/" target=3D"_blank">https://postgrespro.ru/</a></div></div></=
div></div>

--000000000000bc45b2063374f5b5--