MIME-Version: 1.0
References: <CAN-LCVP7HXmGu-WcinsHvdKqMGEdv=1Y67H4U58F6Y=Q0M5GyQ@mail.gmail.com>
 <CA+HiwqGqz1+jvrWHHzYSnzuVZPp4v-vfEyX-hB=3hTP3Asf78Q@mail.gmail.com>
In-Reply-To: <CA+HiwqGqz1+jvrWHHzYSnzuVZPp4v-vfEyX-hB=3hTP3Asf78Q@mail.gmail.com>
From: Nikita Malakhov <hukutoc@gmail.com>
Date: Tue, 4 Feb 2025 14:50:35 +0300
Message-ID: <CAN-LCVNSSCTdMjSFHKMkPUDcxNiGX1qn=EWMmmph8dmhkOaj_g@mail.gmail.com>
Subject: Re: SQL/JSON json_table plan clause
To: Amit Langote <amitlangote09@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000b82f47062d4f9efc"
Archived-At: <https://www.postgresql.org/message-id/CAN-LCVNSSCTdMjSFHKMkPUDcxNiGX1qn%3DEWMmmph8dmhkOaj_g%40mail.gmail.com>
Precedence: bulk

--000000000000b82f47062d4f9efc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Amit!

No, JSON_TABLE is ok. I've meant that in the previous approach to PLAN
clause
implementation there were some wrong tests.

On Tue, Feb 4, 2025 at 6:05=E2=80=AFAM Amit Langote <amitlangote09@gmail.co=
m> wrote:

> Hi Nikita,
>
> On Wed, Dec 18, 2024 at 12:11=E2=80=AFAM Nikita Malakhov <hukutoc@gmail.c=
om>
> wrote:
> >
> > Hi hackers!
> >
> > This thread is further work continued in [1], where Amit Langote
> > suggested starting discussion on the remaining SQL/JSON feature
> > 'PLAN clause for JSON_TABLE' anew.
> >
> > We'd like to help with merging SQL/JSON patches into vanilla,
> > and have adapted PLAN clause to recent changes in JSON_TABLE
> > function.
>
> Thanks for working on this.
>
> > While doing this we've found that some tests with the PLAN clause
> > were incorrect, along with JSON_TABLE behavior with this clause.
> > We've corrected this behavior, but these corrections required reverting
> > some removed and heavily refactored code, so we'd be glad for review
> > and feedback on this patch.
>
> Sorry, I don't fully understand this paragraph.  Do you mean that
> there might be bugs in the existing JSON_TABLE() functionality that
> was committed into v17?
>
> --
> Thanks, Amit Langote
>


--=20
Regards,
Nikita Malakhov
Postgres Professional
The Russian Postgres Company
https://postgrespro.ru/

--000000000000b82f47062d4f9efc
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Amit!<div><br></div><div>No, JSON_TABL=
E is ok. I&#39;ve meant that in the previous approach to PLAN clause</div><=
div>implementation there were some wrong tests.</div></div><br><div class=
=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr=
">On Tue, Feb 4, 2025 at 6:05=E2=80=AFAM Amit Langote &lt;<a href=3D"mailto=
:amitlangote09@gmail.com">amitlangote09@gmail.com</a>&gt; wrote:<br></div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex">Hi Nikita,<br>
<br>
On Wed, Dec 18, 2024 at 12:11=E2=80=AFAM Nikita Malakhov &lt;<a href=3D"mai=
lto:hukutoc@gmail.com" target=3D"_blank">hukutoc@gmail.com</a>&gt; wrote:<b=
r>
&gt;<br>
&gt; Hi hackers!<br>
&gt;<br>
&gt; This thread is further work continued in [1], where Amit Langote<br>
&gt; suggested starting discussion on the remaining SQL/JSON feature<br>
&gt; &#39;PLAN clause for JSON_TABLE&#39; anew.<br>
&gt;<br>
&gt; We&#39;d like to help with merging SQL/JSON patches into vanilla,<br>
&gt; and have adapted PLAN clause to recent changes in JSON_TABLE<br>
&gt; function.<br>
<br>
Thanks for working on this.<br>
<br>
&gt; While doing this we&#39;ve found that some tests with the PLAN clause<=
br>
&gt; were incorrect, along with JSON_TABLE behavior with this clause.<br>
&gt; We&#39;ve corrected this behavior, but these corrections required reve=
rting<br>
&gt; some removed and heavily refactored code, so we&#39;d be glad for revi=
ew<br>
&gt; and feedback on this patch.<br>
<br>
Sorry, I don&#39;t fully understand this paragraph.=C2=A0 Do you mean that<=
br>
there might be bugs in the existing JSON_TABLE() functionality that<br>
was committed into v17?<br>
<br>
-- <br>
Thanks, Amit Langote<br>
</blockquote></div><div><br clear=3D"all"></div><div><br></div><span class=
=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_s=
ignature"><div dir=3D"ltr"><div style=3D"color:rgb(34,34,34)">Regards,</div=
><div style=3D"color:rgb(34,34,34)">Nikita Malakhov</div><div style=3D"colo=
r:rgb(34,34,34)">Postgres Professional</div><div style=3D"color:rgb(34,34,3=
4)">The Russian Postgres Company</div><div style=3D"color:rgb(34,34,34)"><a=
 href=3D"https://postgrespro.ru/" target=3D"_blank">https://postgrespro.ru/=
</a></div></div></div></div>

--000000000000b82f47062d4f9efc--