MIME-Version: 1.0
References: <CAN-LCVMV3m+pzSDqOLyzgVRXA2zJ94n_T7kyAc2Z5JJpH018sA@mail.gmail.com>
 <20230206104917.sipa7nzue5lw2e6z@alvherre.pgsql> <CAN-LCVOv5is9dUn1U3KYy4hAhVK7tx6a7goOFmgbrGM7ZSAxRA@mail.gmail.com>
 <CAJ7c6TMZ7xySLzhygvzezPysyM5aZ6OjO8zHSUTO+GMBeL1a3g@mail.gmail.com> <CAEze2WhRJwr7MhkcckxpOAR5=6gUQQQmVdfPtvNu-u8J8RkzmA@mail.gmail.com>
In-Reply-To: <CAEze2WhRJwr7MhkcckxpOAR5=6gUQQQmVdfPtvNu-u8J8RkzmA@mail.gmail.com>
From: Nikita Malakhov <hukutoc@gmail.com>
Date: Mon, 6 Feb 2023 23:21:45 +0300
Message-ID: <CAN-LCVOpseYfhfgr5MB=OHcCWjOpLk8P56gXxJkyRpU3CB11CQ@mail.gmail.com>
Subject: Re: Pluggable toaster
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, 
	Alvaro Herrera <alvherre@alvh.no-ip.org>, vignesh C <vignesh21@gmail.com>, 
	Jacob Champion <jchampion@timescale.com>, Andres Freund <andres@anarazel.de>, 
	Robert Haas <robertmhaas@gmail.com>, Greg Stark <stark@mit.edu>, Teodor Sigaev <teodor@sigaev.ru>
Content-Type: multipart/alternative; boundary="00000000000062e73805f40dc899"
Archived-At: <https://www.postgresql.org/message-id/CAN-LCVOpseYfhfgr5MB%3DOHcCWjOpLk8P56gXxJkyRpU3CB11CQ%40mail.gmail.com>
Precedence: bulk

--00000000000062e73805f40dc899
Content-Type: text/plain; charset="UTF-8"

Hi,

It'll be great to see more opinions on the approach as a whole.

>The problem that I see being raised here, is that there was little
>discussion and no observed community consensus about the design of
>this complex feature *before* this patch with high complexity was
>provided.
>The next action that was requested is to take a step back and decide
>how we would want to implement type-aware TOASTing (and the associated
>patch compression dictionaries) *before* we look into the type-aware
>toasting.

We decided to put this improvement as a patch because we thought
that the most complex and questionable part would be the TOAST
implementations (the Toasters) itself, and the Pluggable TOAST is
just a tool to make plugging different TOAST implementations clean
and simple.

--
Nikita Malakhov
Postgres Professional
https://postgrespro.ru/

--00000000000062e73805f40dc899
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi,<div><br></div><div>It&#39;ll be great=
 to see more opinions on the approach as a whole.</div><div><br></div><div>=
&gt;The problem that I see being raised here, is that there was little<br>&=
gt;discussion and no observed community consensus about the design of<br>&g=
t;this complex feature *before* this patch with high complexity was<br>&gt;=
provided.<br>&gt;The next action that was requested is to take a step back =
and decide<br>&gt;how we would want to implement type-aware TOASTing (and t=
he associated<br>&gt;patch compression dictionaries) *before* we look into =
the type-aware<br>&gt;toasting.<br></div><div><br></div><div>We decided to =
put this improvement as a patch because we thought</div><div>that the most =
complex and questionable part would be the TOAST</div><div>implementations =
(the Toasters) itself, and the Pluggable TOAST is=C2=A0</div><div>just a to=
ol to make plugging different TOAST implementations clean</div><div>and sim=
ple.</div></div><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_=
attr"><br></div></div><div dir=3D"ltr" class=3D"gmail_signature"><div dir=
=3D"ltr"><div style=3D"color:rgb(34,34,34)">--</div><div style=3D"color:rgb=
(34,34,34)">Nikita Malakhov<br></div><div style=3D"color:rgb(34,34,34)">Pos=
tgres Professional=C2=A0</div><div style=3D"color:rgb(34,34,34)"><a href=3D=
"https://postgrespro.ru/" target=3D"_blank">https://postgrespro.ru/</a></di=
v></div></div></div>

--00000000000062e73805f40dc899--