public inbox for [email protected]  

help / color / mirror / Atom feed
From: Krasiyan Andreev <[email protected]>
To: Oliver Ford <[email protected]>
Cc: Tatsuo Ishii <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Vik Fearing <[email protected]>
Cc: Pg Hackers <[email protected]>
Cc: [email protected]
Cc: David Fetter <[email protected]>
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Date: Sat, 29 Mar 2025 09:51:55 +0200
Message-ID: <CAN1PwomkQhCb50oF8cUJUkjgdwCjPKXLW10_DdoPR_baPxLi=Q@mail.gmail.com> (raw)
In-Reply-To: <CAGMVOduuhBa5b9ZzsJ2EwQZKFJhtjx3j4xwmbvfNo8Oks63mZw@mail.gmail.com>
References: <CAGMVOdvtAEvv3KgkFoa2W5-vpz--QEvrVbvS84ZikcCb-SyA6g@mail.gmail.com>
	<[email protected]>
	<CAGMVOdvCwq-jUYgBA1H_3oeHR7HOYTSGtwPoFsJPkyRfjWRVTQ@mail.gmail.com>
	<[email protected]>
	<CAGMVOdvAfKzfjDoA747fGNxYKdXG3rBiqRnwaz=FTcqW1TyOOA@mail.gmail.com>
	<CAGMVOduuhBa5b9ZzsJ2EwQZKFJhtjx3j4xwmbvfNo8Oks63mZw@mail.gmail.com>

Hi,
Patch applies and compiles, all included tests passed and after the latest
fixes for non-nulls array, performance is near to lead/lag without support
of "ignore nulls".
I have been using the last version for more than one month in a production
environment with real data and didn't find any bugs, so It is ready for
committer status.

На чт, 13.03.2025 г. в 9:49 Oliver Ford <[email protected]> написа:

>
>
> On Sun, 9 Mar 2025, 20:07 Oliver Ford, <[email protected]> wrote:
>
>> On Sun, Mar 9, 2025 at 6:40 AM Tatsuo Ishii <[email protected]> wrote:
>>
>>> > Attached version removes the non-nulls array. That seems to speed
>>> > everything up.  Running the above query with 1 million rows averages
>>> 450ms,
>>> > similar when using lead/lag.
>>>
>>> Great. However, CFbot complains about the patch:
>>>
>>> https://cirrus-ci.com/task/6364194477441024
>>>
>>>
>> Attached fixes the headerscheck locally.
>>
>
> v11 attached because the previous version was broken by commit 8b1b342
>
>>


view thread (97+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
  In-Reply-To: <CAN1PwomkQhCb50oF8cUJUkjgdwCjPKXLW10_DdoPR_baPxLi=Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox