Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7d9L-005Xk2-0q for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Mar 2026 17:45:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w7d9J-00Bpgz-2K for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Mar 2026 17:45:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7d9J-00Bpgr-1H for pgsql-hackers@lists.postgresql.org; Tue, 31 Mar 2026 17:45:09 +0000 Received: from mail-yx1-xb12b.google.com ([2607:f8b0:4864:20::b12b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w7d9H-000000020N6-2yNc for pgsql-hackers@lists.postgresql.org; Tue, 31 Mar 2026 17:45:08 +0000 Received: by mail-yx1-xb12b.google.com with SMTP id 956f58d0204a3-64d5a7926cfso9062261d50.2 for ; Tue, 31 Mar 2026 10:45:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774979107; cv=none; d=google.com; s=arc-20240605; b=aEj6SA4IjCh0EYdcI7qUyTu1FvG+KXD3pKeuNOkT1sFuKrtxB2R8QDgNTqtVMlGu8M xgtLCHUgOc+UqvK7TB0CZ/0GFYdep1hLF8K2txdirwdv3XtFadH70Zu5EON3k9ZU9E1m Vsga5Jk1rAqqIlbmiEOEnskcXvuRpK597YEYh6hGB1HCAVRLG447wO+nv8uUamdwuzkZ uHt1dp3FplpUIhYXZshcylPpqaDpOmeEgoPAuu+uWX8/W8cIk/k/LEnuUMK3+hQ0RjjC 46laaGMlWY1fOHzJf51hAXkuzt6MYeU0qDfZwtGDIXScSBvtJV0zsLddibh0XDk99IIc nYjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=Ug525byKBCNziBQ0+1D1LvJSWvsJ4zrsZ4HIa+iRsrY=; fh=KJqbGoqY250Tjp1IoJ4/nMPGgzk4wqj0kX2kDwZjgck=; b=HPmoZJ2EyCaYYpaFgsAHyNqZFXYKIdPJMiL6eNgWgV/D6rkFTpexYO1B4ppM7J6Wbv WOIxW7RuClM/G5XauZ1u3aScBBQA+YPKNE66Q+p9oH6Pp2p/atgh/zsoKBlyMiKy+oao iQ9MjESpTKkMBY6kzSb1XvGagDC6JT2RICiiBANWpTh1DZRe6UeSOMVKkXsW2UR/NBMv qUXy6jPJK24IXzWvKYXDC1+KCdlid+wj99VB3378S3X2is1Quir8G3LByG/tcGrbyE5u 11DtvhHYmaMCpmEKpRMAqglBvO1lDv9qDl9f0Ga4f1ni1iIdwhgd5dnnS2ugRjVsjSxb 1fhQ==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=percona.com; s=google; t=1774979107; x=1775583907; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Ug525byKBCNziBQ0+1D1LvJSWvsJ4zrsZ4HIa+iRsrY=; b=bEdA68fulQ7s/4uhWqajO0WJd9H5HeJ1AOKzbPOydxald7sk3Mxg4WDOq5mnvo0gmL eOIOmKfw+kKnGKS5GbDCvR22DBQZ5Zld+0jTAy3HCfFeKnpjX54Y+jQQ2PI0MeA7EtGK AqcYQ/jDx7lyORJgA8BxiOIxxrXNIB4TiQuHo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774979107; x=1775583907; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ug525byKBCNziBQ0+1D1LvJSWvsJ4zrsZ4HIa+iRsrY=; b=XO0kYgqrHtr+KXqEgvMJB/54BHta+oLhz4MczTjmg7f9hqQ7Klb6UdITTM+Rood2vF zcaoEk4zCDwhv+DdY6I1EraEkni2dedhl2a/8SasmldVyWTm3HjPPIsctcPsujN9rxOK HP8JSrEaSlNq2VzRIxFDdOWQ4xWRT7RDHb+NyFkBwyvF0RMGEcXvq29YDprgn3KWBZbm JN3PGr5EX/TbWWbZ3K5Lr24M98ypqnkngVlCAWuXB/7GiRvUprf8ljbgLgHhbtycfcmO da18BiJZ1S5t4jMeuSVJh9am23rDLu+d9OpMuHK0/u7MSi5UT9IhHfDX+BLUJjhkPrQU FhAQ== X-Gm-Message-State: AOJu0YzSnFN0cEog4tkYcCLx4fm35FOByB2OxOxaKQr9zlk6gdWuh1mL GUoc3ZE0SwO+WActz60c0FDZPR3SmIAt3Kh72kL/vAqDyH/bkIPYL2m0ri99SnmOAPTVNcBLXpy NHiyErIdLJghtsUclgQv54vdb4bP2x6s7JHgoI/gdVig15cgiKZ9nNH3/4V96QVph+gpCaZfoE6 wcqxjJULfSsVgLKeoUYxCPH2S1ehUjjrQUeEea6c7Ioy89nbz0+MNrDCOLzysMSarr2MFw1MEMw CTnDpcRxD2YAbkpP5JydPNyowJfmqNVYCWq2kmh8WtJ0qGtqO1HevWAtQH1yjEeXBc= X-Gm-Gg: ATEYQzxt30nKM94Be9hhRU7TmwcFWMkm8uEc8I60JHnlh2xZBdUETtEF21k9mvsXsZO rfIVoG0D45UoTuvExcZmucSE2fHH8cs+gl4E8UqkGdsNaCGhsqF1OvdipbzzuR4jc5uyxC3QEn3 ikkVTB4EJV5U1lQa/QSxIkUSSNgvcIwP1Tvo+0pMqJYW+QkQB2a5alkomK4m04grZc1u43o6KRp D2wZTs5sntUJsmdNKJgmhbAC9VblWlZH5Fm1YlAffPCynF5zgoewxG0hMuXLBVESJ79hKOLvRKp FcwEx4YaBWV4FQlIhUtIT2UkTbRsB6M+mF78h+agIqziNSW1XWG8Ct5Y5r0CtZmpntZB X-Received: by 2002:a05:690c:82:b0:798:7309:a427 with SMTP id 00721157ae682-7a21184beb2mr3419337b3.36.1774979106593; Tue, 31 Mar 2026 10:45:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Zsolt Parragi Date: Tue, 31 Mar 2026 18:44:55 +0100 X-Gm-Features: AQROBzD6iXj12YVJEnMRHVqpTdIqTixwdj1hg2SaQ7maH284sQreQ3yIOyDxAJ0 Message-ID: Subject: Re: [oauth] Split and extend PGOAUTHDEBUG To: Jacob Champion Cc: PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: percona,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Thanks for the review, these changes generally sound good. > I think `fast-retry` needs to be moved under UNSAFE and renamed to > something that doesn't sound "good". `dos-interval` maybe? I would use a different name, for something like `dos-interval` I would expect to provide a time since it's an interval? `immediate-retry` maybe? Or `dos-retry`? > nitpick: `poll-counts` and `print-plugin-errors` choose different > naming conventions, and we're not referring to the poll() API for the > former. `call-count`? `dlopen`? I didn't want to write "print-poll-counts" and "print-trace" as those are just longer, while simply writing "plugin-errors" without print also seemed wrong. Maybe it could be "plugin-debug" instead, that sounds good even withour print? > I have a sample patch locally for these suggestions, if you'd like. I can create a patch with these updates tomorrow, but if you already have it, that might be easier/quicker. > I'm not a fan of 0002 That's okay, I am fine with dropping that. We are already using that small custom libpq client for testing, so we can keep using it. I just thought this could make things easier/clearer to others.