MIME-Version: 1.0
References: <DDPQ1RV5FE9U.I2WW34NGRD8Z@jeltef.nl> <DFJ3E1X9169E.WV892I950LYW@jeltef.nl>
 <DFY0RHAZTTXJ.15AD95RE6A5N5@jeltef.nl> <CAN4CZFOw2v9G_9vuP0vnNH8K9X_UeSOyq=gWJp7bdGZ5HKNTDA@mail.gmail.com>
 <DG9X4XC66EMC.2S34SS1SZ8K3K@jeltef.nl> <DGBMBCDXXNBG.3CNHEZ9QVB4GL@jeltef.nl>
In-Reply-To: <DGBMBCDXXNBG.3CNHEZ9QVB4GL@jeltef.nl>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Wed, 25 Feb 2026 15:08:39 +0000
Message-ID: <CAN4CZFMLpakQb8qohDAnrOoQ1-UrvmzJewZss95Y+Mf_J+iNeA@mail.gmail.com>
Subject: Re: Add GoAway protocol message for graceful but fast server shutdown/switchover
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Dave Cramer <davecramer@gmail.com>, 
	Jacob Champion <jacob.champion@enterprisedb.com>, Heikki Linnakangas <hlinnaka@iki.fi>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAN4CZFMLpakQb8qohDAnrOoQ1-UrvmzJewZss95Y%2BMf_J%2BiNeA%40mail.gmail.com>
Precedence: bulk

+ /*
+ * Only signal regular backends, since those need to notify
+ * their clients using a GoAway message.
+ */
+ if (bp->bkend_type == B_BACKEND)

This condition is slightly different to how SignalChildren works, is
that intentional? I don't think it causes any practical difference,
and I don't see an easy way to reuse SignalChildren for this, but
maybe it could still follow the same pattern.

Otherwise I don't see any other issues, and this also doesn't seem to
be an important comment.

Since the pytest framework seems unlikely to be included in PG19, have
you considered a different test implementation, to have at least some
minimal coverage?