Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7iNb-005ciR-1p for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Mar 2026 23:20:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w7iNZ-00Dh4T-30 for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Mar 2026 23:20:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7iNZ-00Dh4L-1u for pgsql-hackers@lists.postgresql.org; Tue, 31 Mar 2026 23:20:14 +0000 Received: from mail-yx1-xb12e.google.com ([2607:f8b0:4864:20::b12e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w7iNX-000000022s0-2zmy for pgsql-hackers@lists.postgresql.org; Tue, 31 Mar 2026 23:20:12 +0000 Received: by mail-yx1-xb12e.google.com with SMTP id 956f58d0204a3-6501547d7edso7008356d50.0 for ; Tue, 31 Mar 2026 16:20:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774999211; cv=none; d=google.com; s=arc-20240605; b=ZibK+4DirTWWg/mhHmkG44yJ9Z1stpt6CNeDrhcTCwlvRwuxbwi+k4AKFq7Za2sF1y 6Odmz65cSTrkKzHAWk5WBm8TY81aRv7G7zapUejGr6wAREbolV9CtUJY0Ohxw5tjAcYM QkrB1zU7oVM4DlTbugnrzmTNNhA7h29paMIzpZbCvFAFQSHIm6Sbbf7tireZsOo85uGh gbk22432jMwWHmdHvHnr2w3f5liOMkSxUJnK8sR6dGoE+udpi97L+1SnvENaRmeeXlBZ Y9HGh/mhIR/pufZV/4HwRoRtHbdz4K1ssivSe1bWHAhNmeAE8fyaG9PV+YWNMXebank+ 5W2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=1oeEB+0A0LlkEVkOK44ZWmKQadJQAXa5hCdOPtP1xj4=; fh=VJKmFzD4wcwv3jHpB1H5pKuy2zMaQdIzW/64Fa5UsP4=; b=AZrX0fjlSRLB9NegZBD430XviOBw2NgGio69N2+AAjx6nb7eO1VT5O0vXNrA/4wJc9 yUE4K/LKd63Y6dJpOXz5NC3VVYOKs+M9BbEUHfkzRInatS5lzuYC3hb5iwbANLZgFSWH xEDL46jRDNNQAMaKlOM4fPaq1auzzmGjtFtA0gJsODvjZ1guahV/WuhhADjI4UyX7Q6L MCn9AzJ4dWJ9d9KfdrsA7XsAnwlY0c4G3rL6cQ3ylzPGD8NCaOsgmUbl2W1etYemGxQG FJf6jXiyqSNoN7tUaiM29nljqZir04uvnBsTjcvu4QI4bcBAl+X//KbVvxN0AZfB/asY E5TA==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=percona.com; s=google; t=1774999211; x=1775604011; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1oeEB+0A0LlkEVkOK44ZWmKQadJQAXa5hCdOPtP1xj4=; b=bz9Hm4VuynRlIP+VZ7UwgkXLvaSg0N/SMbCfCKEAjrm+I1xoWbjCRjtjiT1StsEpc3 hh7/eBhDmsDgPBaMC9KILuy/asd0bxBeHjTEZP9U9wZGgjNpy43oIq6nQqH03hB4q3VG oqLoNWMBct9Nd1nRms545J2eHlYsjAme9tHws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774999211; x=1775604011; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1oeEB+0A0LlkEVkOK44ZWmKQadJQAXa5hCdOPtP1xj4=; b=efD204b27138HDd1Lve8XuyanM3XxhqxQUHqlpn+uQ0VlfZm7RmUefYht3oQwE2l+J YcRVrWyT2rAyoybovmAQXGQuefyF40fZUt5il/yKTr/BpaOFNr0qrizdITaqcrvJMxjF djt9Xobl23lf+zmtRzgUeOQyo5JosFYuAGfHe1KYQkckKh6rEd8uphJSQcxBel/SSIVV BC4BeTEOb0nSmkAba/dDbHrBoTowOjnMt5lpSCWa87YIZfosn8LkEMb4W4MjNtAGacrQ PJhjD1+NHy1O4Ef/An3M8+WoRZ3fLpTevzAmrmOVYmBHqtp00gWPNKcyK+vkJmgFBSdx nnbQ== X-Forwarded-Encrypted: i=1; AJvYcCXi0ud/oFwgPROuL2NKHvosNy+vYBO9RUPOd2Z5XLWeEC3Vj8y+KIvZRBBYZzUaXniFh8XAQi2spFTx4dNc@lists.postgresql.org X-Gm-Message-State: AOJu0YzGCDBceArIMwqgZjpqPlbNriQyAmeUg/4RQYCJ/d0aJQ3QZ5dE NF98zc5RjPHy3yHr/qCKsc277xrQc+Mz57U8cZrfoII5DZogrt5swn0xbsE4BDCPZSSutCvQC9P tXXf2YsmEdkX6U15ktn8cs2bBmz7C2Y4ul03gvv/l/QfppErzemrdv+ZcfXQgNPh9L6BZsQm7GA 4uvEqz3W/HUOTU1Adquh/VTjt6VZ5nJlo4n0ScnNHos0gNfhq1DOGHwA0shKkTfFe9ehROuxYNm uwaDvULGCH8ybBl5caO3nT7FDIkvBRvoN30ES2EXpKAxrAk3NZ3t8pPpXnhPz5fiEQ= X-Gm-Gg: ATEYQzxFzSxIHDVc/wrmhqbncDJqjrkycpixsYGVdUFNRx47Orw6Dng/YLLE6fTmh7a mnXooSkIDYWB/MrL+LLEK4wnSl+K/GR9PUckUMilKg0KchqDE/Gz89nJrj8KzhQG3E+zl8O+0XM xKLAPFI0C904JO3EdwSv4ec3k8TJ3HG0sV+Fi2kGc2KacwLVUkRZ06mFFlCj+iezwL2JFqJkRUC 8ayEMnCRv24lzDZy5dkBOuS2U5yw/f5kb3aJ5kTygBFe/YFj2m+J4TDfrBckT1ZgYtJggJvb69l OtM5CLYKj6Wx+YXuuGxsyu2FKyZENIlD/yswnsuJ+wBEPf3124U+tlSA0yUxO31inW8q X-Received: by 2002:a05:690c:c4f9:b0:79c:c51c:7f4a with SMTP id 00721157ae682-7a212d16defmr15538487b3.46.1774999211011; Tue, 31 Mar 2026 16:20:11 -0700 (PDT) MIME-Version: 1.0 References: <202603301206.adis56q72squ@alvherre.pgsql> <202603311555.w42t5agupy3z@alvherre.pgsql> In-Reply-To: <202603311555.w42t5agupy3z@alvherre.pgsql> From: Zsolt Parragi Date: Wed, 1 Apr 2026 00:20:00 +0100 X-Gm-Features: AQROBzBUDa06Zu5lJt3dopGxTsCn-a-9BZgFSkqvKUv_sLIphFWMNFU6x--mR9E Message-ID: Subject: Re: table AM option passing To: =?UTF-8?Q?=C3=81lvaro_Herrera?= Cc: Andres Freund , Pg Hackers , Nathan Bossart Content-Type: text/plain; charset="UTF-8" X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: percona,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk static inline TM_Result table_tuple_delete(Relation rel, ItemPointer tid, CommandId cid, - Snapshot snapshot, Snapshot crosscheck, bool wait, - TM_FailureData *tmfd, bool changingPart) + uint32 options, Snapshot snapshot, Snapshot crosscheck, + bool wait, TM_FailureData *tmfd) The doc comment still referneces changingPart Similarly table_tuple_update doesn't document the new options parameter. @@ -339,7 +341,8 @@ heapam_tuple_update(Relation relation, ItemPointer otid, TupleTableSlot *slot, slot->tts_tableOid = RelationGetRelid(relation); tuple->t_tableOid = slot->tts_tableOid; - result = heap_update(relation, otid, tuple, cid, crosscheck, wait, + result = heap_update(relation, otid, tuple, cid, options, + crosscheck, wait, tmfd, lockmode, update_indexes); ItemPointerCopy(&tuple->t_self, &slot->tts_tid); options is marked pg_attribute_unused above, that seems misleading. Should the annotation be part of the heap_update signature instead?