Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wKMlt-000tfB-07 for pgsql-hackers@arkaria.postgresql.org; Tue, 05 May 2026 20:53:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wKMlr-00DukR-1g for pgsql-hackers@arkaria.postgresql.org; Tue, 05 May 2026 20:53:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wKMlr-00DukI-0f for pgsql-hackers@lists.postgresql.org; Tue, 05 May 2026 20:53:35 +0000 Received: from mail-yw1-x112f.google.com ([2607:f8b0:4864:20::112f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wKMlo-00000000iJQ-3WzQ for pgsql-hackers@postgresql.org; Tue, 05 May 2026 20:53:34 +0000 Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-7bd5c773ef3so68425247b3.1 for ; Tue, 05 May 2026 13:53:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778014411; cv=none; d=google.com; s=arc-20240605; b=jbYhatczf2sUbwyDtCW1p6drB20LkEi6a5Iq8TTMsp9qXwMA+hrCmHD9T3hsL9tVP3 fsVJZlaLtlcf/+C8QH1aGK4+T0c3CNv/orYlbo0Pux0LYbLyrqimAjG6cdwvQZWJJ00I yYgbQodRtT1njKxFeTWTfHiTJEY7VunYdu867QJnbg0EC/J6WZuA2rwYn2IarV+nomQ5 mj1LnUeE421MrFXrsKq6GkrY9UFuoL32TVzZPvGX6+KP2ACXgPL3nW1KMOBuR8af9PS4 FboirrMCrY7NhPt1bg+buG2J3eudNCklwP71jZ8ZvuHfoGcJBSdAHJ9Qcx/5kS/KSIJO lUkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=ali9tXgn7GHf8qQlZ6oxQdwx41anMEa/KF0Z1FueDQw=; fh=77WpnDnb7V1hvUaeEdoQN/y6mzb8CRckAq4bRdovKc4=; b=A6/OhM4Qc1KZD4egDcLd2MpcZNm1YFxThbafNmbYDdcfTSRCdHZLAZqfKhg2fJM9QZ fgGkRwL2RiR4GEyLMlvMQ4HhBr9Bc3pK4iY4tZr/1hkUGSPciOilP9XFwtALks5yIYla Jc00jsjLsLt/X1fBMZMl26ZzDvGuFqjLCWvaUbn9CVtLszghig2fNPuRNwJU4lk37A7G OGBJjsXNSB6G56rw/rhVW3N0wFFNqXFbzwR+tmhWxL0sb0dS7wSRrKMe1l4heb3mn3NK sIOgyogQxwTZf5GJaa5/miuVdq/pOtfx2sU0GjfW7zqk59mR33s2HgJIyrTo6qolU8Gv 6i4g==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=percona.com; s=google; t=1778014411; x=1778619211; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ali9tXgn7GHf8qQlZ6oxQdwx41anMEa/KF0Z1FueDQw=; b=SqbRvwhiAlndUd3DeU7KOfIS6gv45gLOHHD9P7/AEiigr126/lto8RlyqeRsi1WMgw RkixfnhpQ1LkK4bQfegg3Esioj5V57Vf+jxBQ7SqyiGecp4iOzSBq6n4rozqhn4fk6uE 6of603LZ1PEZ6TnVLi1eOvBEru3Pn8JkztlS4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778014411; x=1778619211; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ali9tXgn7GHf8qQlZ6oxQdwx41anMEa/KF0Z1FueDQw=; b=fMa00dvMrySR5OHdrw6+SfEd6yXN6kRTBt0IKSRGX9vFaN2+PpYBhRjDC228MmPVdn Sdkf3BDzsaRugQ+sIZYgFX+velalwlY4Cxlxbxxbt+598eJPSVVFFv+jUHZUyixTNz1Y 2zZn8w0FrDUl/N298b/2vZkIh5P0lnnwyBVRQxZJkyz2tNAnr5vn54oL39RG6n+Hnxui ocGoOJALiRczuJR/x/0iX3XUBr7tjlt0sqUIa+IJ61641MBQTNK7J1zsaJjNt1mtgFME gSR7Qy3+Vn/qsiMT/rijldZv2DVN2YtE2a/EjW2IRjHHl1wDHs6oAIecWwX8zMpgrdDD 4s5w== X-Forwarded-Encrypted: i=1; AFNElJ9+6zojO4UzwVEvEAxw49Kw9bN0MEEYXf9emhY+/hGYj6H96Oy6+eh/JXS2mDQBeLe6nkorEl8EcMY7wfVL@postgresql.org X-Gm-Message-State: AOJu0Yzk+6GTe268v+RcF+Dq1AI3tcS+nz+Nz0vfFvJN0cJkp5FxoePc tbH3PolnuBP5QcX37RPmkt9evHzjx9Wld0mqbOEdBw22d3hDKzXWcMGFlUFQSSwijWNiT7AmBCK rPc2NbC+p6N+ktL1D9x9KJQDOHFAegbXglJOLVhyyioRBAhVJotX+J9gKggKatQMYZfF+vCIEGC HDV8wELk212UYdwxumHUwxkS6G3LGrbt6OKJZel1fIBYFBTRJJ6WEAcWmnPXeH1e6Bq2MuB/QhK XmzhPGkVeHVjAKhIjx80za8ZSF+WVMj9TNu0JFWhGnIWDwx0gc= X-Gm-Gg: AeBDies50j7RKkAeYXVpfVEq6o7IzvG5rgAjesUYMyJ/vRInGDHv1OgXjMA4QtmePNO rz+Tn6gUbxCWnfjuIOyirBORi0k9SCtByhP/kL4Vrv9piJlGt252ozOXv6TvOaHCtLZ1HJYX46q +eBmf+fW4itpbGNDa0rzIZ6ingPEmpG5jl2AAaldjllPkPoyIgKw41ncLG8wY6t3gUAO97ocdXd sLgEA+Gj4XlFtCUu5S1W5a6n57CGBjC12LWS1q/1gYCNXghYPDLr24e8tXi7Mi6pm2Elq0UieAH KaTOauumKl4iyxq+lhcNUr5RPadeY3TZ6A4NtkwIaUcdAfkdLRQeB3fJ096hdaUQcx1bfMGlpo3 +HxE= X-Received: by 2002:a05:690c:480a:b0:7b2:9d07:57fb with SMTP id 00721157ae682-7bdf5d9920dmr11535937b3.2.1778014410954; Tue, 05 May 2026 13:53:30 -0700 (PDT) MIME-Version: 1.0 References: <960DD2C4-A22C-463A-90ED-86E0FABD8D20@gmail.com> In-Reply-To: <960DD2C4-A22C-463A-90ED-86E0FABD8D20@gmail.com> From: Zsolt Parragi Date: Tue, 5 May 2026 21:53:20 +0100 X-Gm-Features: AVHnY4Js--11mrvM-MIp-_GDxLiHE5ov3zTG0ftQZQxDYPR8ofP7mr6S2fYMmt8 Message-ID: Subject: Re: Bug in ALTER SUBSCRIPTION ... SERVER / ... CONNECTION with broken old server To: Chao Li Cc: Ajin Cherian , PostgreSQL-development Content-Type: text/plain; charset="UTF-8" X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: percona,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello - server = GetForeignServer(subform->subserver); + server = GetForeignServer(sub->serverid); Couldn't we also move this inside the if? +/* + * Return the subscription's connection string, loading it into the + * subscription memory context if necessary. + * + * GetSubscription must be called earlier to set sub->serverid, because ACL + * checks are performed there. + */ +char * +GetSubscriptionConnInfo(Subscription *sub) This is related to Ajin's comment earlier, the part about ACL check seems incorrect to me.