Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w2xNc-000lSE-2q for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Mar 2026 20:20:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w2xNb-00EAKJ-13 for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Mar 2026 20:20:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w2xNb-00EAKA-03 for pgsql-hackers@lists.postgresql.org; Wed, 18 Mar 2026 20:20:35 +0000 Received: from mail-yx1-xb132.google.com ([2607:f8b0:4864:20::b132]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w2xNY-00000000zx0-1kjF for pgsql-hackers@lists.postgresql.org; Wed, 18 Mar 2026 20:20:34 +0000 Received: by mail-yx1-xb132.google.com with SMTP id 956f58d0204a3-64e9f79cae8so30924d50.1 for ; Wed, 18 Mar 2026 13:20:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1773865230; cv=none; d=google.com; s=arc-20240605; b=ELNkDbZP12kK5AwjliT4wOR8WNKMUnSr19sKTsGT6fCRXHouoZCfi9N9i/Uy543jdQ WL/ec6nuIWPggNjUoOj+lCGERSV4aYYBNwX1NJX4LGDbtnZVdmyBOxtsStlcKWBRvueG 8i7DVizvJShwqUrT0L/hVWCYz/RijZPg8JtApKrn4Bfs0SBYMKN2rjSsKv+pzXRt/ox+ amYd/C5/VClLrW+Hs2QIyWdNBA+Ln5hpTLoLfJ+j9WY8xf7sbJ1CrY+vZuFzBfZ/48tv YKiwvLtNG2088ZyxxYC8fSHzm14DpRe9pyKifQLab5j2oRQCLRQuYWTIabx1uK9JtYyY fLBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=r46wLXtmz4+MsXMT8odTk2Hx+J/tnTWKh5cTNEEJ62Y=; fh=Mnn878Y0bv7CMhAhqaRYP3bvHhqhOjF+MLAZ9+cp/1I=; b=KkHx7PfXjM4ZbsFwzySnNh7zM+7YdWLB+OgTCt59k5vldPPOOtq2qv0yQPLS+ddTzU YxpIB01LgKXHjxELwhT5R3HmB8JLsRpukbk4QtEtz5nDz/n3/g151Ic0FaW2tkKGCEq4 74/IiqUxcZ3b5xznhS38bR5ohK4ctTd6xF5rnqNH36fq+H1hnxUGCjSQwBzbsBfqe2aF rhEfakAvjZPwJNlXvEoY1lHQRc7os8m7/EIvzADqOWPRcZTBNvSQSvwm5Av1KqIwUitD HPxAHDTmlG65rTl4KI3h9gKcmYKW/LIzoIvQNR9TWcfMvKG51BKFPc48ayDLRS/i0AnA RSDw==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=percona.com; s=google; t=1773865230; x=1774470030; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=r46wLXtmz4+MsXMT8odTk2Hx+J/tnTWKh5cTNEEJ62Y=; b=EbKK01qNFKS93oyKpiKa/6mm+/eo68JACbd6pK8edc2ankYfxvWiPejnckYX0laMWq /W3HFPcrHvH3xzjtjLzEDYnbpjr09I5KKL/C6hboyXTHeLpHZevbFOYrAkohoEr4R9lR dbe0ZxnGDuKiMs6H3ahCYAvxtnHkHPmGO5Upg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773865230; x=1774470030; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r46wLXtmz4+MsXMT8odTk2Hx+J/tnTWKh5cTNEEJ62Y=; b=r4Mhao4cURCNzTrn7J/Nj1dUwNU9rjObfHjblPMLoWG4P96YabNVq7k1kXU87r/+7s qie6AIwf25vo71tWBpBjViBaMVA54+8nmwkZ9YuNmzxPbJMehNsdYkEKVCGLV51Ow2Zo wsh/WX5hhgiabvNhSun8Kn1Kmyv+ScW+Se2g56FkgqwKRbRU06ZdRt/vppJZsEkiU5Iq 0wjQIq3J1LbrvZEh+4SqsUXpx9pSsvKBLYA2KenYNigMwhrOxGKs8HxeSpQ67wRSDUG3 n2NUJ2Z4wIts92JPbw1bnPB5xRgi8vyJeKDeaS+Q5OlhK0lCj3z4+0LRQgr49aXasrXi bWvA== X-Gm-Message-State: AOJu0Ywh4SBvshUngXSYTMH4Xpr3V7qtra27jD3pRN04FPrN97UrJusu 3mobYtRnPB6CX8EY5eabBexny2nrJ/kovKK485mJ6gTlFCDlHQhKXEIoNLBXrVYSA4YD16chpck 2pzoi88Gfj4L7TXJRVVpS9GCLS+WLdxFfjCGY2rpOHJ1jNB+um2YNzrtgpQtULMnn98lBiFWECo CEJCMkIOfn8dasuBrjtdr9Nwi+zG/iLXDiENtKaAM5Nyww9BLOMTTHYT+a72s3vix6rsCBM+Eil TtfaFhF80mWnFrK9BJmaKSrrScZRL/HTuEG1375/KDuAHRs5IqO2TVpW/ZzqO6B3Uo= X-Gm-Gg: ATEYQzy+t/qOML44RAHgDtELQiQmUDCFOey8UKQ2V0oRZoCO0NbfBmTFIawGw6F0fQj OyVPJBWuQdl/BB0cskiJGBe75qnun4X5dDurXxOkd3xskhIP7fVo142bPn8+17zDM9E7uUEo+7h IEdZvCrlNbU5/0MSj+URN2QLD99wetdIWZ2/wOkAg4UkWxk+SXviEEV0dDZUYqvm03/mhi4mwvO xm/kH9gGgTQPQUndUD8QRyIHv2yBfuU57ORHk5/rHoqXCk1ppkHBPFeTstx+XRxgjfi/OhH9QdW d0Pl3YcVMSKKB9YJcVJUQCeOSwrVSoNVExiQflANXdj5N6QODOBBlPoVtk1ljjlLPJLf X-Received: by 2002:a05:690c:6b12:b0:799:1af1:6c62 with SMTP id 00721157ae682-79a71c48dcdmr49384427b3.39.1773865230183; Wed, 18 Mar 2026 13:20:30 -0700 (PDT) MIME-Version: 1.0 References: <202603171606.kf6pmhscqbqz@alvherre.pgsql> In-Reply-To: <202603171606.kf6pmhscqbqz@alvherre.pgsql> From: Zsolt Parragi Date: Wed, 18 Mar 2026 20:20:20 +0000 X-Gm-Features: AaiRm511z8AmlElXGfPzsrYhabVvMoBaSpTux0PhDtSdlZM_qCmOtwl-mCiKbWU Message-ID: Subject: Re: table AM option passing To: =?UTF-8?Q?=C3=81lvaro_Herrera?= Cc: Pg Hackers Content-Type: text/plain; charset="UTF-8" X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: percona,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello! I think there's a change missing in simple_table_tuple_update that works by accident, as true == 1 == TABLE_UPDATE_WAIT. Maybe the values could use a different starting value instead of 1 to surface possible issues? + * TABLE_DELETE_WAIT -- set if should wait for any conflicting + * update/delete to commit/abort + * TABLE_DELETE_CHANGING_PART -- set iff the tuple is being moved to + * another partition table due to an update of the partition key. + * Otherwise, false. "Otherwise, false" seems like a leftover from the previous comment version? tableam.h also have two leftover "wait == false" comments.