MIME-Version: 1.0
References: <CAER375OvH3_ONmc-SgUFpA6gv_d6eNj2KdZktzo-f_uqNwwWNw@mail.gmail.com>
 <CAGECzQS7Eab2vFBgE8DAq1RnTVoYb0a5X7iMyaNvApAHA7Qm2A@mail.gmail.com>
 <CAMT0RQQTahXBBDRsB9z9wzvB7y9iYO7XiVfTX+2-7DKebxcbrw@mail.gmail.com>
 <CAOYmi+kpSN9MPxP_XeRHVCXP4FcN+n+5hrCdKD9qM9KXSGKhSw@mail.gmail.com>
 <CAGECzQQb6aNZc9MepaEo6Dk2czjZFwPgAuBOp-opdKpuuhVqPA@mail.gmail.com>
 <CAOYmi+mSn8xQ7ExqY07V6G2oFXN2nY+7f4yf_RV2=7xNCKwW-Q@mail.gmail.com>
 <CAGECzQR2P8aO9tDnavLupaTAvD3Fv5e=rq0nfJ=NzT=_U2Wn5g@mail.gmail.com>
 <CAN4CZFOKaU2dfO8Sq_0tAkcq1qq9jcXYKLmEBNDt=M1P3BV5yg@mail.gmail.com>
 <CAOYmi+=fP-df=d64LC=UX0kEGktrHhJ6Wqgt8Y_XhSewmLuixQ@mail.gmail.com>
 <CAN4CZFPMMkbMYMnUE1wqHix22yFNbVm3gP49Fbk_4pKbPYme7g@mail.gmail.com>
 <CAER375Oq7gHy9WSAkRwb6AJVUs7BkSuyi1crQCNfi+kvyB6uVQ@mail.gmail.com>
 <CAOYmi+mb+fo++GvHNtcT2aspRL0jh1cSM7buEca=s9RYtFRfNA@mail.gmail.com>
 <CAER375PhPdkcapQBUx4kHw82KS1LtTfBgvZ_EpOYqK0n1s5Gpw@mail.gmail.com>
 <CAN4CZFNE6OLFzja=ysfhQzC=AORPBH2YdK2-am=cfGuk0A_s7g@mail.gmail.com>
 <CAOYmi+nXPkwam0RnF8ZChNnjeiTyPNa=grOcKZW3pzB2DUfY4Q@mail.gmail.com> <CAER375PjJcCWCSyNZVm0GXR6UUiEcrhUgycPf3fi-=sbwuCE1w@mail.gmail.com>
In-Reply-To: <CAER375PjJcCWCSyNZVm0GXR6UUiEcrhUgycPf3fi-=sbwuCE1w@mail.gmail.com>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Tue, 20 Jan 2026 09:28:50 +0000
Message-ID: <CAN4CZFN2T+ORwYnP=_uyAf_CkFBP5ecbphePCYQmwpwSZ1WRRw@mail.gmail.com>
Subject: Re: Periodic authorization expiration checks using GoAway message
To: Ajit Awekar <ajitpostgres@gmail.com>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>, Jelte Fennema-Nio <postgres@jeltef.nl>, 
	Hannu Krosing <hannuk@google.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, 
	Dave Cramer <davecramer@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAN4CZFN2T%2BORwYnP%3D_uyAf_CkFBP5ecbphePCYQmwpwSZ1WRRw%40mail.gmail.com>
Precedence: bulk

Hello!

I noticed a few things in the patch, please consider the following:

postgres.c:1076: elsewhere password_valid_until_timestamp is set to 0
when NULL, won't that result in unintended disconnection for users?

postgres.c:99: it only checks the expiration in exec_simple_query,
shouldn't it also be part of other methods (like
exec_execute_message)?

postgres.c:179: isn't the sys_cache_register_callback variable name a
bit too generic, shouldn't it have a more specific name related to
password expiration / authentication?

postgres.c:1082: the errhint text should have a period at the end.

postgres.c:4185: The comment for CheckPasswordExpiration says that the
function terminates the connection with FATAL, but the termination is
actually at the call site at line 1077. Maybe it would be better to
move that if/error inside the function, as the comment explains?