MIME-Version: 1.0
References: <aWTVEycKj7Qh/SXH@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA5RZ0vgN8nf7yPrk_uNt-ABFtRnRuz7-9CM=qSzUSwj=EEUKw@mail.gmail.com>
 <aWjbBd5z+LJNWX1l@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA5RZ0t6j0VYuUpxZ8JLq-ERoUriZ0rK=+8PCUtjRirmSmCx7A@mail.gmail.com>
 <aWojE18aF9qj0EPI@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA5RZ0s9j3x5UPpgaQdDyGA=MNjVEkT73SL7LMoVEKUwiZrVqA@mail.gmail.com> <aW4gwqVybB4INCvu@ip-10-97-1-34.eu-west-3.compute.internal>
In-Reply-To: <aW4gwqVybB4INCvu@ip-10-97-1-34.eu-west-3.compute.internal>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Tue, 20 Jan 2026 23:18:41 +0000
Message-ID: <CAN4CZFNT2E2UNHmYVwsYS-Hy6MNZgj0+bEL4pwHaMoRd-Qd5HQ@mail.gmail.com>
Subject: Re: Flush some statistics within running transactions
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAN4CZFNT2E2UNHmYVwsYS-Hy6MNZgj0%2BbEL4pwHaMoRd-Qd5HQ%40mail.gmail.com>
Precedence: bulk

Hello

@@ -264,6 +266,12 @@ typedef struct PgStat_KindInfo
  /* Flush behavior */
  PgStat_FlushBehavior flush_behavior;

+ /*
+ * For PGSTAT_FLUSH_MIXED kinds: callback to flush only some fields. If
+ * NULL for a MIXED kind, treated as PGSTAT_FLUSH_AT_TXN_BOUNDARY.
+ */
+ bool (*flush_anytime_cb) (PgStat_EntryRef *entry_ref, bool nowait);
+

The comment seems to use incorrect names, shouldn't be FLUSH_MIXED and
FLUSH_AT_TXN_BOUNDARY without PGSTAT_?