public inbox for [email protected]
help / color / mirror / Atom feedFrom: Zsolt Parragi <[email protected]>
To: [email protected]
Subject: Re: on_error table, saving error info to a table
Date: Thu, 28 May 2026 15:41:11 -0700
Message-ID: <CAN4CZFNxDsZ=VZSAWHxOM=Lkz-OY_V9eZcyno5FEP6=fzC09Zw@mail.gmail.com> (raw)
In-Reply-To: <CACJufxFd1pbip3SXcwTshWN21fCWOknKQHZ5c8tVYfPGWPQ-7g@mail.gmail.com>
References: <CACJufxH_OJpVra=0c4ow8fbxHj7heMcVaTNEPa5vAurSeNA-6Q@mail.gmail.com>
<CADrsxdYb3HZKBnsAUV=H2F_54MUPoqW-VTBbOqFTiNrb+LDN7g@mail.gmail.com>
<CACJufxGMOVr53-=oSMvogbX0BN5R73AD4sj0r1M3P6-x5XNwjg@mail.gmail.com>
<CADrsxdYsxbgmWYBWtjd9h8WaUw9TWzjKsREX7=Br5Z12ozrRsg@mail.gmail.com>
<CACJufxGcX2fKxQqjXJdnXLSVSyowrGiQ5i0960UbiKytu0gm5A@mail.gmail.com>
<CALdSSPgG5kyO-ZHj97BJ2trCde9=pFG9R7dXGZQxJd2Q6_W4qw@mail.gmail.com>
<CADrsxda5V4PO++zJOcF3PPzdZP_vHqHFnmXAd=ptPFbrtvOeGA@mail.gmail.com>
<CACJufxEYJ+NvATCk0Q96vztm65jg6epZjOeUV4mS8BkEn=dTwg@mail.gmail.com>
<CADrsxdbDqF7XUMSVfJ5z6_BpJwQPOb+4a2XuGf3y_zCEOHm1YA@mail.gmail.com>
<CALdSSPj6Gan6txiCCPa8LJMp2QVytBnMzQoc0i9iTPhEv4yD_Q@mail.gmail.com>
<CACJufxGsswQm1gHxM7gAb1j_UPOymtnOrAjeS5i+a5N00xM-Wg@mail.gmail.com>
<CADrsxdYG++K=iKjRm35u03q-Nb0tQPJaqjxnA2mGt5O=Dht7sw@mail.gmail.com>
<CACJufxEo-rsH5v__S3guUhDdXjakC7m7N5wj=mOB5rPiySBoQg@mail.gmail.com>
<CACJufxFVNyrzMxoDqLpmPgQPAco7v_KRUP+Z8L7JBVYCZ-NZ0Q@mail.gmail.com>
<CADrsxdbvG9f+vNRnetSjcSQPrQUKE9WyoSd7SsX+ESusYkFscA@mail.gmail.com>
<CACJufxH5d1Nh9HOoCjKFmph+N6xLs3CMyrqH_PA+GVP1u7N6ZQ@mail.gmail.com>
<CACJufxH_NbPuA+O5YR7xP4xDZ+iHkO2VFkddhrhBz+4-EUTp7w@mail.gmail.com>
<CAHEL7KSwRXeQNyh1zynYi9TKERU8GxR1iG1MfsvqKN9qZCtGfw@mail.gmail.com>
<CACJufxGBmz=W63R0ufSCEauokapWJg=YrvvcyjD+8ia1N5B-DQ@mail.gmail.com>
<CAHEL7KQrdjYbb-M=vPN0R1h02OPch4TpCNgK8He2_ec0SCbaxw@mail.gmail.com>
<CACJufxEaqr1tskQCM6qhrdwZVFQim9t2UBLoGvBo0OAC2i6uKA@mail.gmail.com>
<CAN4CZFPOj5LhzwrmcvKd8D0v_D6EiKSBFazDBCzzq8zAP5a9Vw@mail.gmail.com>
<CACJufxG5M6+b6dkVPVdN++iDvVE=5iEiymMgJrx711siwa3Rxg@mail.gmail.com>
<CAN4CZFPoohFvQTSE0wC+wcrfYiZOxFmUdOq0+9TCVR6Hk8n6iw@mail.gmail.com>
<CACJufxFd1pbip3SXcwTshWN21fCWOknKQHZ5c8tVYfPGWPQ-7g@mail.gmail.com>
Generally looks good to me, I only found a few typos:
+ errmsg("saving error information to table \"%s\" row due to
data type incompatibility at line %" PRIu64 " for column \"%s\":
\"%s\"",
Is row needed there?
+ * TODO: Allow cstate->error_rel to be a partitioned table. This should be
+ * not difficult, but requires proper handling of constraints and triggers
should not be difficult
+ privileges on it. During the error records inseration,
+ <literal>NOT NULL</literal> and <literal>CHECK</literal>
constraints are enforced,
+ and both row-level and statement-level triggers will be fired.
record's insertion
Maybe this could explicitly mention that failure to insert into the
error table will fail the copy statement? Or some better wording of
that, as it is allowed behavior with triggers.
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: on_error table, saving error info to a table
In-Reply-To: <CAN4CZFNxDsZ=VZSAWHxOM=Lkz-OY_V9eZcyno5FEP6=fzC09Zw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox