MIME-Version: 1.0
References: <7db341e0-fbc6-4ec5-922c-11fdafe7be12@tantorlabs.com>
 <c5c7cf37-218d-405a-8dde-520aa313830a@gmail.com>
 <988e3168-6096-488a-bb42-787e1e8c21a4@tantorlabs.com>
 <21FF6A0B-886F-4132-B6A6-0F4E934B4CEE@Outlook.com>
 <8ee9d903-bb13-434c-8145-b3769bf2b3cb@tantorlabs.com>
 <ff7d491d-f084-4935-8417-c0b7285cdd89@gmail.com>
 <CAHza6qdAH99C0xa27YDTixiNVFa99j90QYquUPAxL0JwahmggA@mail.gmail.com>
 <9e3054ae-1c5d-46dd-9b6a-7fb67764b076@tantorlabs.com>
 <CAN4CZFPb+iqQkby4AGvZSvL2OkwQ+S9CVvmJiQ=u6cckWPetqA@mail.gmail.com>
 <9067a807-f130-4631-8df4-076c6d7e43b6@tantorlabs.com>
 <bc73f8dc-07ab-499e-b36d-8fc8c98faa13@tantorlabs.com>
 <03aa576f-13bb-4ed1-bee4-0ee69ad8813c@tantorlabs.com>
In-Reply-To: <03aa576f-13bb-4ed1-bee4-0ee69ad8813c@tantorlabs.com>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Mon, 2 Mar 2026 21:37:01 +0000
Message-ID: 
 <CAN4CZFO3Y25iCqqP_zS1ipgbrBXvAkxeLK2hPuamddyW9ouAzQ@mail.gmail.com>
Subject: Re: Hash-based MCV matching for large IN-lists
To: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Cc: David Geier <geidav.pg@gmail.com>,
 Chengpeng Yan <chengpeng_yan@outlook.com>,
	Tatsuya Kawata <kawatatatsuya0913@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAN4CZFO3Y25iCqqP_zS1ipgbrBXvAkxeLK2hPuamddyW9ouAzQ%40mail.gmail.com>
Precedence: bulk

Hello!

+ if (vardata.isunique && vardata.rel && vardata.rel->tuples >= 1.0)
+ {
+ s2 = 1.0 / vardata.rel->tuples;
+ if (HeapTupleIsValid(vardata.statsTuple))
+ {
+ Form_pg_statistic stats = (Form_pg_statistic) GETSTRUCT(vardata.statsTuple);
+ if (isInequality)
+ s2 = 1.0 - s2 - stats->stanullfrac;
+ }
+ }


Isn't there's a corner case where this if order returns an incorrect
estimate/regression?
See the following test:

CREATE TABLE test AS SELECT generate_series(1, 1000) AS id;
CREATE UNIQUE INDEX ON test(id);
-- no ANALYZE

EXPLAIN SELECT * FROM test WHERE id <> ALL(ARRAY[1, 2, 3]);
-- Actual:   rows=1
-- Expected: rows=997

ANALYZE test;
EXPLAIN SELECT * FROM test WHERE id <> ALL(ARRAY[1, 2, 3]);
-- Correct: rows=997

DROP TABLE test;