Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vkedX-000gYb-1q for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Jan 2026 08:41:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vkedW-00CwMy-11 for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Jan 2026 08:41:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vkedV-00CwMq-3B for pgsql-hackers@lists.postgresql.org; Tue, 27 Jan 2026 08:41:22 +0000 Received: from mail-yw1-x1132.google.com ([2607:f8b0:4864:20::1132]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vkedT-002XKU-04 for pgsql-hackers@lists.postgresql.org; Tue, 27 Jan 2026 08:41:21 +0000 Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-79274e0e56bso53184937b3.0 for ; Tue, 27 Jan 2026 00:41:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769503279; cv=none; d=google.com; s=arc-20240605; b=HJmWi8fitO+5n4VS74IFBGFCmafQ3iWcXizaUPUx7JbBe4N0sKQI6OkLlxbNrR1jKs jhsK/h1OgLGsduaw1yCezBd4duoDxJtgaPV1bWfG6KrmqGnB62sRYCIvub44Eix9yuv8 yQkds1ZQdsBJHxBUs8bXEjzMX/zTXSBT6Z58lbGxSPywLojzwIn29fgYLQh8xardsWM0 eeZDTc/mPwVJz91Zzbo1Dfnx4LtOk7WRVIlnh3H8nqZVDIHx+joGf2nCGgBj/N7TjuI3 jCb9FNm6TQov4hermjd/bcL1UDqSy4su9/+PcRIhWNYBE5mQv2n7IY1RjU6RDlgccu2L 7rjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=8GaASD1WNVQA7WxAHxDIO46lDBjvW6PvT+wzWBONMWs=; fh=zYbzyK40I3DIbFON7bGcvDrmif1IyAviDcxTTETOTBE=; b=PTNI4JGKfhIeWdUYxJtDajGjsr2wVA+NkdaJ4Lmy+AyLmb9roP9804vNA8iSxJMEGh V5S8Ci1GdOP8KRS++5nWfyYgM5sH6/JOO9eQhD5J5TQ4oUyhSn7sZsoh2v2HEyxasPQU ycs7nkHhIUXu6yn8+XMn021qs5WHTvxKdBXcdhZNZ/m7jRv6hd9AiVdy+vi3QfzolXJi 5PpEBn9d047IXjRH3dgXS2hobky2QVjNIChVVHxnHNq36n1+T5OHujSqkPprMNCuiTI9 hZLnvnCH2S+JYrcgwC5WS/vu4vujfHuturOBC3WnPijQVUuugeNoRjviUWz7UckoEYB4 ZBbA==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=percona.com; s=google; t=1769503279; x=1770108079; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8GaASD1WNVQA7WxAHxDIO46lDBjvW6PvT+wzWBONMWs=; b=XoAbZqKAtw1fP/iQkB0xr+pcRTBP2alsBGY2JddVAvSs2hvjkj0eQEj8XBFFhIQ0On hA+Mhe9MaA4Fl9UIUC93Mxwi2yb9M7kygqr7hm7uY+uGFMojxFwKQ669fv25mmzrEHXS 5nZPfLtQSCuJQyzU69sErJzlw9oTfg2AqoOX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769503279; x=1770108079; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8GaASD1WNVQA7WxAHxDIO46lDBjvW6PvT+wzWBONMWs=; b=s7KDYB88aBI/vlGEdeiJ+Rd4spOO1ktWaE/fTYcumWt2S+X4hBFhepSFKtvH7vPmqj xNpTqjHfTngSOISksiKMKqYHebBto7KX5eioZUGKR27DpmgOvfZRx0MV0ky18mxpOv8/ /+UiqS+KNdcJBS2CvZEs43v8N5ITwAsqMxGU1tRZmxeMxEYJXiLSkUdf65Pp0lQG3OpV lCTf3xglzUsOzGnJ1+3D3h7seB/wC9Q10SeCS55uGxBposkwVQTbHD9wYxOc9F9AyM7h FWKzWNrZbwWUoCp4g/usyI1G4uPcDY1ngnaXe/1MxzyZSIV8uCkt1OJhBdNvrGSoh44N GK8A== X-Forwarded-Encrypted: i=1; AJvYcCWLJAXZogbH7NLgjoz1a+e2WuzmpTSaJ+PPdl72MP4C7wXS0+6bJ7Bf8VIZDH2QAe+WhKZfYoK/eRXK7/pO@lists.postgresql.org X-Gm-Message-State: AOJu0YwzRuTPn59z0sUdTOy9KI3aWkWZgoZCrE0xthqXtqWiD3iptN4q 2B4Qsx0eLOvvw+GAT2zRD6opI79y0dk5T0w0O4vI4jxanBXdY+bN4NWRgbVkZ50an0dM3JNuIeZ dN2gpIzeoe9/Ui22RUuq/9kH8gJbBjUUQBzUWeRdQ/G9ydlKvxHgqT3vFuOkN04L5dyC+aeXKh/ T8VBOPjGwL8mJVmrBHY9vMW2qtFj5kU21eGJ4nwYPAlUhBKXzlCAMPSrXk2GTZ6ryN5JwLa8+gX Xvrxn0+IlCMIvSx00cVPHPB9CxzRLulxFd+eGVFo2Surlfv0nMdI44vm2v0yVSgYy4= X-Gm-Gg: AZuq6aLr2Xw//7VeXF3xLI1GEQ2uNfOrIsEizqjkOSQphjKP81XE3b0Zq3m52DIY2Ac 799x7RDSmYeKbi1o/egR+UwqxGsyU9pHRaPRe6bpqkHnF0AOCAgdSkuONms473os0l8AD1eDTZD Xf/i2fuOmuv0di9oYYAjnNgdqfHWyL1AIQIWpiwQgJJoeRXRFR7JyvrrShpFc0P67TqcZ+xPx1u di4LCa0wsuSlfcv+1+sVINhoRf7P2aKrsahTguSyM3r+Mj3QaQQED+xOdORLBIpBCMHPmBIFu+e dKSCA+LGwnisaF47sAr1pbkcTDVuAjiZyhep2EjOlWMfsIg0P7RZlm3P X-Received: by 2002:a05:690c:e3ee:b0:78f:87f7:4f3b with SMTP id 00721157ae682-7947ac4c61cmr6579887b3.51.1769503278860; Tue, 27 Jan 2026 00:41:18 -0800 (PST) MIME-Version: 1.0 References: <07773235-2E94-478F-BEF6-38C73B0553B8@gmail.com> <16D5D52A-1B99-4371-982E-257C195D2924@gmail.com> <5244008D-79E1-484B-9407-21F5D388EC7F@gmail.com> In-Reply-To: From: Zsolt Parragi Date: Tue, 27 Jan 2026 08:41:09 +0000 X-Gm-Features: AZwV_QjNJ_8QXHgnn4VxGJM7VJCeMwbRFh2v3Z8kFDFbBvTcOEfWNTdYmRCvffQ Message-ID: Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier To: Michael Paquier Cc: Chao Li , Postgres hackers Content-Type: text/plain; charset="UTF-8" X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: percona,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > can the previous error path in > mark_index_clustered() be reached through a different mean than ALTER > TABLE? That was one of the things we discussed in the previous emails. The remaining callers of that function are VACUUM FULL and CLUSTER. It definitely can't be hit by VACUUM (it passes an InvalidOid for an index), but CLUSTER is a bit more difficult to follow. It seems like to me that it shouldn't be hit (CLUSTER only calls it for leaf partitions, where the check will be false), but I'm not 100% sure about my diagnosis.