Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUm7q-001R6Q-0X for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jun 2026 13:59:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wUm7p-001nmb-0R for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jun 2026 13:59:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUm7U-001kpg-2u for pgsql-hackers@lists.postgresql.org; Wed, 03 Jun 2026 13:58:56 +0000 Received: from mail-yx1-xb12b.google.com ([2607:f8b0:4864:20::b12b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wUm7S-000000013od-1RRi for pgsql-hackers@lists.postgresql.org; Wed, 03 Jun 2026 13:58:56 +0000 Received: by mail-yx1-xb12b.google.com with SMTP id 956f58d0204a3-66062a414fcso4939662d50.1 for ; Wed, 03 Jun 2026 06:58:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1780495132; cv=none; d=google.com; s=arc-20240605; b=b4Pvq9hWboTxuliu6C+OuyKcMidRR4dIajHup73lhFS+nXJg/HqbtKSFkIFGGbssXC gU6t7OGzLKx/v2J0FWSIUQ6kZop6SWswIIOGV8CGtY7jptNRu1pgDZns4o4mePkzOfEu 54u1eATgvbx2NeWpzzJ92U2fawdivtBqpme6Ibi6K66EwxIEiHoJeCY4Q5JEvrY73peC skvCLfa+mdYrpQq8OrH9WIlNbyDy6ILrc1xtxgFnR0M2D4ScDIx1Ws+JOSu+rmTMlXZP RV8YUBMWf23T4euhPBEcLIUzug+EK5Ao7NmByOrjOv6R0hioRFVUHUhbfWAuflpMuawV 3gxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :dkim-signature; bh=nNQHbm3B6tPwoE9z+V++cUmmp5sv7cHQ77a0loGdxJs=; fh=nwNxTtLLPTU0ewfLM7SSbrjMajMl+wwnFkCY/fi90vE=; b=LPDQVpzuEoTw0NmH5bgUBuNDCzQPPTDk+hbJdpHjij+YPwKeOmVmSfwB4Gyw9aIO5x xBlETzj1EoiTA95W1+iuydyL7P4uyBj9jcXCtd+84EbO1GocXnX4irli9G3JoSzTbxLK WD8mVOkpVOBZW7FBjShwsxWPdhECtP/gGWw8r3+xQWBiepP4/tTTvBLpYRhUssTiojTQ eAuusDI+jg3Z3YKKbnl6agAAzjDnbOgGX1Q0lJH6E43nr2yUG+Bih4nspIxGc4C8eKgR ajAUV4Z34zMb5tTHv1xhU23HsbHEmRFmYgplQneEi2kxA1ucOSKtUsXOAxiWCfYk0r3G gx8w==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=percona.com; s=google; t=1780495132; x=1781099932; darn=lists.postgresql.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=nNQHbm3B6tPwoE9z+V++cUmmp5sv7cHQ77a0loGdxJs=; b=WzE54EIXHw3RlQPPWuqLsnvtAOok6iI2EW1HRFITQVNNcqpOZ1XAz2LEhRQDMl/SiV e3ML7wROlwtIhAlVhoJtWhrf0Va1+qARdb11OuyErMfMVR8powiISniXhzY9P55fJFJP S+Dh52oNib5OsShs1A6PQhxrJnScP39bADBFQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780495132; x=1781099932; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nNQHbm3B6tPwoE9z+V++cUmmp5sv7cHQ77a0loGdxJs=; b=lDr+8KLeM2Ub0JzlgwaqC+YzBx3nyakpRRHlpzeZ0aRePQ9Q9w0D50zGhgQrKZNwEs cA0gsEjVUpBYF7vmB5DaiUgfOIy+AxpvGLjMKvQJIFW0PuCiceYFVNl5w2PO14LtCRkZ XJvAsyk1hevlK3HVNiOQrIXdrM4LtIajTBjla8ni/0TNTEFgWjdPF/nSIlkSf8TNoPFZ 9BWKhU8jTZcVCZoaXmuySZr53enmuPda5xLUAGTGCRulnknwWnOpZ8+LLLbPSoeCPa5w RiyxvnG2BGDayWVntklGuqk9VbfjPKrBhexFo0TFFaNPSbopLNir4GiQ9nUS9TpSAc9g RNWw== X-Gm-Message-State: AOJu0Yz5/p2H7JK4JfX3Zc7mp8/V1oOhQHRboSo8/B6I9LWO6DAt1+to 31uH+vWPskclnsJtav9ORW8xEj49VmpetfcaX/L0kVektua8uSr5y73YiXgKb45/5bkxy0LWXtI 47SOWWIoTJisEH4pkJPZ6Xy68AGjureyOme0YDUVes0JquutNb+oefzNQyfzO9b9Uk9tByZlZOA bmn5y6W8fbkyA1kvdDzHuXrTUXohoi3Xs4WvHYjiyEyj54ILzuFf/TJnsDYYc+YSIf2hqn2BcF7 PN7WyUYtXW1cTvpvXIWy8cpPhrXgHWzF/ViUjygEg8OIyTdhDc8GBu6v2tqeHzDHfoE3JGJZsVo bg== X-Gm-Gg: Acq92OG6wYerDNetIxdCumEEgiAzw3d6KPgbEUs4Lh7Pg2dXJvPWW5Dy9Cfc7K3guRf H9QFA8LXXDBUo+OUrYsrg0z6daUwNGDON7OWR0N/gt7+tINOZIStJiiVcwlVOCWtGGunGmGIlwz iz6uUDF8DbUPT2Jwed3OmL50xIA4m5sMR76RyWy77JmAlJV/Vqe0hPWlwLrtCX2LmXbKS1KBaUy DDa02jtjyq54n2o6NU5OFh9NHNxdtduX0gsNr/xN3fTFvuNSHPdMISJts0jhIzkLE5BoBM2Sy3H /0DJgjGRJ6neJ9TduQbUZSe0L8VcqLK7j9YQqDoyyA3fuGrZdUa6a/IOiYfD+DmPv+Dljb+XE4y 2Fzs= X-Received: by 2002:a05:690e:4004:b0:660:e35e:ac18 with SMTP id 956f58d0204a3-660e35eb57dmr1619917d50.51.1780495132023; Wed, 03 Jun 2026 06:58:52 -0700 (PDT) Received: from 298783833264 named unknown by gmailapi.google.com with HTTPREST; Wed, 3 Jun 2026 08:58:51 -0500 Received: from 298783833264 named unknown by gmailapi.google.com with HTTPREST; Wed, 3 Jun 2026 08:58:51 -0500 From: Zsolt Parragi In-Reply-To: References: MIME-Version: 1.0 Date: Wed, 3 Jun 2026 08:58:51 -0500 X-Gm-Features: AVHnY4LBBB454lQTNib7_hE9P9GtkTPZPm8E49EW_h08xwf0sKj_h9rQVPGlg_w Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: pgsql-hackers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: percona,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello + snprintf(conflictlogtable, + sizeof(conflictlogtable), + "%s.pg_conflict_log_for_subid_%s", + conflict_schema, subid); This and a few some places / commit message use pg_conflict_log_for_subid_, but the proper name seems to be + snprintf(relname, NAMEDATALEN, "pg_conflict_log_%u", subid); @@ -1767,6 +1771,10 @@ apply_handle_stream_start(StringInfo s) (errcode(ERRCODE_PROTOCOL_VIOLATION), errmsg_internal("invalid transaction ID in streamed replication transaction"))); + remote_xid = stream_xid; + remote_final_lsn = InvalidXLogRecPtr; + remote_commit_ts = 0; Shouldn't apply_handle_begin_prepare also write out the xid/commit_ts?