Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w4kcQ-002WDp-2X for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Mar 2026 19:07:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w4kcP-001mcQ-0G for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Mar 2026 19:07:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w4kcO-001mcH-2M for pgsql-hackers@lists.postgresql.org; Mon, 23 Mar 2026 19:07:17 +0000 Received: from mail-yx1-xb136.google.com ([2607:f8b0:4864:20::b136]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w4kcM-00000000faj-2aBb for pgsql-hackers@lists.postgresql.org; Mon, 23 Mar 2026 19:07:16 +0000 Received: by mail-yx1-xb136.google.com with SMTP id 956f58d0204a3-64ea73e7b60so3837104d50.3 for ; Mon, 23 Mar 2026 12:07:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774292834; cv=none; d=google.com; s=arc-20240605; b=US8okYLojAFTQ9B2SvuqW4n/tTX9GInBm2pSeQcL+Y+gu/xjx30cvuRHgZTPOy2sci N3S3BOYXG/W4gh4pUaQfqI3zUCzFsPlvLTALpE9eqDnHi1bnKQjM1tsVCP6N9wwbRV/D fJum3d7GR+w/obb7kxlYAy7z5Jsli3uDL5CtdTrxl8SG0sFP8kMeXXGCAI3UN58JaTTo KPmYuWIjhxmIO7I0l1eNENn0SMSiB+LNISC5c2/rvpqnL8h9dq5AB+Bwfjw4+MRJ7bRA AblsVTvsMegM3RmSeGeTFgMra2KCDTF0rW26ZSMlAayGS/UakUqvyEJJ7JZSSbfvWpMJ mrng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=y4gTUr3Ptk8GVx8+0N7+SwlKvdpkJ1ufRdw4GWgW05I=; fh=LKbI6q2KVIWvCOKGBHA37zt9e6DFzOEXUJV9DjYXiHY=; b=H86OehtQPVHzPw0jcY72YzjRGxqh2X+aQu2kmRyB0Nwstsw76ttmkfCAhIk/ewpvwI vdxwyG04Jzximyh4MeaMKh88pnYm4NzOf7js19dvb8oYUiiNiFvHbA8XJsZeBvIgQRGB fbNJWii7G3GvX/t/P8tloK9LnRkQm3VTJDzdQcbDutBlDPTi1E8ErT3TC0l70uTFJXZh R5ModC3y3Q9FWbfrWmhOvskC5NaMyzs5qoelnggLXv/tHgF2BPix7qpaTW/ghWvyM7O+ iW3AgR549uFyxBFkJ4Gc3Ugl2Iod3U48kPghA7TRCNzcj/K4kwqZ4amwTCmJSdr+Mczh zuAA==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=percona.com; s=google; t=1774292834; x=1774897634; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=y4gTUr3Ptk8GVx8+0N7+SwlKvdpkJ1ufRdw4GWgW05I=; b=ECR7+Y5brqbjxBpH4Cf8O5L78f4ArBmeMmFzcmuTUP1XI3gk4oY84N7yVoEH0RPsc9 rATtr7HEhnpHQklR1nhf4E2lFn83Wa1rOY2nMo2nWx/STics2EEi9zOYKKeyrPrub5v3 vLJsEu4krtLlMTE4hCTvOM3vHF17r+Qx7vkhw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774292834; x=1774897634; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y4gTUr3Ptk8GVx8+0N7+SwlKvdpkJ1ufRdw4GWgW05I=; b=cKq8OJqUlanlnC0mNO5MfU/eSyLLxZ3/0H35DnHEAmPIw3tncznngKuOyTtS4gAYVC G9TducNo8W6tf2vSQVbM039jl/janwnTusL5uciLuY26UCYNqoFFLWuYrNtEnAtzOWkx JgKER02OlorDpg1EXxY4CIx4HkL9w1DJy/dCef5P/F9AjaYn9BII34FPnYKtkBs/SeWo buXAFATrEfqVEHfACw4VgidlB79wechNklNS7xEYLj2MAS1XRNpne0Ws/lVGqabGlXGh 64qTZfXTImG0Q+Ve+a7cl8S2aI4ddZDJ9IJcLCj5IEJeQxSLxwYt2nJAt1AabLb+n4nt 21DQ== X-Forwarded-Encrypted: i=1; AJvYcCVdSoGBk5XUV3VVUzHfLzNgapx5kOZG5MsEuj4PkqNZI14fol1PsWckfdDVb++eXBkgFCkZ09oAiIuhRYwp@lists.postgresql.org X-Gm-Message-State: AOJu0Yx05QAQLJCDh7z81OyxsyMrsC6KiO0tcJShMK0ZrC4s9M0rG7C1 /eiXmltq93LWtin7nSmnn7EWdbSQMNp2M6AbCQXhF5qblbxYEcJ2oyumU5xWEPAsoMlzkaHrktm mPRS8H58IPINd885fPssSDLCyEJgeXqz//iuy4YfA7670B9wBopf7QbuBVEVC24N+jAR+j9ZGp4 S1N3dRdFtawrjMr6OX8vrFqAhf5+XGyhBThLuEpZoglrwPljElUqaZ6/zrb9WKKUW3Sk1We31Z4 k9ceHZKseZ2/Un6+8jmUNpDxC0sYf1Tj0KxF6HupflfJuirLfACgWNIwOKpj5tir4M= X-Gm-Gg: ATEYQzxjPtuaLRag4hyBTiasqtA0iyXHmyhxSmKF1SH1mCh8Atxr7DsZOggEGwP6PxO 2cgXt/9FMS0yQMICC+auKclx+0ZNkBKQouF5q1rn4VfzrovDWySbU88I7hnDbC5IjwMBiT0kCak HFA5Q8vhXqyPFCWxdRRTyCJnqBC7GXpFoSFuwtUWdLNKFJ/UWnMY+vIKm0lxb07INk8xxt0M0D8 Sax9vanfkQyEoIYn5gGR7hl/40/Gx9jbAUzt7wJ90rkuLnf91d+jo6Lp2tDY95EsudgLbavo7CU Ge1lF6sYfO4j8XOUb/+yRi7KHTzTIEua0cw0iXN2yIkoDwi6/Tu550482C2hvCkexEsk X-Received: by 2002:a05:690c:4d86:b0:79a:8dd1:53b9 with SMTP id 00721157ae682-79a90c4fb0bmr145365697b3.55.1774292833527; Mon, 23 Mar 2026 12:07:13 -0700 (PDT) MIME-Version: 1.0 References: <06086cb4-881b-4f5a-96af-f275220ff52d@vondra.me> In-Reply-To: From: Zsolt Parragi Date: Mon, 23 Mar 2026 19:07:02 +0000 X-Gm-Features: AQROBzBb60gMOasDf4E-WuZRvHYKaRh7UbW91NS_Nxo-9LpCzVZ_KOFx8yd4Y18 Message-ID: Subject: Re: Stack-based tracking of per-node WAL/buffer usage To: Heikki Linnakangas Cc: Lukas Fittl , Tomas Vondra , PostgreSQL Hackers , Andres Freund , Peter Smith Content-Type: text/plain; charset="UTF-8" X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: percona,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > I'm looking at this finalize at resowner part of this patch, and this > maybe a stupid question, but: > > Why does the instrumentation need to be "finalized" on abort? If you run > EXPLAIN ANALYZE and the query aborts, you don't get to see the stats anyway. The pg_session_buffer_usage in 0009 makes the information available, I was able to see the issue with failing triggers with that. Even if that part doesn't get committed in the end, a 3rd party extension could still implement the same thing, and notice the missing statistics. (And maybe it is useful to see some statistics about failing queries?)