MIME-Version: 1.0
References: <CACJufxHJAr2FjbeB6ghg_-N5dxX5JVnjKSLOUxOyt4TeaAWQkg@mail.gmail.com>
 <CACJufxHQ8tDG09mXW=8xfEK2_h+By1zLgrFd0EcshHp-TDGiGw@mail.gmail.com>
 <CACJufxFu7Y4FhVkaKT2Kaj8ym2T5TcwN93cR_6h4x66iLrSZ-Q@mail.gmail.com>
 <CACJufxHMYq2ZqvOhoSKUmx+wZUo=HixjfgGKDJ6L4cdCvwh2VA@mail.gmail.com>
 <AF1AE30F-4379-462D-B321-FB1658230B5D@yandex-team.ru> <CACJufxH5YDMAQ_KXaPJaC4Zt1i2HNSNaYoskzNDRjSrE_UWjKw@mail.gmail.com>
 <CAN4CZFM_8jL7Rf43zLa-9P2BwC+_H-oM9kYxVLGcwu83KC6faA@mail.gmail.com>
 <CACJufxGGXnRP+Em521KvPVOmnPtya2zpPqrTuYDmrSY=AFVmfw@mail.gmail.com>
 <CAN4CZFNPE_UeTEy5TH9wwc6mBAtX7vnBhLSL47jRiHXA=6yXjQ@mail.gmail.com> <CACJufxGTxbpbaQjUxc69-Dovx6+KJd=81T5111uizUrdsEkDNQ@mail.gmail.com>
In-Reply-To: <CACJufxGTxbpbaQjUxc69-Dovx6+KJd=81T5111uizUrdsEkDNQ@mail.gmail.com>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Fri, 6 Feb 2026 14:49:01 +0000
Message-ID: <CAN4CZFOdet_ZZEr+sZhTUiAd-fjOprhMXDhkjdhz48pEoJc9Pg@mail.gmail.com>
Subject: Re: CREATE TABLE LIKE INCLUDING TRIGGERS
To: jian he <jian.universality@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAN4CZFOdet_ZZEr%2BsZhTUiAd-fjOprhMXDhkjdhz48pEoJc9Pg%40mail.gmail.com>
Precedence: bulk

This looks good to me, I only have two minor comments:

1. The test should drop main_table1 and some_t1

2. there's a missing word in a comment (do -> to do)

+ char    *trigcomment; /* comment to apply to trigger, or NULL */
+ bool transformed; /* true means no need do parse analysis for *
+ * whenClause */