MIME-Version: 1.0
References: <DDPQ1RV5FE9U.I2WW34NGRD8Z@jeltef.nl> <DFJ3E1X9169E.WV892I950LYW@jeltef.nl>
 <DFY0RHAZTTXJ.15AD95RE6A5N5@jeltef.nl>
In-Reply-To: <DFY0RHAZTTXJ.15AD95RE6A5N5@jeltef.nl>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Tue, 27 Jan 2026 12:56:50 +0000
Message-ID: <CAN4CZFOw2v9G_9vuP0vnNH8K9X_UeSOyq=gWJp7bdGZ5HKNTDA@mail.gmail.com>
Subject: Re: Add GoAway protocol message for graceful but fast server shutdown/switchover
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Jelte Fennema-Nio <me@jeltef.nl>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, 
	Dave Cramer <davecramer@gmail.com>, Jacob Champion <jacob.champion@enterprisedb.com>, 
	Heikki Linnakangas <hlinnaka@iki.fi>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAN4CZFOw2v9G_9vuP0vnNH8K9X_UeSOyq%3DgWJp7bdGZ5HKNTDA%40mail.gmail.com>
Precedence: bulk

Hello!

I only have a few stylistic comments and one question about the wal
sender part - but maybe I don't understand something there.

+ /*
+ * Only signal regular backends and walsenders. Skip
+ * auxiliary processes and dead-end backends.
+ */
+ if (bp->bkend_type == B_BACKEND ||
+ bp->bkend_type == B_WAL_SENDER)
+ {
+ SendProcSignal(bp->pid, PROCSIG_SMART_SHUTDOWN,
+    INVALID_PROC_NUMBER);

I don't see related changes in walsenders, am I missing something,
shouldn't this have some handling in WalSndLoop? Also, shouldn't
walsenders exit later, after normal backends have already stopped? So
I'm not sure how this is supposed to improve them.

+ /*
+ * Parse any available data to see if a GoAway message has arrived.
+ */
+ pqParseInput3(conn);

This is just stylistic, but other places seem to call parseInput instead.

There are also two typos/mistakes in the documentation:

* "rquest"
* "server requests the server"