Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1w2DsR-0006Do-28
	for pgsql-hackers@arkaria.postgresql.org;
	Mon, 16 Mar 2026 19:45:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1w2DsP-00CVmP-2n
	for pgsql-hackers@arkaria.postgresql.org;
	Mon, 16 Mar 2026 19:45:22 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <zsolt.parragi@percona.com>)
	id 1w2DsP-00CVm4-1g
	for pgsql-hackers@lists.postgresql.org;
	Mon, 16 Mar 2026 19:45:22 +0000
Received: from mail-yw1-x1134.google.com ([2607:f8b0:4864:20::1134])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.98.2)
	(envelope-from <zsolt.parragi@percona.com>)
	id 1w2DsN-00000000ToD-2dLY
	for pgsql-hackers@postgresql.org;
	Mon, 16 Mar 2026 19:45:22 +0000
Received: by mail-yw1-x1134.google.com with SMTP id
 00721157ae682-79a50948018so13971897b3.3
        for <pgsql-hackers@postgresql.org>;
 Mon, 16 Mar 2026 12:45:19 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1773690318; cv=none;
        d=google.com; s=arc-20240605;
        b=DNRrMfV/d+9klCd+kzHrjrMd2UjjijzWuLNIjiI52rPuoTWtkdTKR30OWd8yoq8uHW
         Jlh0YqP0DlxZGalyJVzLk4bZ2E7Slp9GFx2ecuQKWlsw8jMpFNZ2MUuDx30dt+UD4keA
         kwjxvU2e4GVOqrtvr4WVKqXHWcCA8X9b515TbT/slmCLEo8Z+OApf52w/ZLnA3pk9eGN
         ALYwa6XR4fb1GmI069IH6tx1YHv3AdIKg8IEv/DaZZae6uMkCv+wTJj+mlA+odNmOyz5
         zHxhDoFDIQPcj300dx3vw8GtZzMNgSHOeMbvO4gCud25N4D6KkCzj4PR0CsCDf3f3NX7
         25Dg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
 s=arc-20240605;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:dkim-signature;
        bh=BI9Qxick+F+I391YhimjtUUcWBwDi5W1Ie4N7aLOSPI=;
        fh=4BqCP2lqqsFXFuPQfyZvVUQrTZyS8iG9akUu4+8jAfA=;
        b=eaKAVK3QixUX/fMNb0uw0l4NQKrl2xNw9yVBtf59HRDiPks9eMGGDvTHgW+pFs/q0P
         Lz9sOMW9f9FT0TnIg5Q0xkzHOVKJdwhChgbgKACvkzGH8D6nBGL9OGPKekyFjYorlo5I
         DRji6pMi22LY2yLgST0PM0/rdMC8W9m1X1grpAcglFkmeGz+9zCZoL8UfKv8yzly+QPq
         TM3/2joTK+sebcdJ4UkXIkU4yiEMPsTSxCxESocrXxOwKcbna6sQL05VzTI54/oBk/4B
         TQlxGixWKjLq53jwRxYAYO/HvGPrm42DEP71lspqDzwz5SwzBQeu7m1rt8xoX/NlD0cq
         aSmg==;
        darn=postgresql.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=percona.com; s=google; t=1773690318; x=1774295118;
 darn=postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=BI9Qxick+F+I391YhimjtUUcWBwDi5W1Ie4N7aLOSPI=;
        b=ZS7iBYV9FOTKwRMUlOfRXeS6CvNcrUUov/jRMVpvnlA5Kb0W1KOg7CuSxyGJJQG/2s
         HbEr4lQL1WS7vqPMTr1Mjau0/rO6hJn8v7yncAdkfWTWbUnJvrB2wrS6ZJKjrgDhrJGY
         EgRKgBufteeVvLA6RFMleC9Em30QZo6T4rBEc=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20251104; t=1773690318; x=1774295118;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=BI9Qxick+F+I391YhimjtUUcWBwDi5W1Ie4N7aLOSPI=;
        b=fITPtq5o+Dl4AQgt/7nlNUKCLvwDBSGLqJ3B5XnE+C0QSXh5GK2dVuY6WZ6vxvv+9L
         bDQLpxIrt6+WLfWgx1m0SoEP9Dos4zXQgWKE+q6pyGfTg1iDaKOaja/rYC3elWhvFuUB
         IyZQVXwxHaLFk3ZSAmYxXh+X40PURHWMo1xavzwtxgFNh3pzRhA9odHxENlcLUp9MqZh
         v1JmIp2wS4AsLpeFt3lyfkIEkU0i+7mcZlnClHVkP6z5beGFuOKiyAj7nVksf0/vI5g/
         TQ/F+0qt5cDqmbkdnPYe4vsScGCWljy+TuJ7Z6J9+IgWhH8prCYRWLMBO/HlDbYbREsl
         hppA==
X-Forwarded-Encrypted: i=1;
 AJvYcCV21GANkuqj7f8P/jIweZiqGovmgh9YH1eEb4RymCFgKY1gahjk4P0VYmdE6ziv4SUHy8XOv9w5W+vsP3rr@postgresql.org
X-Gm-Message-State: AOJu0YyY/28mdL5gNiZeU9VFGgk2VRYBuZNZud5Go/imdfHKZrpXQBWp
	c70i+Eh1q46H3oUhUKnRWD6k/0T5XFOKEcEPuDj0QQ+NtdmGVJ1HxKgPPcBssY8+N/Gg6NI84kS
	J6sZD1g3STRpPsNMwfD/NDkQOj5YHjKKz4sCPyW+6850GaaE5LFRyEoPLROl1DwDd2IKB7ibFmE
	TtsBS2T0F5OE3FmpgqpgJKkaR1B0NC53NlNwg+12gDSX4TkHGhj82Sm1z9f5wxbx8ajlajiumUH
	Sdp2/J8RbEcTXs/gPG/KgsnnzXhnyNcy68GlaHVF3OYHk6XY4tOkzswTZSm5ZBWyRWnCw==
X-Gm-Gg: ATEYQzwVZceVoLBIcuOK9TNdBErgYLBMTAT060CeG0uLhNatjLkZtEepYIimsvtPP9F
	B4xXaFnkpHmQQZ8o2ZMTE+Brk/qRRIuO94jp8vB2xWz5ut8eLO3FlBJBg8zNBKI+9a6oBMR27vN
	+ZBvlUKerOP1cKjw2LzmnHu77RikeUKoJWHPHLFpiRQ5a9IQaU+Ybtb+HzvynHn3SBesD6IvsIe
	fMcCayh902FPHGympbn5dh7BDlfTp4WX92NOEPuKT8YQDiF4NqRlOTi5UExgjUFTUtdmDHvzlNZ
	qgC/fPrLly6bHTF/qVfB+jH2jbjZnlo4PRXIMCgk3ZChTTfM6ayv/319Gn27VRTxs1xj
X-Received: by 2002:a05:690c:ed3:b0:799:330:79dd with SMTP id
 00721157ae682-79a1c1cd90amr148647567b3.46.1773690317723; Mon, 16 Mar 2026
 12:45:17 -0700 (PDT)
MIME-Version: 1.0
References: 
 <CAN4CZFPim7hUiyb7daNKQPSZ8CvQRBGkVhbvED7yZi8VktSn4Q@mail.gmail.com>
 <7DB528BA-C7A0-4B23-890C-5332FB35A16E@yesql.se>
 <CAN4CZFNNfhFCQdFWui5HWbQR60eM-cyndZ7YgSv7b5SKxB9C2A@mail.gmail.com>
 <CAOYmi+mDSmh6RNizHRmMAwg4ZP2W=uai3Fr3-wm186NMypf_Pg@mail.gmail.com>
 <CAN4CZFNJftK8NaREYaLi-wqpEz3=crQ=1+3f_XUVji=aOrDSWA@mail.gmail.com>
 <7094F798-8DD1-4974-9A04-10E147B29581@gmail.com>
 <CAOYmi+kjtmRMBdBU3_bGKGDoRSK2AErXbGtHkAjFRapcQNmjhA@mail.gmail.com>
 <CAN4CZFNWBXtF-ML3yzdOvX3QEuUwVo5VrBzyWU3O=y-7SeDstA@mail.gmail.com>
 <15434512-B3FB-4AB3-B6B3-5D85ED0B4BBE@yandex-team.ru>
 <CAN4CZFNscs=hiOkRJYF39r7AD7ef9+MR+O2BQdEtE_2Ajdo5qw@mail.gmail.com>
 <CAOYmi+nVzkoLjzNk_58e0NnUPi9uVXwmurK2QP6CzC2WOpqwbg@mail.gmail.com>
 <CAN4CZFPjiUQbKo2q+ovs--AHkjvaE8OJyncB9xu5b+1gp=HHPQ@mail.gmail.com>
 <CAOYmi+=SR_nJJBh7UXZzK8Zbs21L2RUNkW3d9aPRkQOHj1bBPA@mail.gmail.com>
 <CAN4CZFO7ju7fjjv+qwObP8_V-Tdx463zV8F7u_s6wtg9ANVWVg@mail.gmail.com>
 <CAOYmi+kEYA0Tp2son-+Ti1wvSAPov87AVFf4qXATTOHRX1F2gg@mail.gmail.com>
 <CAN4CZFOmym1BaV_U2V56aOyRp2JMrw5nfn6kwcAEcu_RWK-F3Q@mail.gmail.com>
 <99C6E80B-8770-41C2-8084-BF3C7F389FFF@yandex-team.ru>
 <CAN4CZFN7u1kX3_0cfyVvtfiWpORxnvZo=xCr9Ag-F5Onp-hpbA@mail.gmail.com>
 <1B58D836-6B8F-4B9A-9B84-08965E5AA06B@yandex-team.ru>
 <CAOYmi+kxfGEKw7frQPxWYEA6Qe4BLc683UCNPTYCLdCCV0b4Jw@mail.gmail.com>
In-Reply-To: 
 <CAOYmi+kxfGEKw7frQPxWYEA6Qe4BLc683UCNPTYCLdCCV0b4Jw@mail.gmail.com>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Mon, 16 Mar 2026 19:45:07 +0000
X-Gm-Features: AaiRm51QGNuf0tpkQfVa08BGOdPUlWE7FFLJvjz6drM80BQ3uPA-rjEaaubq-6k
Message-ID: 
 <CAN4CZFP--Ec8hMgpu7JojgK9qS08bNnev0c6goA++T4Ozy8bOQ@mail.gmail.com>
Subject: Re: Improve OAuth discovery logging
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>, Chao Li <li.evan.chao@gmail.com>,
	Daniel Gustafsson <daniel@yesql.se>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Content-Type: text/plain; charset="UTF-8"
X-CLOUD-SEC-AV-Sent: true
X-CLOUD-SEC-AV-Info: percona,google_mail,monitor
X-Gm-Spam: 0
X-Gm-Phishy: 0
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/CAN4CZFP--Ec8hMgpu7JojgK9qS08bNnev0c6goA%2B%2BT4Ozy8bOQ%40mail.gmail.com>
Precedence: bulk

> I don't
> want to escape the authentication flow from inside a SASL mech, though
> (it's unusual/invisible to other maintainers, plus it bypasses the
> ClientAuthentication_hook).

I tried to figure out if this is fine or not, but isn't it the same as
the existing ereport(ERROR, ...) calls everywhere in the sasl/scram
code? I didn't see any clear pattern, for example the LDAP code
clearly uses

ereport(LOG, ...);
return STATUS_ERROR;

 even for internal/configuration errors, while the scram/sasl code
uses ereport(ERROR, ...) for those errors.